From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB100A0C43; Fri, 15 Oct 2021 00:17:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 701A240041; Fri, 15 Oct 2021 00:17:08 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 69DE94003C; Fri, 15 Oct 2021 00:17:06 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="214964149" X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="214964149" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 15:17:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="527768097" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 14 Oct 2021 15:17:04 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 15:17:04 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 15:17:04 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 15:17:04 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 15:17:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQrDBsDCiUAZYkdYfUU8eoyg03F9zYQUqaNM9vnz9L7U5IWpR2A/JZKgV4+wuIpDCu9NMRIkZKsYPUK+WJBV6IEqxFmhvB824ols+xwEMmhM2UN89m0um0+E1K7Wot+A4ckc1olhSEHySxmL0OkpoBincpGVmn0aPcKT5WGh2s9VXCCXSfUsp9S4A46g4j1HO8IHvs2/6AZxeqehDtqj1s8MPUArH0VRec5G6IcmkzjmZG4nO3F8jLkAY9wbSxtuttGOIbl337CDZCFDhp1ggqqnVghMnwzBTl2ZSTIu5xJtChv2Hr4WOTL4XkbT0DQs2HTR3m5M8OvYPcYhoLpD8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oYzqnKjU7UaFufFEOuCp6nAMvL51Bs3sBPt7CVU85fs=; b=ZosMpeDWX/FbEyPVugFM/zSkoP9MSSeHdtUNoi4zeP16G8VMKtcUiJ61dVBDo+11WTUDJYApIgbA0/AIwsf4X6W+8VMbFVRNLk2/5knhdMBsfSK6sCiDDHQR2XBKjIyAtdnLD0NicCpP8y3bAckylyHnVpFkhu0f0U4jOgL59FUmwZJZcpPLF9WQCg7pXiNMi/51rERPTvsUS6Vv6KysCMIaN/ouPf9sjE7wyCZCqUW++nL/GegXjXJ1BRzJ0TD42iGJ35IxyRDt7xOy9M7PMba+asjNym8ZoCAl9UvjwVAyoW0u8MPU76juzo4VNaOiZQRQWyJiNkgMPVwca0Motw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oYzqnKjU7UaFufFEOuCp6nAMvL51Bs3sBPt7CVU85fs=; b=vYM8JpH9vZajc7UukAKgeRn9+6sRbUOXY6rnJYM+bvJuUe+/cx7WVq7srRthgbugOmJ84cn8esNngM/KC4Um5TcUamHz/vJQTUEfSnUzL8IjzGI5MGxWgj4vEB+IGTn1qeuGE0DgrerBAW5BnnWGqBlrwrC7V73SSALLaAp+j0o= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4965.namprd11.prod.outlook.com (2603:10b6:510:34::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Thu, 14 Oct 2021 22:17:01 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.017; Thu, 14 Oct 2021 22:17:01 +0000 Message-ID: Date: Thu, 14 Oct 2021 23:16:49 +0100 Content-Language: en-US To: Andrew Rybchenko , Stephen Hemminger CC: Rasesh Mody , Shahed Shaikh , Hemant Agrawal , Sachin Saxena , Haiyue Wang , "Gagandeep Singh" , John Daley , Hyong Youb Kim , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang , Shijith Thotton , Srisivasubramanian Srinivasan , Zyta Szpak , Liron Himi , Harman Kalra , Xiao Wang , Thomas Monjalon , , References: <20210928141627.904787-1-andrew.rybchenko@oktetlabs.ru> <20210928164854.1092217-1-andrew.rybchenko@oktetlabs.ru> <20210928101054.0f6ad088@hermes.local> <20f9d684-4a15-b870-672f-7301bd0503a0@oktetlabs.ru> <4b39a7ed-2367-b3f2-10d6-6f3d5fc719be@intel.com> <040e1bb1-dc45-7dff-ee60-e9d82d4ae027@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <040e1bb1-dc45-7dff-ee60-e9d82d4ae027@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0043.eurprd03.prod.outlook.com (2603:10a6:4:54::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0043.eurprd03.prod.outlook.com (2603:10a6:4:54::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 22:16:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 15b75bae-ce10-4746-6a6e-08d98f605806 X-MS-TrafficTypeDiagnostic: PH0PR11MB4965: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uX9/vxT6H85cB/EwC4rXLd4uUMytp31jan+kpjWrk1xqlwk1zjL2n62vqc9EOVuPbBYDP1Pe04rvtmEZIyTX5w6bWgccprLxMBXCK7NwCqpBsIwTtfuVedZSF+34pyg1B6Jav8OkbK5DUJW9qnHjt4cBtOt7vDl0D5VPjVqHaNBzKPtRWWHvLwQhA2mqY0UHUVhwm+qS2xpgjp9VvgB80TjAOlo6QTuuntdxbanH9+j1oxWw/Byo84sa8qPjdEibhnmFrOgyimYSChhdNOHfyoQUzNc4fkSaY9TLJQhx0HiH7i4K1X4PvfFlRhjvUyvSj7e2edNX8WEE92bTbeVIFlzA6TpTUnefnbkaBv0RtJA78PL1oK4b2jRSEN88jtjtSenG/uFYvAK6kD0nELw+xUbV4XrE5WiBAm33gMbUiY7DqbL62KFy5NjVlUG54MManxM8wuRz8AlISG+koZVB2VxyMp7gEAxhLb6tVutA7WYvGRWkMDWAkYtD53Qu/hR0VEhzhAebVK6oBq9PPyxZVU/GVW5lXYwxAHnOjEHKv8YmnnRmBnqJF9xpKv7t1kc8ImcWVyhyh/xKLo+Gt+d7byakjXHSHBJNuhstLxXbvYP1K2agI+PdTVP8lf12Y43yYxJWsoVnn1KS3+bhjP+bdDZZYC3SrdY3w3Je6u1fznP31ySsRDGxAB5hfVzIHh5oIPMXf07Qv8VM68OgJ/MwlA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(86362001)(26005)(2906002)(38100700002)(8676002)(316002)(53546011)(6486002)(31686004)(44832011)(36756003)(6666004)(66946007)(2616005)(66476007)(66556008)(956004)(5660300002)(186003)(508600001)(7416002)(4326008)(83380400001)(31696002)(16576012)(54906003)(110136005)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTZEeURzc00zNUlNMFVsVTUrUUFPaDFIQVFCNFlGVEZERGU2YjZXM1l2WENm?= =?utf-8?B?ZFlsSExqVzZ5b0dQVTF6UUIxTUpSa1lrcGZBYlRTT3pDM2tyKzErRExXSFhI?= =?utf-8?B?Z3hLdG0yM2pvZXkvcGF6OWlra0ErMEtrSWJ6anpPdDRlQTVHYmNMZ2dtVFBL?= =?utf-8?B?LzhTc2xEOVRtWkZYdzNyQVBUa3QwekJGVkQ2M1Znc1MxS3NzRHV1Y2hCRFpF?= =?utf-8?B?WTcxY1hDa3J4M2VMZWMwOVJoMjlzNVhKcWZVNXIwaW03ZHFCRTd2aU5zcGhP?= =?utf-8?B?RWlWb3VNdnZ5blFBV2h5YWdzTUlSS29zOWtXMS8zTEorNUFUci83NVdnUzM5?= =?utf-8?B?WkFyNzV2dnB0b3pxZHJUSEpXbWRwT3I5RTVhUTZHL0QvUmh6UFZldVdtQmhr?= =?utf-8?B?NTN3L3AzWWNjazZySW9GT05QUWZzcVdWTEZqVnZ4T2xxd0ZNUUxMQVVvejNT?= =?utf-8?B?UkxUVjhmU2hrSjA2dTRVVjhIR0EyMjF5WVVLZzhiVHAzbWJPL1ZCU1dMVjMz?= =?utf-8?B?MUZOUHkvdWxHazEyN1dSSUJQc25PRmtQbHNiS1N4VEpReFl1NVRJK3d4aThz?= =?utf-8?B?ZjRxRm9Ec2VVUUNPZjcwSmFZWXdPZjVYTHM4SDd0QitPcmpTNWc3MklMRHo0?= =?utf-8?B?NXZEcXBMREI0N0dlY0ViWkRoOEJrTkxGRVY3SkxoSW5ac2VwM00vZ0NZNFBt?= =?utf-8?B?Q3Uya2owL0ZXd3N6c0I1MGtJYlE3bEVBYWpoTmFSNnduTFB2bENwdFJYakln?= =?utf-8?B?cUlJYmJYMVFKQ1NxU2tLUCtONFZyVGMzb2U4TmhUaVl3RFVoMXZPcWJmTTJn?= =?utf-8?B?OVVJQThENGh2bXpBM05NY3lwTUFNOE0yV2NWRlVpMThuS1hQYTU3M2VndTk5?= =?utf-8?B?LzJ6cFJlTWpoRkNYUldBR1gxN292M2xNS2dya3RwSUxBeEFuakdxdHZmSWZE?= =?utf-8?B?VjllMmhYQzZONHlJQmViYWh0QUFxWmR1bHhuWnlkMVBqRFB6WHdEWndjQ21r?= =?utf-8?B?d2phUG5BdTYrQmxtcVZrNzRzVFpmdDJ1bGhRZmw2TGFoM0Q3VjBCajJ3ZWI2?= =?utf-8?B?TWdhaWx1eUdIUDdraUMwMVpIbG1hM01adTdYWlB2YVlud0xNWEUxU2JHbDNG?= =?utf-8?B?Sk9IeDJvbDFkbmdLQkRtbUZ1TlVubDZXcXczczMrb01KYmFkVkthMGZXMkNv?= =?utf-8?B?YlNaUjlFR2g0YVVWTTRQOTc2WFBYeHVTMlRuMGVYWXB5dU1POVhValdXK2Rv?= =?utf-8?B?VWczcC9zdmd6c3dsZWZ3OXpqeWFRTVlrOVI3SURpOTl5eVJ6NXArQWhVelor?= =?utf-8?B?VWpsWlRGdVBPL3JDMGRsdnlYYWNoL3U5WGZGc2l2dzJSWmZPWUtHeDhVc2VM?= =?utf-8?B?Vm1oSXpUL1NqU2dlY3pETHBrQ1huaitHZ2s0T1pXUUxmb2lwVEN4c3FXM2J3?= =?utf-8?B?cUVnaVZET1ZsOHZNRGRGOTErUmQrNHlwc282cTJZMEhaWU9XMDArVGJPRENw?= =?utf-8?B?aE4yckJzcS9udVA2NDlOdkV0UFZvTGoxWnVvVHlucWpJRDlSTTFHM1lLNUJv?= =?utf-8?B?Z3J1NFdPN21ZaDFCc1p1dnEyTnZTbmNmM3BKS3NtMnZyRm4rZm14d01nem9Z?= =?utf-8?B?ZGFzcnYwV3FrV3lNaGcwQ2V1dlRZWXdDWll3RmtrZzBvVWxxUEtRWlJ5SXk2?= =?utf-8?B?d0tyaGs1Rnk1YWlESVJ0MXhiYmtlT1hJU1ZPUUk1UEV0NlFJcjRDWXlRclNR?= =?utf-8?Q?mGiakQ3xactI7szas534Sfq1kVcnuZnL3Lp08k6?= X-MS-Exchange-CrossTenant-Network-Message-Id: 15b75bae-ce10-4746-6a6e-08d98f605806 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 22:17:01.2017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E3bV+qgOsN3IZbgIe4VymY++WPpHYDw5/Xq7fewXnrdOWLHqfTYwWk4BYrIBROvnaHuN0F0sBF0lgkZByZ4MXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4965 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] drivers/net: remove queue xstats auto-fill flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/30/2021 2:50 PM, Andrew Rybchenko wrote: > On 9/30/21 4:45 PM, Andrew Rybchenko wrote: >> On 9/30/21 4:00 PM, Ferruh Yigit wrote: >>> On 9/29/2021 7:38 AM, Andrew Rybchenko wrote: >>>> On 9/28/21 8:10 PM, Stephen Hemminger wrote: >>>>> On Tue, 28 Sep 2021 19:48:54 +0300 >>>>> Andrew Rybchenko wrote: >>>>> >>>>>> Some drivers do not provide per-queue statistics. So, there is no point >>>>>> to have these misleading zeros in xstats. >>>>>> >>>>>> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Andrew Rybchenko >>>>> Really? >>>>> It is useful to have zeros rather than random data there. >>>> >>>> I guess there is a misunderstanding here. Auto-filling xstats is >>>> an addition of per-queue basic statistics to xstats by ethdev >>>> layer. It makes sense to do it if and only if there is some >>>> sensible data there. >>>> >>>> There is a related deprecation notice saying that per-queue >>>> stats should be removed from basic stats since per-queue >>>> stats should be provided by xstats API natively. >>>> >>>> Basically RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS means >>>> that corresponding driver is not ready vs the deprecation notice. >>>> So, I want to clean it up to see not yet ready drivers only. >>>> >>> >>> As you said, 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag set by driver means, >>> driver is not ready on representing queue stats in xstats and ethdev layer is >>> filling it automatically from basic stats. >>> >>> First we should wait for drivers to implement it, later clean queue stats from >>> basic stats and remove the flag. >>> >>> I am not sure if we can remove the deprecation notice in this release, but agree >>> to add a deadline for the drivers, which can be 22.11. >>> >> >> I'm going to cleanup deprecation. I don't touch it in the > > Sorry "I'm NOT going to ..." > OK, I see now, I thought intention was to clean the deprecation. Agree to not add queue stats to xstats when driver doesn't have the queue stats at all. >> patch. I just want to cleanup list of drivers which >> require attention/changes. Drivers covered here do not >> provide per-queue stats in basic stats. So, there is no >> point to set the flag to show it in xstats. >> >