From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFD2AA034F; Fri, 8 Oct 2021 09:02:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A52640140; Fri, 8 Oct 2021 09:02:46 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 3AA6540040 for ; Fri, 8 Oct 2021 09:02:43 +0200 (CEST) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HQfCs6Jpwzbn0J; Fri, 8 Oct 2021 14:58:17 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Fri, 8 Oct 2021 15:02:41 +0800 To: Thomas Monjalon CC: , , References: <20210922033630.41130-1-humin29@huawei.com> <2236789.hR5l6LFQDr@thomas> From: "Min Hu (Connor)" Message-ID: Date: Fri, 8 Oct 2021 15:02:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <2236789.hR5l6LFQDr@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thomas, ÔÚ 2021/10/6 3:21, Thomas Monjalon дµÀ: > 22/09/2021 05:36, Min Hu (Connor): >> From: Huisong Li >> >> Use the testpmd to perform the following operations: >> 1) mac_addr add 0 00:18:2D:00:00:90 >> 2) mac_addr add 0 00:18:2D:00:00:91 >> 3) mac_addr add 0 00:18:2D:00:00:92 >> 4) mac_addr set 0 00:18:2D:00:00:91 >> 5) show port 0 macs >> Number of MAC address added: 4 >> 00:18:2D:00:00:91 >> 00:18:2D:00:00:90 >> 00:18:2D:00:00:91 >> 00:18:2D:00:00:92 > > Please describe with words. > Reading similar MAC addresses is not a fun game. I do not catch you, could you please be more detailed, thanks. > >> This is due to the reason that if the address has been added as a >> non-default MAC address by rte_eth_dev_mac_addr_add API, it doesn't remove >> from dev->data->mac_addrs[] when set default MAC address with the same >> address. >> >> Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li >> Signed-off-by: Min Hu (Connor) > > > > . >