From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 012B142D71; Tue, 27 Jun 2023 13:58:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E48C340F18; Tue, 27 Jun 2023 13:58:55 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2083.outbound.protection.outlook.com [40.107.94.83]) by mails.dpdk.org (Postfix) with ESMTP id 8F25240EE1 for ; Tue, 27 Jun 2023 13:58:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JYvSKPIcZNtErVxUYjvbNMaAQ6x6CQXwvfeg5ew1XcULPxptx+0XJr69a9J52txfXWWD75V+R9h/nktRXEF4s7qtfVLrxc6+BVsfYV3QSkbCpe0fK/6RcegabA17ASjwy2n7Omo6BQhI7j/HBoX3mCHKf8z2GTZn+Wod53apajVhEiRbmeLnoI13oeM6QmlVn6fdtTm3/L/DDlVz8+wOxH7G8zqnb7l5+mYBZfJ3Xujc6iXv5GVCt2I5mE8dVSHwwULQHF54fX4IJdvvxkUZVnka+exQjksCD6epfLrzIKzLO+CO9gMpgcafqQ61/hiFcIF6ELqyQZ3zppeFiERdBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=reXTnfLRfoRUw9qCT/rNB2DPKFfJ8NJIdiqgLaF1K78=; b=eUvVLowVp/ZRPLDQjPgkSsJUPIF6oT9gSnMfWug8cu/IEKSI/41sSgxU7OOVLSpCYnjWmLrnrqzHr7BOPJhyQ0hpiqMBt+9MPxx8902VYkEngdrZ7vcg+rUYRxPcFjmdTFw43t3FHi2kOzu91iIE9vIDhBv46mZQA7gf22UJ1oO1zXUBpFLTbHFp6xoEc6wTfohem3tWMawSt0qo3Zd1i3fn6gLqT7cpHfVD+bA1nNlUOsf3jt4Uasm0r76Q0N0Y9AcZiLmaRydJDmQoX5WHRdNXB/vMWnyPJdOdISh+0g0GCKVXNJC6DI12OZTVCHgbveHaJ6nzIfnqTT+9Vm35xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=reXTnfLRfoRUw9qCT/rNB2DPKFfJ8NJIdiqgLaF1K78=; b=qjeFJxWS2tGcTgZHteNfKSESy6bo7fWXDxpK25WrcDB2fx4yYdrcqNOUTzXoJQCLuEnlXQ65olTqTlQHEAw7YFHKMNP1+0NTZOSi98rUXGE4u+GUN9nTiJoLQ5dHY2SNcQGvWPfsSeA62GWEu/aPnCabjwXPNyUZUHhOFaeomg0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA0PR12MB4559.namprd12.prod.outlook.com (2603:10b6:806:9e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 27 Jun 2023 11:58:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.012; Tue, 27 Jun 2023 11:58:52 +0000 Message-ID: Date: Tue, 27 Jun 2023 12:58:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4] app/testpmd: add trace dump command Content-Language: en-US To: Slava Ovsiienko , "dev@dpdk.org" Cc: "jerinj@marvell.com" References: <20230420100803.494-1-viacheslavo@nvidia.com> <20230626115749.8961-1-viacheslavo@nvidia.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0160.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA0PR12MB4559:EE_ X-MS-Office365-Filtering-Correlation-Id: cf14a10a-3cad-4840-570b-08db7705e009 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CX+7TgveSCo9jevMOYZ8+6Aye+t8vyktBwyXztm5VNLYdPYVVR/Dmo1dV7LKJpP3rLAiweh5mCuKjIog1Oi1JQR8NW+lbuwRW6oAXE13IT8Gkx/Ay+B2IuoJvXVgiLc8+4d1ns9ciHwu3ZRBLaKwxOuZk25OmKTkPyIntQJ6KqAUx4MF9GXIe4hyoWPQr+lBDqENynxEdgHTdOpDCsYi/wmBjtPxJMi3MT3nA/lcZIqHt6ZFw7ZylASCaA0AvgI+LZv82TOlyfK/EIUEE2tLouEwoWUPP8NhwYxhgfaBlqCMPROsKJ/qax5WWB5zH50/D9gxGWqFP+C52SkMmhFL2ur2r3BjiUw+hjyyvcJVmODeNOBiCe3bS5ThExICZ3zAtBIQ2rb9sOxtsZ9j74bvSLmhDCAdhb6FXCVKpt+/1xXN1Ek58+GxtBj40bZ3uHgDBplrk8iu6Qsypf+Dh2p4aYA/6Y0hc59IGOT/+7aOczHRc7j29aXAgiuIAtLwX3KG+B4X/HPUFtrvS7R10MZqn2giwiDH7l38XDCJPyYoQm/yyqIIdG7p/SVF524u0QglGFNc26iCdrbBrJV3JriXgPpklJaXKdrYiAPoyaGS8CkLvQpb0DFEtZQK4v6te/kkbuS/m85GVY4zOPj76ZHeTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(451199021)(31686004)(110136005)(966005)(6666004)(478600001)(6486002)(83380400001)(2616005)(31696002)(86362001)(66476007)(6506007)(53546011)(26005)(186003)(66946007)(2906002)(6512007)(66556008)(4326008)(36756003)(8936002)(41300700001)(38100700002)(316002)(44832011)(8676002)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NG9wNld1bmc1UWlvcUxHL3pDOXd3ZE5ta3N5UnZKQ2ZsUzJUTVhaekVhN080?= =?utf-8?B?Qml5TjVWeXJST0NweG5YY0ZDSXhzdEpxVGJ4dlBRVEZwajFoQ2NmWnVCV2Ns?= =?utf-8?B?YjA4MENoZHpLcDRVQ09iYktZUVpFSG9IMXdlWUZnSFlyR3NqeE1UOW5MeTl2?= =?utf-8?B?S0I5eCtFMkpzNURZYjdab3BKRW9vdEZUd3Z4aWFHbnRXazF3MFoyQzd4ay9R?= =?utf-8?B?aFArMlJIVjFKMHJiaDdXRFVUcGdKU2N5bU5mSHp3VWU5LzVncU1oQldseGFL?= =?utf-8?B?Rkw4bjdtaW1GMm5xcWpteml4eTMrMDRoMHJ3aUdwUFc5NXgxYnhJVVBDVmZK?= =?utf-8?B?L0F2QXpqdTJWSFFkd0F4b3YzOFpEK2JMbWFnTW4zejNmZHYxRVBwWG9TU0Fr?= =?utf-8?B?S1lzZjdhNGZyZ2JkV1RWanFsVzFnSTFuanFFVVlsWlNHMmRrei9zZXlvekRL?= =?utf-8?B?N0s4aWRrQjdpNDZycy92NWJSallrYzhmNHprZ2M4RTVPVnhGS213dGlEVmpL?= =?utf-8?B?RkQra05ncDhXeVhlR3JoYk5CV05mNWgyR2xsRTdjVEpBeTN5aGdYSDcyMnNB?= =?utf-8?B?Q05vN3BBa2xNSzd4M2JYMXFGZnBxNjBOaWhubUJTYUZPem8wLzBjSFVKc25z?= =?utf-8?B?UFg5dlNWL1l6ZmNBbHdNY2o1Y3I0TE0zbUE1RmFqVTRtS1Uya2hnazdOVnZp?= =?utf-8?B?KzNOamYrREVVWjQ2WW01NVNKbkJOeHRqY3Z0UXhuS1RYck53YUtFWnRnbUJK?= =?utf-8?B?LzVpeEpPMkpLa3lRbzloTkpYejhyRmZNN3ljZzNtTXExaHhOVnM4M1N4YnA3?= =?utf-8?B?cWtqSUUzVnM1SWQ0aklESUx5WCt0TGtFTDRsektHSWdWa1lPYnVnWU9XUmxW?= =?utf-8?B?Y2hSUWNlVnlBRFpMTC9Dbzlnbnd4Yi9TTWhYb0xQbmFNOUdJeHdsN091Q3dt?= =?utf-8?B?alo0Q2hHRlBWZHNJQ2YyVjlreUxpZUdjS2ZMNytzSTY0NE42d3JWQUljeWI3?= =?utf-8?B?ZFhqTTVuOFYxcCtSVndDdXpSREdwU0wwSjdnU1lqZXFGeFNtdytOMW1YVzRM?= =?utf-8?B?SUpYb1k0ZkxJUUlZYmFLcXFSNkh5YVQ0SjJQa0V3QWxYRDhucjBQaXlqOGJy?= =?utf-8?B?Y0JZS3gwQ0lhK3ZJTDNJSmJiY2lXajFreVUwUUwyenMwdWZtT0hqUGtJSGFh?= =?utf-8?B?ZVdVbXhPQnZISURDZ2sxcHFPUDR4MitVNHYySjlMZWJxU0FjK0NzUVdFdGJ5?= =?utf-8?B?R2p0VUQzbEMwNDdDbTJ5bm9TYzliVlY4dHFVaDk0UXB6U3dLRk5vSkd5em1Y?= =?utf-8?B?OE56bW1iL0p0VGtEWDNyazBjb2hDa3l2REEyNUcybW1sK0VNSEJkTUdKM3pK?= =?utf-8?B?SHJnK1FTQUxQSVVGM2FYeldKUzNBdUY1Z2lwbFdYV3JHa1V6TmVzVkxFMmFa?= =?utf-8?B?bGFWRFJQZEI0bldPam93UWF2S0sxOUNmeUxJVThCZUk2WXhwZDk4QWRPOVA4?= =?utf-8?B?MXdld2ZFclQ4Zy94b0Rmd1RIZnZwb3ltUFNGVEg4Q1l4VktVZlY3T2xzVGdz?= =?utf-8?B?NVdnVU1tVWkzOWg3MjY0YmdBcSswVlk2anlQejdsVnlmZVBOdlBUQmRxWW01?= =?utf-8?B?ZnE4RzBiZE82THc5RnRvRWxSb0ROVE5TMXJJT0RGanRmUzdUaVUzT280Q0hV?= =?utf-8?B?VjJINS9zcG9HdFV5YU1UR243d2xGWjBrS2JPUk5TZ1QwaVdIV0VKSUIwSUpB?= =?utf-8?B?RlcrRDEzZGJ3enRuRDRTYUlqTnFEbkI0S1h2Tys3MXhLamlGTzRHMjl5eHEv?= =?utf-8?B?RERUWmpXczNiVElsbWpUSCtvRG0rMS8rVnU2eHlUYjNWK0huU016bXdDUCtC?= =?utf-8?B?Uis4cXp0MTQwUHFxTXdRQXpHTlI4bE4rV0ZoMGs0cVNOUXlsMmhSaytaU2Vu?= =?utf-8?B?MEZwdk5pWU1IZmpiM3k1MVBHWlNoL0tGV3plcEJ0RW9MZE1UMGJsUU8vUE8x?= =?utf-8?B?L1pFbEtkcVhuWFNaWldVYk9Kd0FGaUxMYUZEV1FXRndCMW9PZjI5eWpOWWp6?= =?utf-8?B?Q1gzU1N3dERBRjRtdVVUb0RxNHVZMkt1Y1llU1lNQzNKQWlzTDZuWGFwSE5u?= =?utf-8?Q?73ALhEScc60I0Umg1MAffXyH7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf14a10a-3cad-4840-570b-08db7705e009 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 11:58:52.2453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sG06ObyU1A4SXy41Jp7CP/Y7UbcG1VJ3Gb1w50fTc2Ol+s2foOah4C/yXZp1WbfP X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4559 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/27/2023 12:39 PM, Slava Ovsiienko wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, June 27, 2023 2:35 PM >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: jerinj@marvell.com >> Subject: Re: [PATCH v4] app/testpmd: add trace dump command >> >> On 6/26/2023 12:57 PM, Viacheslav Ovsiienko wrote: >>> The "dump_trace" CLI command is added to trigger saving the trace >>> dumps to the trace directory. >>> >>> The tracing data are saved according to the EAL configuration >>> (explicit --trace-dir EAL command line parameter alters the target >>> folder to save). The result dump folder gets the name like >>> rte-YYYY-MM-DD-xx-HH-MM-SS format. >>> >>> This command is useful to get the trace date without exiting testpmd >>> application and to get the multiple dumps to observe the situation in >>> dynamics. >>> >>> Signed-off-by: Viacheslav Ovsiienko >>> >> >> Acked-by: Ferruh Yigit >> >>> -- >>> >>> v1: >>> https://inbox.dpdk.org/dev/20230609152847.32496-2-viacheslavo@nvidia.c >>> om >>> v2: https://inbox.dpdk.org/dev/20230613165845.19109-2- >> viacheslavo@nvidia.com >>> - changed to save_trace command >>> - Windows compilation check added >>> >>> v3: https://inbox.dpdk.org/dev/20230626110734.14126-1- >> viacheslavo@nvidia.com >>> - reverted to "dump_trace" command >>> >>> v4: - added missed header file include >>> - missed #ifdef added for Windows compilation (no trace support >>> for Windows) >>> --- >>> app/test-pmd/cmdline.c | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >> >> Can you please update 'doc/guides/testpmd_app_ug/testpmd_funcs.rst' for >> new command? > Sure. > >> >> It looks like dump_* commands missed in the help output, >> 'cmd_help_long_parsed()', can you please append this new one end of >> "display" section, we can complete the missing ones later? >> >> <...> >> >>> @@ -8371,10 +8372,17 @@ static void cmd_dump_parsed(void >> *parsed_result, >>> rte_lcore_dump(stdout); >>> else if (!strcmp(res->dump, "dump_log_types")) >>> rte_log_dump(stdout); >>> +#ifndef RTE_EXEC_ENV_WINDOWS >>> + else if (!strcmp(res->dump, "dump_trace")) >>> + rte_trace_save(); >>> +#endif >>> } >>> >>> static cmdline_parse_token_string_t cmd_dump_dump = >>> TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump, >>> +#ifndef RTE_EXEC_ENV_WINDOWS >>> + "dump_trace#" >>> +#endif >>> >> >> Why not add "dump_trace#" as last item, to keep same order with >> 'cmd_dump_parsed()'? > > This would require modify the preceding command undef #ifndef and #else: > #ifndef RTE_EXEC_ENV_WINDOWS > "dump_log_types# > "dump_trace"); > #else > "dump_log_types"); > #endif > > If you think order is more important - please, let me know, I'll update > Lets move it just before 'dump_log_types', in both instance :)