From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 907FBE5D
 for <dev@dpdk.org>; Tue,  5 Dec 2017 01:48:55 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 04 Dec 2017 16:48:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,362,1508828400"; 
   d="scan'208";a="9075503"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.178])
 ([10.241.225.178])
 by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2017 16:48:53 -0800
To: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org
Cc: mw@semihalf.com, jck@semihalf.com, dima@marvell.com,
 nsamsono@marvell.com, jianbo.liu@arm.com
References: <1512048743-23749-1-git-send-email-tdu@semihalf.com>
 <1512141592-16695-1-git-send-email-tdu@semihalf.com>
 <1512141592-16695-7-git-send-email-tdu@semihalf.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <d87cabec-bec6-09df-f5ef-03cdd6c4ed4e@intel.com>
Date: Mon, 4 Dec 2017 16:48:51 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1512141592-16695-7-git-send-email-tdu@semihalf.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 6/7] devtools/test-build: add MRVL NET PMD to
 test-build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Dec 2017 00:48:57 -0000

On 12/1/2017 7:19 AM, Tomasz Duszynski wrote:
> Add MRVL NET PMD to test build tool.
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
>  devtools/test-build.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 092d3a7..78609c9 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -197,6 +197,7 @@ config () # <directory> <target> <options>
>  		sed -ri           's,(SCHED_.*=)n,\1y,' $1/.config
>  		test -z "$LIBMUSDK_PATH" || \
>  		sed -ri    's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
> +		sed -ri           's,(MRVL_PMD=)n,\1y,' $1/.config

Won't MRVL_PMD also require LIBMUSDK_PATH?
For this case check doesn't cover it and will be enabled always.

>  		build_config_hook $1 $2 $3
>  
>  		# Explicit enabler/disabler (uppercase)
>