From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id B93D31B1CC for ; Tue, 9 Jan 2018 17:30:45 +0100 (CET) Received: by mail-pf0-f195.google.com with SMTP id d23so8901346pfe.9 for ; Tue, 09 Jan 2018 08:30:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VBvYd3aTVJYpTnaa3qLCMvZ30KjWdlryV0dSbRB0ZoM=; b=XWQWGkpPOsytr92FLQUSyKBoZxDM4cvActRnaxQezC+BgJFJ8s8nYy+S4ygJMLMy1I gJkPe0V548eGp1QYozrVihfwOA70wjIwi3+XKA75Zd0a9NnDlhWJL7jq3XGPURMbu+hd UJR6/08AQluPHl98OvaQ6Awjd502AmICV96wPl/7kJGGt7j8Zk1ImOqPFmdNL/Poyb5d D/pwDPiqYkvUfF/0BPnqJyu596fIWsXJQsCz/p4+jYjSDDZSPUWAAqlvOEbNGJir6i1M fr5Wa4xUy86IwFmj3qPMcvrtv370z4oy2k7qsspUIVAZhnxB5xcdmEW42ejF3pTDHl9d wxYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VBvYd3aTVJYpTnaa3qLCMvZ30KjWdlryV0dSbRB0ZoM=; b=q4h5YbS2T10ExfQepSqgdpGtO9VpxDRWNyas2NbyKvvwGVsPl9+QnsR1gNmfuWAXcT oFtvJVNbrZVyXqAlr4cw4EZ6EMMDathUIJB2s70ZuI9mGjgNoZ1x3RDTolGVp7P8wkSm jmXIwZqHiKLtOXcRyi7e3/odLTm6d5pxTDWSkAKBlkoTZxnKr6pZVGkUKirrKRlqJ6vP Lq7+64zUibEVjxojaw1E5SFghgGBqgjv8R3R/3aqqDGBPCCxn2qyk0rlkPxRUa3fDzL7 0a9vj/AgBrK20V+O6pLKaFoGQ+CZKuJvuYohElf+2dupBm/vGZokFQRZ2lhJG5Fdru2b XLwA== X-Gm-Message-State: AKwxytdjYkE7Tkjb5+ndBEvipyhQsHhLnaMMhegaHQxd7dVtrymE/n0c ESw29ryj3+nkyd9RdwoxZE7eRUMq X-Google-Smtp-Source: ACJfBouJ6rG0FCle8G/ndwv+6P4MRaX9BrTC7MBQfG/D411u14PQMu3675mV07j62CMilwmsU7tu/g== X-Received: by 10.99.2.136 with SMTP id 130mr1357549pgc.268.1515515444865; Tue, 09 Jan 2018 08:30:44 -0800 (PST) Received: from [192.168.86.222] ([75.106.27.153]) by smtp.gmail.com with ESMTPSA id w21sm31448091pfl.50.2018.01.09.08.30.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jan 2018 08:30:44 -0800 (PST) To: Bruce Richardson , qi.z.zhang@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, helin.zhang@intel.com, ferruh.yigit@intel.com References: <20171123165314.168786-1-bruce.richardson@intel.com> <20180109143254.234428-1-bruce.richardson@intel.com> From: John Fastabend Message-ID: Date: Tue, 9 Jan 2018 08:30:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180109143254.234428-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/2] AVX2 Vectorized Rx/Tx functions for i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 16:30:46 -0000 On 01/09/2018 06:32 AM, Bruce Richardson wrote: > This patch adds an AVX2 vectorized path to the i40e driver, based on the > existing SSE4.2 version. Using AVX2 instructions gives better performance > than the SSE version, though the percentage increase depends on the exact > settings used. For example: > Hi Bruce, Just curious, can you provide some hints on percent increase in at least some representative cases? I'm just trying to get a sense of if this is %5, 10%, 20%, more... I know mileage will vary depending on system, setup, configuration, etc. Thanks, John > * Using 16B rather than 32B descriptors gives the biggest benefit since > 2 descriptors at a time can be read, rather than just 1 when 32B ones > are used. > * Bigger burst sizes for RX gives improved performance - while we see an > improvement with testpmd with the default burst size of 32, burst sizes > of up to 128 give further improvements > * In my testing, most of the improvement comes from faster processing on > the RX path, though the improved TX also gives benefit. > > This has been tested on a system with CPU: "Intel(R) Xeon(R) Gold 6154 CPU > @ 3.00GHz", and I've focused on testing with Rx ring sizes of approx 1k - > generally --rxd=1024 and --txd=512, rather than the defaults which tend to > give poorer zero-loss performance due to the smaller amount of buffering. > > V2: > * Fixed incorrect config variable reference in makefile > * Added missing stub function for when vector drivers are disabled > * Added missing references to the new functions when checking for vector > code paths, e.g. for ring tear-down > > Bruce Richardson (2): > net/i40e: add AVX2 Tx function > net/i40e: add AVX2 Rx function > > drivers/net/i40e/Makefile | 19 + > drivers/net/i40e/i40e_rxtx.c | 66 ++- > drivers/net/i40e/i40e_rxtx.h | 6 + > drivers/net/i40e/i40e_rxtx_vec_avx2.c | 792 ++++++++++++++++++++++++++++++++++ > 4 files changed, 880 insertions(+), 3 deletions(-) > create mode 100644 drivers/net/i40e/i40e_rxtx_vec_avx2.c >