From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F12141D9F; Tue, 28 Feb 2023 19:51:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0298E41181; Tue, 28 Feb 2023 19:51:27 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2070.outbound.protection.outlook.com [40.107.244.70]) by mails.dpdk.org (Postfix) with ESMTP id D99F44021F; Tue, 28 Feb 2023 19:51:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aGMFHFwaIOuKc+yAHgnhFR6afCOz3h6EItaKr539SLLTr1/AyRIAHobBTWXDMdFt70OzrUB3wOCx7ReBsqXbjTlt9yImwDjGxGQexIVtONXn6hZ8K0ZE4dMpaLfMIOfACRIVCKN0A7xREFdLUxxewTvhP1GGl/ndeYxE2mssWsRcqOYQCOPTBrH7WZ/6YGYRm7ANEnq3pj4Io+dCbB6z+g+hmuKBbEYDLYEVst0eQL8Zu7TBrqfn7u4kHFTcFUQF+GnnLysvW04sL0sXkpxAOA89+sA+cJ87x/XBKM6ztf13H7e5+t7d1uY0g8WGNfWTef/Boo3+ZqaNGVJ6vRox5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pr4k9iaMgVxbNVJF00o0aRgFT8CuN8fvml5yDI6ZrsA=; b=UgzMMRKtm9nMtG4nVUfvFdb7mt8on0/dp4wmRmA49ZroTkLLun2XHD9hfnHZI2CCXJGaoRzKpAktQLL/OaYorfinybeg/0RJYiIbM8ZdUAeumfhYR4WcULHNJn/UhwAaxH/qCtpsVREdoVRBnklCseqTLYxHhm3xyyrglAQXsrjNLbed/KHzyOG1bp7BClXl6i60mUhWxRhBciT4UxoBQdENjij8+xOvRSwe8rZCgtkCg7rovuhQ7QKxjpZFvMr1rWtVpIVMphaSdTsa3ppPhYbTxHyjK6Nqk7pSInj6eNckBiJVe/gsLk9DkNfpTiFfr1KMd3+n8n/6NJdrs/H7Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pr4k9iaMgVxbNVJF00o0aRgFT8CuN8fvml5yDI6ZrsA=; b=Ja6ACsn/IH+Omo9iXAT+sG05pANg0d36h8hs7HfUBE25CVXnZKKQ30fqpyv0IWfg4jOKmrfvLXYz+YvwniK0wU6HIxXH6HC6gbmtT6363ra939JDsSz11JrrIra1Tpa609vv/4Q1CwqiWx1YYs7PZ228l+sGJLuleReN5cbSLWM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by CH0PR12MB5252.namprd12.prod.outlook.com (2603:10b6:610:d3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 18:51:23 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7%9]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 18:51:23 +0000 Message-ID: Date: Tue, 28 Feb 2023 18:51:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 4/9] app/testpmd: fix packet transmission in noisy VNF engine Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: Aman Singh , Yuying Zhang , Robin Jarry , stable@dpdk.org, Kevin Traynor , Bernard Iremonger , Jens Freimann References: <20230124104742.1265439-1-david.marchand@redhat.com> <20230220183502.3348368-1-david.marchand@redhat.com> <20230220183502.3348368-5-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20230220183502.3348368-5-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0068.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::19) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|CH0PR12MB5252:EE_ X-MS-Office365-Filtering-Correlation-Id: 0661da47-d6c0-45b0-e45f-08db19bcc96b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PrhlT2FfiFwVO04EL8Jxi/l9ZCAIvXBx5s7ETt67aIBJlcbsfLUZgXH5mkpDj5oR489lIA6JOPxnYM4FsYxiaDx1AaTjyGWCagcnno9dcDbBrSNkT8XNoP/T6+0g8gkCPov7YBd4lDIFZus++iuqZKFQVpBF1IgTiuQsfJi1KeKRp8tAQkIO5vzGftLvo7K/GGEDMloywlrtEiBcKhnshWvhYgYHvbkwcj+6CsqXmtZ8cRXT2RI1yGeBdXAKfbiEFJTywcz3VERSQjy/y9D6TwbNRmw85KcEZiMW7/6J3Cg2sXzN/wlAq69/NeKkAWh/33cQVnzgMHRk1gDtN/WMAjRdKwGyEQD47Immqn8rkLaeLQK47DYEd4ezyVUzSPUiLeRVjwJTGTKbGR8ddhgjZaletRiCIiuNAIJMBbG8q8DRdEk1nwZEYc/JIZWAZJMvGM5CmdjPA1PZVbqnbhc+q7b2ftjTvIjxWhbkUrWXb6dTt3xCGyJGk+1c3Pd6uZww06RE9cgS+Nao7RyAG3s22EBGQfDgfwS3YZL0ztyPewPfQ2Iw2LqmU4+bW8Bz/ryXAj7Atq8f8cCJfRQa4F37dXW4ESVHhrKVIJcRy2kt5W+dRH1uDfhUBSkqVsGdIS0vTETidpBYfB2Y/I3ngN55NEw9WzejJfgGTEl6EzuzqmDt2ag9yxWLtUyQWNWXeyM1tzcLDY3KwGinueyxWXhB6N8BkihgCsKilxhFf4T9n3g= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(376002)(136003)(346002)(366004)(396003)(451199018)(31686004)(36756003)(86362001)(31696002)(66476007)(66946007)(8676002)(66556008)(5660300002)(4326008)(41300700001)(8936002)(2906002)(44832011)(4744005)(38100700002)(6666004)(6486002)(478600001)(54906003)(316002)(26005)(2616005)(186003)(6512007)(53546011)(6506007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N25JVUU0QkVXYTYvdC9jbEM3TWp6UlNqbnBTZDlhUElIV2FZRXRXQzFWMmJ2?= =?utf-8?B?STBrTzNucGlYSklHV1QzMHlCb3QxQmRPWUxEY2lVa0ZGcnFUV29FWGdybFQ3?= =?utf-8?B?ZHd3YmRDNm1HT09PNk1KaGt3VFExSTZ2Q2lWc0FwMTI4Tit2eG9SS0FhR0tS?= =?utf-8?B?Z1Q0Q2JVZ1pOUHhJZFgweHdRdzQ0R0tqRCs3VWhVWnYrYW0yelhDVEREV294?= =?utf-8?B?OGdlSW5VWkwxQVZRR2ZCYkVIZGN2SkR4cHUwK0gvWXRYUmw0c2t5R1NpSmEy?= =?utf-8?B?V3V6NitPbG0vMk45QXF1L1UyMVBLRGpNZVp6Vk9RWno4bXpXTlExQktyRzBw?= =?utf-8?B?dm1DOHBSdlpHQmJCV0JzaWJ6dnRlOHJLS2gzeHJsa21sRmhnWHBMTTNEV05m?= =?utf-8?B?aHJudmJpcWZteVdGaXB4ZzdQVXZNUUxUcGJiNEhCS1JlMjJTUnhsbXZhWXo3?= =?utf-8?B?K3dYdkJocDZwa2pmcE1xRkZ0TEhTMlpYdEpIQmg3cmVwQjNPTDV3TGI3K3ZT?= =?utf-8?B?NytxTDVtb2dkK2JYY3dqaFJvZnRHTVVJOE9CUURVVEtLTGtTQk8xMEN0K0Iy?= =?utf-8?B?Z2dUcjlNbEd6TEd6N1B5VHo0bXpLejJESFhhTFJEb0tyVXFLRlNKbmRmWUFH?= =?utf-8?B?SS8rQmwvSFQvbDVDUDFpYkJWWWREVWlhbTJNZlBLVis1TzN5dXBYc3gvU2Na?= =?utf-8?B?WklJTXRnOUZhMDBQNlVnRXFrSkdrcGdNaWphbS9sOURTeC9wcC9hcEZuZ1h2?= =?utf-8?B?V25LZkdrRW1vTUIxTmdFT2FHcU1TenNJbXlNSnZISmx5VkFSZXhJdTVxQ3Rw?= =?utf-8?B?RFc2REVlOVBYVnRnRXRqbklyVERMV3FVOVNQYkY1QmpsREJDVVgxSFJPcUpz?= =?utf-8?B?UG8zei9Tb05Xa3pldGdzWTc0OUFMRis0SmV5YXZFZUJWRys3bm9CbG1XeWM3?= =?utf-8?B?WEFXczJGTWs3ZVhzdTFTTzBXUGo5LzVSWktPM1Q2T0llRVVtamtXcFY3ajhC?= =?utf-8?B?TmZjYldWcjcrNHMwL2FxZ3R6S0wyZnFwc2JyVGYrYk01U090VWdTNWRWaEN5?= =?utf-8?B?VUh0V3RYU1pkQ1BaN2t4Q0swaGRjQnVTV2t6ZWtUSnJKV21DSFRaYnVWa0JC?= =?utf-8?B?WTRjODgvZFhpdjd4WHNBWDhRaXN3VmJyMGRvaFFTVW1va2EvdXp4dXRlY2JO?= =?utf-8?B?bWxad3VhUDQ4ODRSekhWbXkyQkhMbTVBelV6cjJuRHdRd3M1c1lNRXNyOHBL?= =?utf-8?B?cTBac2Z3Z2ZpR2thS254Y0NGSjM3TkoxWGlONFM4Ukg1dGc1WnlScHlHWWVu?= =?utf-8?B?a0hxTmJNR21ZaDVZaWZIMDRidUhrTUIxWDVnMFlMeVBjWWd4SGFKeWsrR05k?= =?utf-8?B?YWFRZU5GWVRyQUlmNlZ0V1FhZ0FXY05jUjIyRVlVdm5XL1Vpb2VTR0QwUXhK?= =?utf-8?B?YzUzZjBrVm5raVM3aDB3MUxqa0JLamYxUFVNeXJPVzhjQTFnVmNsSWtzQVBX?= =?utf-8?B?bDRGLytBTDFPQ2lLNHZCY255K3dDRUxOSXVpZ1BUNFZxSWVRdzEwYlRkNXEv?= =?utf-8?B?YVVVNW5sUzh4Nlk0MEFTaGhGYlFHZGJGYkNWRnRyTEwxdGtyOWFNTDlXUmhJ?= =?utf-8?B?NjBtRWZqMDJZS1RQYTZxOWxmNWFDSmlnbUZ1dXRsc1RiMUpCSW5tRll4dDFq?= =?utf-8?B?REU0cWxTbEdNZ0J3NTVXSm1wNmorTStwYVp1dnNjVG5lYUw5YTg3eFFjR2NP?= =?utf-8?B?T2xQcThSRjI4WEZySldUQ0c2Uy9hOTNOQng1d1l2NXhVUmtjRFVQYk5DY3hU?= =?utf-8?B?TmRuZ3ZuaGpiUkl3S3JDVkYrWG1GM0UzeTc2RkJDWDgramxkS3NQbENmNnFE?= =?utf-8?B?QWxMSk5OOUhKMTRUU2didkRrMFcyaEcvWjNySVRkZC9jQXRKRUMxUGJvbGND?= =?utf-8?B?Q2tqVEZzNXlFanFQdHlYY2xuTHZVa1hUTFV1TE96V1UwWTE1MzhLTW1sa1JQ?= =?utf-8?B?MHlmWW4vQUs0akIzWU5vTDVkSXp6QndOQnNVWFVYenpaWmpCMGUrOXZSaXBJ?= =?utf-8?B?MkRlZGxYaHZ1c0ZrejlKMEphaExXZCt0VTRGbG9Gbm1hMGt4dk5pWlpSSG00?= =?utf-8?Q?A3+OpPmkyDESyHXI2iJYJMTR2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0661da47-d6c0-45b0-e45f-08db19bcc96b X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 18:51:22.8768 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pnXNMHxz1KwJxF9N94v8Mae6pPIPN3D2OWl6AKRxdlLmTCItrQyBN73eCJYwTpwf X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5252 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/20/2023 6:34 PM, David Marchand wrote: > nb_rx relates to the number of packets received from the driver. > nb_tx is the total number of packets transmitted by this forward engine. > > Fix the retry stage, for dequeued packets, as it was incorrectly > passing nb_rx / nb_tx as bounds of the tmp_pkts[] array, and fix tx stats > accordingly. > > Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit