From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4505A04B5; Tue, 27 Oct 2020 12:39:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D4902BAA; Tue, 27 Oct 2020 12:39:26 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 586892B9D for ; Tue, 27 Oct 2020 12:39:24 +0100 (CET) IronPort-SDR: eJWi+B9abQGowaXB+xJOy3sBEv2Yjrxk9IjtefZaH1F17x8Y8443/RyapKBq6ccbKQ8acX9GKl vydhxUwuTXxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="185805286" X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="185805286" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 04:39:22 -0700 IronPort-SDR: KwXa7HiuGX8pfLKSeQKWAzprnDLrgoHEwyRYzJKsXUTuSjF/ajil2seoCZom3gh6HUCEF1By/X kAMpdpAk6QWA== X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="468264745" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.87.204]) ([10.251.87.204]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 04:39:21 -0700 To: Ali Alnubani , Andrew Rybchenko , "dev@dpdk.org" Cc: Ivan Malov , David Marchand References: <1603183709-23420-1-git-send-email-arybchenko@solarflare.com> <1603185222-14831-1-git-send-email-arybchenko@solarflare.com> <1603185222-14831-15-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Tue, 27 Oct 2020 11:39:19 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 14/62] common/sfc_efx/base: add action set spec init/fini APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/2020 9:13 AM, Ali Alnubani wrote: > Hi, > Sent my report to v1 the first time by mistake. > >> -----Original Message----- >> From: dev On Behalf Of Andrew Rybchenko >> Sent: Tuesday, October 20, 2020 12:13 PM >> To: dev@dpdk.org >> Cc: Ivan Malov >> Subject: [dpdk-dev] [PATCH v2 14/62] common/sfc_efx/base: add action set >> spec init/fini APIs >> >> From: Ivan Malov >> >> The engine is only able to carry out chosen actions on matching packets in a >> strict order. No MCDI exists to identify supported actions and the order. >> Still, the definition of the latter is available from the FW documentation. >> >> The general idea is to define an action specification structure and supply a >> client driver with APIs for adding actions individually, order-dependent. >> A client driver is supposed to invoke an API on every action passed by the >> application, and if an out-of-order action follows, the API will reject it. >> >> Add an action set specification stub and supply initialise / finalise APIs. >> >> Signed-off-by: Ivan Malov >> Signed-off-by: Andrew Rybchenko >> Reviewed-by: Andy Moreton >> --- > > This patch is causing the following build failure on CentOS 7 with clang 3.4.2: > > """ > In file included from drivers/common/sfc_efx/base/efx_crc32.c:8: > drivers/common/sfc_efx/base/efx_impl.h:1703:3: error: redefinition of typedef 'efx_mae_actions_t' is a C11 feature [-Werror,-Wtypedef-redefinition] } efx_mae_actions_t; > drivers/common/sfc_efx/base/efx.h:4101:34: note: previous definition is here typedef struct efx_mae_actions_s efx_mae_actions_t; > """ > Hi Andrew, Are you working on this?