From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 158E4A056D; Mon, 21 Nov 2022 22:27:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC74542D29; Mon, 21 Nov 2022 22:27:17 +0100 (CET) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 35C4740DF6 for ; Mon, 21 Nov 2022 22:27:15 +0100 (CET) Received: from frapeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4NGL4p3S6cz67H19; Tue, 22 Nov 2022 05:24:42 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml500005.china.huawei.com (7.182.85.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 22:27:14 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2375.031; Mon, 21 Nov 2022 22:27:14 +0100 From: Konstantin Ananyev To: Tyler Retzlaff , Bruce Richardson CC: "dev@dpdk.org" Subject: RE: [PATCH] ring: build with global includes Thread-Topic: [PATCH] ring: build with global includes Thread-Index: AQHY+6SudIIgfohD9U6UX4OiuBnShK5JIMeAgACdA4CAACnCEA== Date: Mon, 21 Nov 2022 21:27:14 +0000 Message-ID: References: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com> <20221121195327.GA24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20221121195327.GA24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.138.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Tyler Retzlaff > Sent: Monday, November 21, 2022 7:53 PM > To: Bruce Richardson > Cc: dev@dpdk.org > Subject: Re: [PATCH] ring: build with global includes >=20 > On Mon, Nov 21, 2022 at 10:31:29AM +0000, Bruce Richardson wrote: > > On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote: > > > ring has no dependencies and should be able to be built standalone bu= t > > > cannot be since it cannot find rte_config.h. this change directs meso= n > > > to include global_inc paths just like is done with other libraries > > > e.g. telemetry. > > > > > > Tyler Retzlaff (1): > > > ring: build with global includes > > > > > > lib/ring/meson.build | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > > I am a little confused by this change - how do you mean built-standalon= e? > > The ring library depends upon EAL for memory management, does it not? A= lso, > > no DPDK library can be built on its own without the rest of the top-lev= el > > build infrastructure, which will ensure that the global-include folders= are > > on the include path? > > > > In terms of other libs, e.g. telemetry, the only reason those need the > > global includes added to their include path explicitly is because those= are > > built ahead of EAL. Anything that depends on EAL - including ring - wil= l > > have the global includes available. >=20 > i'm having trouble seeing where in the meson.build that ring depends on > eal can you point me to where it is? >=20 > > > > Can you explain a little more about the use-case you are looking at her= e, > > and how you are attempting to build ring? >=20 > so i found this by trying to understand other libraries dependencies > through a process of disabling the build of various subsets. >=20 > it's possible i didn't look deeply enough but i didn't see an explicit > dependency on eal (in the meson.build files). maybe you can point out > where it is because by just having rte_config.h available it compiles > and links. >=20 > e.g. i don't see. >=20 > deps +=3D ['eal'] >=20 > is the dependency on eal the library or just eal headers? because if it > is header only it is equivalent to telemetry i think? rte_ring.c uses bunch of EAL functions: rte_zmalloc, rte_memzone_*, rte_log*, rte_mcfg*, etc. =20 > thanks! >=20 > ty >=20 > > > > /Bruce