From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1492342E98; Mon, 17 Jul 2023 10:27:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A1E942D0D; Mon, 17 Jul 2023 10:27:31 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 54C294068E; Mon, 17 Jul 2023 10:27:30 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.87.158]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 096CE50; Mon, 17 Jul 2023 11:27:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 096CE50 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1689582449; bh=jjKs1+s4XJr43eVW81slOIMnNimpkEgC7OhExosuE/o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KEuv2QP+4TMTN2YXen/rUIjio9V5/K1HZAfWk2y87/WgS5w8UCsbeS8vPLtkN8c7X iacJgViZfokOZuxjztbAkaGvwTW+bqdb1shmGFKHcF/8Y+7qYlylbGtNV0H/kSawru FQYayrXLJ2ysrgH8pKDsg63KFzk2dgc3heomLXEw= Message-ID: Date: Mon, 17 Jul 2023 11:27:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/1] net/sfc: add explicit fail path for unknown tunnel flow type To: Ivan Malov , dev@dpdk.org Cc: Ferruh Yigit , stable@dpdk.org References: <20230714124102.6546-1-ivan.malov@arknetworks.am> Content-Language: en-US From: Andrew Rybchenko In-Reply-To: <20230714124102.6546-1-ivan.malov@arknetworks.am> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/14/23 15:41, Ivan Malov wrote: > The driver supports flow tunnel offload. When the parsed rule > type is unknown, which must not happen, the driver does not > properly indicate the failure in non-debug builds. That > presumably makes Coverity report possible NULL pointer > dereference in regard with uninitialised HW match > specification (which gets properly initialised > when the rule type check is successful). > > In order to fix this, replace the debug > assert with a proper runtime fail path. > > Coverity issue: 393675 > Fixes: 73e01736868b ("net/sfc: turn MAE flow action rules into shareable resources") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko