From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07D02431FC; Wed, 25 Oct 2023 18:10:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAECD40DCB; Wed, 25 Oct 2023 18:10:00 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2047.outbound.protection.outlook.com [40.107.223.47]) by mails.dpdk.org (Postfix) with ESMTP id E14D8402B3 for ; Wed, 25 Oct 2023 18:09:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jslOQUWIgn2/0GdTRad8yNvklts/g3KslCk5cZQJLARg3cgINcvDLX+MR5Rf85GzClNvNzcQuk4Zx4y//eRUsOGj36+xJqHKeY/ZS0SP92oFF+9Y7GYdeNY6cnvwLM77DlPDdpfjft1T/g3WFDdZNO4x7tCSOi5RQ+kK6JEapPmbP2VNaRBCg2voXlIWqFQ+Qxx/vuqFIBX4i0IdTBbmcaR/ohY/NVKS2rb81dCfEFSkhbHS0qpnyG/4HnDTHKlE7SB+r2iuIDUPHJu5iTbgXOcHNsqypymDKbRQA3UAT/yW16UL56oeVKT3X2oAASqMS6UZW48BzStHY38FXhWAIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3OdhmAj7yJaM79munN3GwtXP6CbfTY868cxKwW2n/6c=; b=g5Owek6C6jd7VHxz8NvYvQWEMpI+NsjPb8fJ0ODW+s6j/P5QdoKldBMtOaIoZ59s6rJZEMlhks5W45gJih/fXzNNb9fU2vWyseBvUeC6p7ABpCmP8mLc1Xip6tWiud9HOmJEq+438pqKqrw4ygw0xmxM16q5Dm+i3X4UAn+ut+QRPW9sDiFOKq91ToG4P7DWK2d7zX1OJM53QvTcUFVwYTdQeF8U2XuvgWpFH+A2exU3jrqZLJxJxgKi4DHkBdQEhiIgKuF9MsEMdpL+/Fl09HSlNyy45rqCZAupJos1wKUPbALT3ku5axjor0yRYf3VWlrTmXFGVDUcnfTpo2oJgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3OdhmAj7yJaM79munN3GwtXP6CbfTY868cxKwW2n/6c=; b=WroFKml0G/WRH+dyeoXOcWdwZfVuq05z3oCzANDOyRNSaYZhHgkDFYDKMxfExLPBg3pq+HKU002RvJWcOJ5iMa03nkelxVTItpBnNwytIRkSg0bFqeA1d2T+tG8hY4fT5Z/pGgym6bYxhxbG0HhVOndmdDfNoMwquqzDSxkNtpk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB6709.namprd12.prod.outlook.com (2603:10b6:a03:44a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Wed, 25 Oct 2023 16:09:57 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6933.019; Wed, 25 Oct 2023 16:09:57 +0000 Message-ID: Date: Wed, 25 Oct 2023 17:09:56 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 18/25] drivers/vdpa: introduce the NFP vDPA library Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Shujing Dong , Long Wu , Peng Zhang References: <20231017054545.1692509-1-chaoyong.he@corigine.com> <20231024022849.3092506-1-chaoyong.he@corigine.com> <20231024022849.3092506-19-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231024022849.3092506-19-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0190.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB6709:EE_ X-MS-Office365-Filtering-Correlation-Id: 9abad8d9-eea4-476b-a6c2-08dbd574d541 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S2ZeTPr665BLf/CpjGKFQfCx/dneMWvRPCt4ZUk0TnhcjYCUM/xRYeSKhoXjNx67BIQAKSBkzRAAmI0D3ke9Hg6XeOy+uBDfvMpa3ORMWzUo7GxGI/ONHF6Od/c6B4lD57UAwxPPRyf6zErmIHE8mRQJT1w5OaDBZKuSJhzxAaCf3ju9g6MPg0cMA1pdSHZMmE9OMdwAAF6XpkXNsTTKNXrflbNKN59yCRxHHkBbLUgiwaFiiVKxYlzOblLHDHNFow5wKM+umdtLirhxl0MTIzgMvgxVjMlqscX9kMi7bOdnF7cW0TeB5SvHl6VgwnV6SB3JuT2Ee2OSbmc9O1V/MCVJcaHA6mWRdwvs8i24IxqWsv3Y/D2wj+Gm+tYk0afVhHceF9GFS5wufQIMXI6T6mYaktfX/gjrGX4pTsLJkHBMDNw4DLNLzA66M7UFo9y4IiKWfRdNwLdTmkImBnYQo09s7RIqGsSzynuZUAlqViuB2+d7ldRRNoBl1wQmUUtY0axhg49zIdMCVKgcxiG0MC1BjQPNT+yJ+1UEN8s56mJv+RXbtPbbpRXiVLiQCJ+FhRB51dWlzac9Wtk/AVFj5nmlQIcsO7BOnxfL/tflSsrDroK7TCaXAcQAaIAmdb4nY+92QM+8bIt1avv6OBQJ1A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(39860400002)(136003)(376002)(346002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(2906002)(66556008)(54906003)(41300700001)(316002)(31696002)(66476007)(66946007)(478600001)(6506007)(6486002)(6512007)(53546011)(38100700002)(83380400001)(36756003)(86362001)(44832011)(5660300002)(8676002)(2616005)(4326008)(8936002)(26005)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVJTYkVQUjFMcHgzQnUwYjdReTFuTldVRW12Z1M4Zi92OVNCcnM0TXJrV0Jp?= =?utf-8?B?M1R5R3gyUnhGUDRaK0ErSXc2YlRhNW00TUVaZHlOdXg2QW9WOHcrT0VJSjdx?= =?utf-8?B?N2JqYTkyT3ErTzE0bXRGbm9hUWhvY1JaYUk4YnlaK29OVnhJcm8yZ3JxWWFo?= =?utf-8?B?NTRhclptaXFadFdHa2o1L2JXL2pmblBCQ3pvcjNvc2RGUzBNbG5qMUJkSnhN?= =?utf-8?B?NUJoMURVTWFPdTRMOG15SVBtNW9aaHkwN3NFd3RvclJsYmMzYTVCdmJBV3B3?= =?utf-8?B?R0g2L0ZqZGhPY0xPUDBEV1dEVWgvejFHNDUrVGNqK3BpdE85STZTU0kxaHZ1?= =?utf-8?B?T1lDK3piVmpsTW5nR0tNNk0yV3kxZWc4SVdIUVpGbkxVZ3dacmlDcFFCbWVo?= =?utf-8?B?eVdwV0w3c1lUMERnTEI5cmd3S1kxS0VuZXBhK25kNVFqNVBpOE9IaTRHM29t?= =?utf-8?B?eHlnKzFSeDlsbnhMV0ZqU1lIL2p0dHVtblNqbGVsbGYrUFhnTnFsL20wZDVh?= =?utf-8?B?WVpFSDZSNmJ2b2hxcjBFS0czS3hJR1UrcmtlcjFjenNHR0hnV2c1NTJETllC?= =?utf-8?B?eUFBYWRRZkx1UVVwdVQyRXZhQ0FTbEh1aG5lVEkzZzc4NEVxUjcweDIyTzY0?= =?utf-8?B?ZmIrNE5RMjFycWh1Ky9Id3RwbEt5WTRjSGZQR1BPL1dzd2dpckkxNEJPU2E2?= =?utf-8?B?aDBoNWRKa0ZWVWpPMkM1NC9FbXZxdE9CVS9TQVpndCtScWp0ZUxXR2NGVHA1?= =?utf-8?B?QUlkUWpkUmNpeWdxajFobE9SNWVwdWpMMVY4d0FDdzFwREFGTEg0dERLQlBW?= =?utf-8?B?UGxsdE1UV3A3Slp3ekdseDQ2U2dvdTh2WWVOWUttWG5qMkJBcWtXTnZOZDBi?= =?utf-8?B?SUsydTJDL0kyZmV5bWNabllaNWdLZTZjQlR3blVDQU81dDhvdkEzWmNiN25u?= =?utf-8?B?b0todEJrTkJIUXZIa0xmMllPNDY3RU5DSUNkdStnaWJGT0s4ZnB2emYxWEx3?= =?utf-8?B?TVNMOVNXSnJ4SWRLY0VlcU5GaW8xRnlGK056MFMzNkh0Um9zUWgrSWxnQld2?= =?utf-8?B?aW8xWVN3RUttY1l5Um0zdDhMTk9CZ1VWM3lhTHRMNDhOczdEcnl6NzBzMklF?= =?utf-8?B?bFN1MVJwaDZRUFd6RDhTRjBjaGFQNVd5VVRqaHBUK20yN2lkQmtJU0xXeEE5?= =?utf-8?B?SDRWeW9ISFdwOEpIZ1ZYbFk4T05wYVZrV1ByWnBaVXFGdzVLenJsOHB4Skxi?= =?utf-8?B?ejVWcWVjY2lLekFqUUxIWVhkUVplbkxka0RWTXRSdXhTamg2ZkJ5L3FWQWZG?= =?utf-8?B?SGZRcTRFcjk0VjRCYUNJaDMvM0JoVGMzOTdjMUtHTlFYTUhoelFwbXozL1Zp?= =?utf-8?B?TmFJN2wybHVOeEw0aEJCQ0JZZWo4bUk0QXRNa0tQclBoK3E2c0gwOGFSV0hj?= =?utf-8?B?bVlxb2pRUkVFT3pKUzhYQ2xQOFdFMXhtMWh3bHQ0UXgrR2Qxbkpsd0RQQlV1?= =?utf-8?B?MVlXUnpYZFF1SkJsR2JKZlRIZmJwd1pMUmtZQVNxRHFOQ0t1R2U3SUxoYnF4?= =?utf-8?B?SGpZTDA0cWFBNFlUUVRhOHBCckUxaENPN2MvUURvaHNseTNMOG1PK1JZa3A1?= =?utf-8?B?eEF2eGFoRFhsa2RsOFVPaElsTmVacngzTU5TR0pDcHlZUUVCZk80QmRwTHZx?= =?utf-8?B?MzU4eUU5dFVVeVlzbEd6ZVhuWjJ4bStCaHhNOGRNMW5WNkU3d3B6R0xvc2Fo?= =?utf-8?B?S1FSTWpsK1RNM2lIZEpGQ3BiWjRuM1diSWo1M1Fqb1QyNzVoZXd1M2pSVXN4?= =?utf-8?B?QW13RXk2LzdqRTRuN056YlJieENPSWt0WjY1WnAyTXhmcnJoenordldNcUNC?= =?utf-8?B?eTNtQmVpY2Z5QUszZjg3Q2diSGNCYSs0NVQ2a0JjU2VFcDUxWThYcUNSaWNm?= =?utf-8?B?YlhHVXhPLzYxd1ZhOVhyU05NZW1PbW4vL3ViMkdTZlhpSzJKZFZIS0tOdFJ6?= =?utf-8?B?NVVJOWN0T3ZUMWRVTlBtU2grb0c5MFFqVlIxWnRWTlVkUFpycnZVWU91bm9D?= =?utf-8?B?eDRScGdyNFBVbS9yTjQwUG5jZmN2S3ZVNlBzcG52SGtJN1lNS2s1UmdoWnh0?= =?utf-8?Q?5HtE=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9abad8d9-eea4-476b-a6c2-08dbd574d541 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 16:09:57.6104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2t7jXxR+OPWch99yPLKQRrApYCYZu227Bk+T3rY+rd/MZc5ImuEXV+ua8h/4M0pQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6709 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/24/2023 3:28 AM, Chaoyong He wrote: > Introduce the very basic NFP vDPA library. > > Signed-off-by: Shujing Dong > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang <...> > --- /dev/null > +++ b/drivers/vdpa/nfp/meson.build > @@ -0,0 +1,16 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright (c) 2023 Corigine, Inc. > + > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') > + build = false > + reason = 'only supported on 64-bit Linux' > +endif > + > +if not dpdk_conf.has('RTE_LIB_VHOST') > + build = false > + reason = 'missing dependency, DPDK vhost library' > +endif > + Similar to previous comment, this may break the build. Instead of this check, it is possible to add vhost and common/nfp as dependency to this driver, using 'deps'. > +sources = files( > + 'nfp_vdpa_log.c', > +) > diff --git a/drivers/vdpa/nfp/nfp_vdpa_log.c b/drivers/vdpa/nfp/nfp_vdpa_log.c > new file mode 100644 > index 0000000000..8c957d59ea > --- /dev/null > +++ b/drivers/vdpa/nfp/nfp_vdpa_log.c > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright (c) 2023 Corigine, Inc. > + * All rights reserved. > + */ > + > +#include "nfp_vdpa_log.h" > + > +RTE_LOG_REGISTER_SUFFIX(nfp_core_logtype, driver, NOTICE); > +RTE_LOG_REGISTER_SUFFIX(nfp_vdpa_logtype, driver, NOTICE); > Both has 'driver' has suffix, I assume copy/paste error.