DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, <dev@dpdk.org>
Cc: Bruce Richardson <bruce.richardson@intel.com>, <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse
Date: Tue, 15 May 2018 14:36:44 +0300	[thread overview]
Message-ID: <d986a385-0854-7a70-2323-4dc8b8a3c4eb@solarflare.com> (raw)
In-Reply-To: <e2abe0583336c0c4fa38d4a4151c1ee9e05c99fc.1526381067.git.anatoly.burakov@intel.com>

On 05/15/2018 01:44 PM, Anatoly Burakov wrote:
> The intention of the original code was to create runtime data
> directory as early as possible, however it was moved too early,
> before the arguments were parsed, resulting in --file-prefix
> option essentially not working.
>
> Fix this by moving eal_create_runtime_dir() to after command
> line arguments parsing.
>
> Fixes: 56236363b481 ("eal: add directory for runtime data")
>
> Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>

I've tested it quickly and it solves the problem I observe.
I suppose it is OK that the directory remains after application exit.

  reply	other threads:[~2018-05-15 11:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 10:44 Anatoly Burakov
2018-05-15 11:36 ` Andrew Rybchenko [this message]
2018-05-15 12:16   ` Burakov, Anatoly
2018-05-15 14:03     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d986a385-0854-7a70-2323-4dc8b8a3c4eb@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).