From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 207CE42C6F; Fri, 9 Jun 2023 16:17:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E687042FAE; Fri, 9 Jun 2023 16:17:46 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2070.outbound.protection.outlook.com [40.107.94.70]) by mails.dpdk.org (Postfix) with ESMTP id B099240EDB; Fri, 9 Jun 2023 16:17:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hd8hrVnsnJKWCVyDQLjerHzniso3KIj8+nhj7gIS2PiWSa+xZvSIzdtihSaNC/9Nyms1QJl5+VUkmUGrr4Bt+WWm5fRyuHSWXJ8+YrYlKeEckEXa/rjddatvit8cchI9aJZyXbG8/ScnQsH/DJtAoyk2leSciFCkZWvF/vZL1xGsjy1NV+Wx2KPHib78oB21FMdXa7l8EGSh7nsjjNGZ4QXm5JOXqKQoqBw1XQauL271RBIvkIDfwNUdtZ4id951HE9OdsiFyy40conHq5VuRFihqV6omfpeZKQy0qAjD4gg/ZfTpSacKSr6JwiL0TVEyTJ9ap07IP8vT8VYJiPxvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cGA5KeS0i7llWmnqb0Ug7dewIvQU2Ve8czbDyWtHVJw=; b=nX5Fd3J3WMqdXcsftnDolnbkkZ9mOq7U+f415jjQkLGyQOT+I5IetFASnxTn70/7nTLnWR+n9GFLvZd43u5jXkcMLQHCSz1CmWBY5hWoRAPy8gaX7wpJ4UQm9gu516bGoeHIO1fBPDtOa6uxvW3NsoJnvzVVvQWiZF0yqwENGAfchh3uUjKAqBhYIhYEuP40YFEtuo+M4c8wLyN17TTBGx824sW0vA5g1YwmzrSfoNetFZFVXL/M9XMwyWr8f62DjoZGAZWmlZvdzB34Ml/WwdCtnUYncS9q2KTCojFRbIqF/b4PiqWUZJ/0CHWO7rVn1Uo2lz8kLyPtHFwhrC7QxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cGA5KeS0i7llWmnqb0Ug7dewIvQU2Ve8czbDyWtHVJw=; b=uoGQlzxn++VA6r/Y8yRR2YIg3RnadupzU1IU8WB2IR1d2xC/byrFvuqoLGZQWJnOlGgOldUnQwc/Uhhmvh4wRgcDwY/5ngwrrPbginhCAHzGTdrfVRisxraxS6oeqJSxS8AoStE0Nb/lLxJ0Oczkyp/TLt9Uvco3jifawrOnotk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6011.namprd12.prod.outlook.com (2603:10b6:8:6b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Fri, 9 Jun 2023 14:17:43 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Fri, 9 Jun 2023 14:17:43 +0000 Message-ID: Date: Fri, 9 Jun 2023 15:17:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] net/nfp: fix incorrect link status after LSC event Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, James Hershaw , stable@dpdk.org, Long Wu References: <20230609062846.1334539-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230609062846.1334539-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0014.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::26) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6011:EE_ X-MS-Office365-Filtering-Correlation-Id: 413ec1a8-aabd-4048-3941-08db68f44a6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A7Nty7K4A2xcC0bRINHYx+2DAQYuHrpfw0vnzG1Xy3/ENNOIlROGNxJURNwznQHzrryuFG4pKDwWA3zgJ3aM/S6fPIDcB6bfm5jCyN8SSX79MU/lTyEPSkm6k/8ABHoDZ+I3qKW3YNO2JJ6rTUwhKrCyI7Ow82NcapNBGvhP+Cy3wf7OniLeB1Xs3inNTDkwJl/NOqWcKgC4ovV0QvkWEFhXq5SlQNjEk41N0Cy3PphE5AH6NYR7GmBzzp6VyNcTh2ficRF/GvzQgoDX7MdvYSsOQ5wMkmBq/hJG7ATLPQmOh3AYtgb5kUF0wpYqVHKsqqxZG1wA5wLr6Esb6ZbDMSLgfwzAyilNDGVdYOV1R1hrvZYdK4JgvvI3xhUZt9jklrDmsNmY0mRtaLc0+zTXiVZPxaQPjVPKhRZlyl1qj1wDT+NzGuK8y7SLPOkWSui2iDoBo0nezM1Uizd4iJle8ZEPwb19uWVBNFXygDru8orkaLVrLNS1MhzNVf8BvzrMXhStj+ftWAmPv0DCn4FIVYrR5ewDYsSPriOVczwZ/SQ5nPy6ZEHHfhgM6h1r4giBljlEfVVu6gBmthXKWU1nJSEC5h1o7Yfp8KJvktkMCdQakxGb9lQaneXxvsCo0ezv8O9TdjzqIzVW5AkBwHtPlg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(451199021)(6506007)(53546011)(6512007)(186003)(66574015)(83380400001)(31696002)(86362001)(2616005)(38100700002)(26005)(36756003)(41300700001)(66556008)(8936002)(54906003)(44832011)(2906002)(478600001)(4744005)(8676002)(4326008)(316002)(31686004)(5660300002)(66946007)(6486002)(66476007)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmYzOWhTaVE0TFZkN21mWm1TNWEyMGYwaWlzRnRxYTAzdlNLbUM5enNDT3Fr?= =?utf-8?B?Y01pZWJoaGREbkVjOHpmVU9mRDNNN1h0U3FSejNhUk1NYlo1RkZteEVNNXg5?= =?utf-8?B?aXRWUEtpWWh2aEYzTXNiR2dZdi90bHJUa0xQeVdGVGFUdXkxd2d3VzFlNTU3?= =?utf-8?B?VEI3S1ArYXdWeWlqbVJJbHBDVzJGVlkwVlNOMlFpcHc3VCs0UFhFN0lucGZZ?= =?utf-8?B?VEhVL0RuV3VrMG0xMTlsRUVjak9WWjF0bVdBa2owZlFYVXN6aXhhc0hoUkp5?= =?utf-8?B?ZzFsV3d6dzJheTZmeFc3ekJGQmh3cldtZVdoZE9peGRXNDVvUHRiVFhTbytR?= =?utf-8?B?K3lEeFBEWDZFVTdITW1Zd29jbnBIa1ZzWE9sY2l3MS9kckZPNmQ5b2RrbGVG?= =?utf-8?B?aWFQdnoyczZLaW83UGhRemdLSUdrSnNzVXNrQWVsM0w0blhrUDI1NmRCVzhp?= =?utf-8?B?ZWdvZjIrbjVuenJKMXhFRVFTYmpYR3YyVWJzKzBKY1VkeFR0eTRqaXdaWnVK?= =?utf-8?B?aGR2RjFsYUtLc09UZnRmQU5xdWdQbjNFVXROR1FncEZLUDZaSHlXSStZVVV5?= =?utf-8?B?MEd1Y09STCtKNTFCUzlKM00xWTNkZDlGeWxxMXB3Ykoyc2F5QzlwQjV3QW5q?= =?utf-8?B?cTdxckJFZWdtL1dLWHBHbkVDY052UGZBY2Fjc25OS05naGZjTDdoZk50WGxT?= =?utf-8?B?RGlPcW1yUlM1TmNSNnl6c3dlZWhhNmtqa0wxeEQ0a2tickxoR3VYRWxCSXUw?= =?utf-8?B?WDRzenk1M0haZGtJOHpFaCtyaERrY3dDVEZDMkpvSUNYc0Y1TmxJZHpDalZi?= =?utf-8?B?ZEozMkVzMFRhNStmbThmT0xxSGlUdTBEZ1MxRXVBRG1DSGNpU3dqcldjZ0Uz?= =?utf-8?B?OXNlOG9aQTh0Q2ZwRmhlZDFiOC9IZjlpMzYxc2FWTlJCdEZHU2VQSmxBaTF6?= =?utf-8?B?dnUrSWwxRjdtRkR2WThUdjFLUmR5Q1lOc3V5MTdtcFVkdElWeWJyS05LdnBs?= =?utf-8?B?cmNJd09Kdjk3Skd1YWdmS3gzRUtsUkhwcWhlKzA4emw3TFhNRGo0aERSMkQ5?= =?utf-8?B?WHlicUYxS1hRaThZRFVtbWFFTEdRS1dDaUVTNEJTSTYxTy9HMXBuVDFYSHEy?= =?utf-8?B?c3FmTGxtUkFxOTN1WDZQR3M4YXFKY3RzeFp6b2QrTFc1b1BuSnlreUpEUmpZ?= =?utf-8?B?MUZqMk1TaWZETm5KbXd5bWRQY3dOZjdRV2Z5eFlZUEh2bnZIZUZJYjgxRHZo?= =?utf-8?B?YVFHL3VQb0xFNnZzMWNoby9VQmdRZ3lqMUM2ZVNOUG5RTm5kQXVqV21Gb2Nl?= =?utf-8?B?ZzJxMHdYQ1NpTmdMMHNYZElCMWlBZHd6bHI0cFlPLzRWR0paUHlYMGFFeE93?= =?utf-8?B?M29VU0FvamhDVTlxT0lEK29oZXdKcGE5Vjc5aTZlNlVBelZpdVFJd0F2OEd1?= =?utf-8?B?cWVoMC9HQWpOb1RXdk9KanZXZUlxVWN5N0R0cG9GQlI4V09BZHdtRzhqZzhk?= =?utf-8?B?L3pyR0JEWGdEbVN3NUNJMndmcWVLZ0N4NW9abC9ZMWpxQTR5RWFxN2pFbkpL?= =?utf-8?B?cmlXSHR1ZE56V0wrRTBrd0tvNHdWNVlINzhDYzZ5TzMrNjZGbmZBd0J5bG81?= =?utf-8?B?T2N3MC9HY2hob0lLTzdmTjhML0c1eEcybHRhMnRRbXdBQ29OU0IyZnpORmZQ?= =?utf-8?B?d1V4cmFaSWU0cmNPSk9UOWdBdE0yU05DUW9lWjVzZUFFQW83MEtkRE1VZW5t?= =?utf-8?B?YjFiWHNRektISCs4SnhYZmZMMVl0a0QxeGVBdTdRcUd3bmNVR00yV2xNWUZz?= =?utf-8?B?TTBqZGVVNGR0MXFkZmxEWk8yTmxZSld0RWFxcHpERytXS3NRVk5jNzZnMkdM?= =?utf-8?B?cTdSZ09scFJiSDN5UWs2R3BXK1ovWEI5YTJOc0xabzg4ajBpZ0xXditZUzZ3?= =?utf-8?B?bkNyK3RKV05NQ2RxT1hoWFlGaGdhTHA2bXVMell2b1VJL0p1dTJaakorRlo0?= =?utf-8?B?S0pCWm1BYkpGMVZtU0pVRGZwODNPcnRINENZbXVhOXoydHJURmZOZkxnRlh1?= =?utf-8?B?azY2dXp4WkVmQWR4N3ZEVmcxL0U2VWZwbjNNaS9GTHdwNW5FeG1GM0Y3cVYw?= =?utf-8?Q?9Z/ZH9GFqb8JQOzO5EUKkF3jE?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 413ec1a8-aabd-4048-3941-08db68f44a6c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 14:17:43.4647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Jhsnw3SSYB9jE5+gIeVZ8uyXznu470Hrp0iXZ9/yO9wloHY1N7OknyDuSj7h/qp X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6011 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/9/2023 7:28 AM, Chaoyong He wrote: > From: James Hershaw > > Incorrect port speed shown after a link state and interrupt of type > RTE_ETH_EVENT_INTR_LSC occurs. This is because the interrupt handler for > this type of event in the nfp PMD does not reconfigure the netdev. > > Fixed by moving the call to the nfp_net_notify_port_speed() function to > within the nfp_net_link_update() function, which is called by the > interrupt handler. > > Fixes: 36a9abd4b679 ("net/nfp: write link speed to control BAR") > Cc: stable@dpdk.org > > Signed-off-by: James Hershaw > Reviewed-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Niklas Söderlund > Applied to dpdk-next-net/main, thanks.