From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Jakub Grajciar <jgrajcia@cisco.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Huisong Li <lihuisong@huawei.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org, David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/memif: fix driver init with default MTU
Date: Wed, 27 Oct 2021 18:13:23 +0300 [thread overview]
Message-ID: <d9a14ed2-5d61-1db3-b11e-3725d7d075b4@oktetlabs.ru> (raw)
In-Reply-To: <20211027091429.2996153-2-ferruh.yigit@intel.com>
On 10/27/21 12:14 PM, Ferruh Yigit wrote:
> Driver is using 'ETH_FRAME_LEN' Linux defined value as max frame length,
> which doesn't include FCS (4 bytes CRC). But ethdev by default uses
> frame size with FCS when application doesn't define any explicit value.
>
> As a result device configuration fails because device is tried to be
> configured with a frame size length that is bigger than what device
> reported as supported. Device reports as max supported frame size is
> 1514 but configured value is 1518.
>
> Instead use DPDK macro, 'RTE_ETHER_MAX_LEN', that includes FCS in the
> driver to report the max supported frame size, this matches to the
> initial intention.
>
> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Reported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Tested-by: David Christensen <drc@linux.vnet.ibm.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
next prev parent reply other threads:[~2021-10-27 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:38 [dpdk-dev] [PATCH 1/2] net/af_packet: " Ferruh Yigit
2021-10-26 15:38 ` [dpdk-dev] [PATCH 2/2] net/memif: " Ferruh Yigit
2021-10-26 15:45 ` David Christensen
2021-10-26 20:47 ` Stephen Hemminger
2021-10-27 8:27 ` Ferruh Yigit
2021-10-27 9:14 ` [dpdk-dev] [PATCH v2 1/2] net/af_packet: " Ferruh Yigit
2021-10-27 9:14 ` [dpdk-dev] [PATCH v2 2/2] net/memif: " Ferruh Yigit
2021-10-27 15:13 ` Andrew Rybchenko [this message]
2021-10-27 15:12 ` [dpdk-dev] [PATCH v2 1/2] net/af_packet: " Andrew Rybchenko
2021-10-27 15:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a14ed2-5d61-1db3-b11e-3725d7d075b4@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=ferruh.yigit@intel.com \
--cc=jgrajcia@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=lihuisong@huawei.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).