From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2675A0C47; Wed, 27 Oct 2021 17:13:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9F2E410F7; Wed, 27 Oct 2021 17:13:26 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id B3F0E40DDA for ; Wed, 27 Oct 2021 17:13:25 +0200 (CEST) Received: from [192.168.1.71] (unknown [188.170.75.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B4A287F53A; Wed, 27 Oct 2021 18:13:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B4A287F53A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1635347605; bh=wmJXS0RdM+OYcokJKuD1In4E4cE5mwpfGMH2Xo0sxMs=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=t6v92F95uqRdy/FiGycCWlcVZRTUrnTZ6TuJSOaR41hRqgWQcDCk4tgaBeaSN+pHQ Dvs3yTS3/1+BjJoK2liczjl9eBU4PXF4Lb/kOZaD1aqmf0t0K16vacAPId68DW/+Yi WzqHLjJ/Gb3lxi4q6vpYZsuNleWux5Xk/8YS6Gzc= To: Ferruh Yigit , Jakub Grajciar , Somnath Kotur , Huisong Li , Ajit Khaparde , Konstantin Ananyev Cc: dev@dpdk.org, David Christensen References: <20211026153802.1820636-1-ferruh.yigit@intel.com> <20211027091429.2996153-1-ferruh.yigit@intel.com> <20211027091429.2996153-2-ferruh.yigit@intel.com> From: Andrew Rybchenko Message-ID: Date: Wed, 27 Oct 2021 18:13:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211027091429.2996153-2-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/memif: fix driver init with default MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/21 12:14 PM, Ferruh Yigit wrote: > Driver is using 'ETH_FRAME_LEN' Linux defined value as max frame length, > which doesn't include FCS (4 bytes CRC). But ethdev by default uses > frame size with FCS when application doesn't define any explicit value. > > As a result device configuration fails because device is tried to be > configured with a frame size length that is bigger than what device > reported as supported. Device reports as max supported frame size is > 1514 but configured value is 1518. > > Instead use DPDK macro, 'RTE_ETHER_MAX_LEN', that includes FCS in the > driver to report the max supported frame size, this matches to the > initial intention. > > Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") > > Signed-off-by: Ferruh Yigit > Reported-by: Andrew Rybchenko > Tested-by: David Christensen Reviewed-by: Andrew Rybchenko