From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
ferruh.yigit@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve interrupt management
Date: Thu, 29 Apr 2021 11:48:38 +0200 [thread overview]
Message-ID: <d9ce1f7d-1df5-0b73-d527-7899ee3d9282@redhat.com> (raw)
In-Reply-To: <2943250.H0OykbTYAW@thomas>
Hi Matan,
On 4/11/21 11:07 AM, Thomas Monjalon wrote:
> 07/04/2021 08:49, Xia, Chenbo:
>>> Signed-off-by: Matan Azrad <matan@nvidia.com>
>>> Acked-by: Xueming Li <xuemingl@nvidia.com>
>>
>> Patch applied to next-virtio/main with conflict resolved.
>>
>> Thanks!
>
> Sorry it cannot be pulled in the main tree because it breaks
> compilation with musl libc.
>
> It can be fixed in the same way as in
> 41b5a7a8494e ("vdpa/mlx5: replace pthread functions unavailable in musl")
> The function pthread_attr_setaffinity_np() must be replaced with
> pthread_setaffinity_np() if moved after the call to pthread_create().
>
> We could add a checkpatch check for forbidden functions like
> pthread_yield, pthread_attr_setaffinity_np
> and forbidden includes:
> <error.h>, <sys/fcntl.h>
>
>
Could you please send a new version taking care of Thomas' request.
Thanks,
Maxime
next prev parent reply other threads:[~2021-04-29 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 9:13 Matan Azrad
2021-03-29 14:09 ` Maxime Coquelin
2021-04-07 6:49 ` Xia, Chenbo
2021-04-11 9:07 ` Thomas Monjalon
2021-04-29 9:48 ` Maxime Coquelin [this message]
2021-05-02 10:47 ` Matan Azrad
2021-05-02 10:45 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2021-05-03 14:27 ` Maxime Coquelin
2021-05-04 8:29 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ce1f7d-1df5-0b73-d527-7899ee3d9282@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).