From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE15343A96; Wed, 7 Feb 2024 08:09:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A01644067B; Wed, 7 Feb 2024 08:09:17 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43]) by mails.dpdk.org (Postfix) with ESMTP id 1EFE1402EC for ; Wed, 7 Feb 2024 08:09:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cmm73EwNb665Fxfk62pZ1mooRveAfgORVLHx+sdMXAaB1mR8FfRHUHLCOTmVUwHp8px8JOzmvVbMuCZyzKuaowaUpoQtIZaSRXmB61dzyjwF4sxwYfELNp5RVC08fOGtfNg6822wKFY11mfAs7w3iturw4KQFnUxG1ggLDiLU4pm2lySgFGIcROPwIzZ0SCmKr4YobXvlC4SCZpofPS8fdxk1eFQ6Ps3LNuZdOzwaYmULeNLkvvSFYyHRmlgnQRxaL2k84HWo8WjT9YidOgXWwPvcKP9VRYXLKCneMHsWPtruvEKE33ElW+kbB3/LdMybNhN43OQYKmx2V54hAQR8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CAg2Z0UvZ8JlH6LoaGnHpedevNlKn5ZqAEQL/gqgHo4=; b=Pk7XxQcOGfPQdQTBXaWX/Tlj1Ucbtul8i3CN/uEP1PdvV+yteYLh59Bfvtw4xDcvlfUXkyzrvCCjim8JVujn85E8nwaV2brnVcFOAINg+RBVl97Vni2FqzON74KelYjd6RGSvZTGhoOaHTyCYCHyca3Wfrll5opSoEop6phOCJvy0JwWJ9G+tm7QxvoksKWLPHAadsOWq5kSww3qzAw4tpoW79sPMWQ7rhQQ2l3MePsJU85V71EwqS1MVz9WW9U4yaHklQ5wrZAMX1/auXWR7TFvwL53jXIeieZSgw1TQd9bXjxvrp5JDcLKTJJ3Yc51RVOu8bdpTXOEq74KcsjEqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CAg2Z0UvZ8JlH6LoaGnHpedevNlKn5ZqAEQL/gqgHo4=; b=d4ImwIX1giDvpAyaeI0SIfOGWsQi+aGYeIDQ7IZsRvZMqlsDMtgAK+4fTrf95ww4KPtUx15Xm0h0OveIwOTxf136zX6fkMnSVtPjLybIk5qCP28XxXqoZcylNnVcn3eT90iWghehKLEFAHLrv0CqurYFUU+xJRqTFJOp4+NWlNG8VcxEe/CI2nEGLYAL7Mp9cZI0Cae0mARYvrGZBGlpsY/ywQ4XlnozyuAYfiH1k3uWIPL2X37zHGsJz8SC4B+eGKiQ4sTYk+e6bGDHUpMWTSu4wjDZUl5POrO0rIaRtC6rCywiHn3iUK/ZiCieNah9KAZVUmHrPOR3F4zps46v0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) by DM6PR12MB4449.namprd12.prod.outlook.com (2603:10b6:5:2a5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Wed, 7 Feb 2024 07:09:13 +0000 Received: from IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::5610:835d:9e24:6cfd]) by IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::5610:835d:9e24:6cfd%4]) with mapi id 15.20.7270.015; Wed, 7 Feb 2024 07:09:13 +0000 Date: Wed, 7 Feb 2024 09:09:08 +0200 (IST) From: "Etelson, Gregory" To: Thomas Monjalon cc: Gregory Etelson , dev@dpdk.org, mkashani@nvidia.com, Ori Kam , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v2] ethdev: add template table resize API In-Reply-To: <2641325.k3LOHGUjKi@thomas> Message-ID: References: <20231217093205.321082-1-getelson@nvidia.com> <20240131095938.177493-1-getelson@nvidia.com> <2641325.k3LOHGUjKi@thomas> Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: LO4P123CA0523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::7) To IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6332:EE_|DM6PR12MB4449:EE_ X-MS-Office365-Filtering-Correlation-Id: a9fde428-9397-430f-9475-08dc27abb031 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z9iWGR01hAKDTffH35X+8KHs4tlSyypAq0S9GtCGRxjsm2zdvNIIpEr6B+zDs6nHSOC0YRlTUvTbCffOZ1lAdxdmVkHck4Dn0yVd5MhDfbkYaPGUlDlnNWu4LM0wPGFYXx7FQbsloYo6abcNAcko2puL6sNqYwcE6JxlcX2cOxcBehf/gO9Pb6BqhQiKhW9aifk32WXzMdQ5oKX9Ke2RYLUnadvjBzgbeAZfpuVL+YpPO5/Fgofx0QjP4A3SPfMYyolcuZxefwRhDTTd8RCNBkLoN2jSSlYeHo411Mirv4fVxeOIRSZXEB10mVpYJXutZnZeglnBYVb6M1PZqTrD6IeB7g9Sw+YSH/Gl2oxuZ/xJy+7MaB1YBFXHX9jm+wOTJE5jksKjQcpkILPygUhi4+TMy9fvyJKpdlQ/8oMEeRy1/Q6O+5utPFKFkQbA+I90JAmtrLIwWrFEkfnrv1Kz3RiBXnv5J1VGmfz5n64m2Jl0rZNyaj3PZ3S/WWgX6EDDeTCbcJ1jo/0lVm0eHoMwPHjWzkIi3oTBZh/PAxNfQhzXi5Zp77RXSS2Z+M3YRh1G0nPBxd7ICRYo1isDqiBRjeivt/qdB7wxE5vYow+JboJDUQhgbMyyd14H51XE+6PJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB6332.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(39860400002)(396003)(376002)(136003)(230273577357003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(38100700002)(41300700001)(36756003)(478600001)(316002)(31696002)(66476007)(8936002)(8676002)(66946007)(6916009)(4326008)(54906003)(6486002)(66556008)(86362001)(5660300002)(2616005)(6512007)(83380400001)(6666004)(6506007)(2906002)(31686004)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?86AGbnoCcUI0mh/5/bEfDhf+uHs2Emez9PmnHpwKbie3G+uL5nROgETMA7ED?= =?us-ascii?Q?1AQs7qmxPyReyAuvIpkX5GuwAuSnw7EXd5ZzaFioNR0p+rc42kdxtsSvhi3N?= =?us-ascii?Q?DTu8Wx9byxRNdIhUrpqCsQKZnUYpyMn0HCZ/W0Wy9cKHuJq+nje5m1QXYijJ?= =?us-ascii?Q?h0viLuqGZdPrh1iGNx/zRIX0r4sfxOoziQFnnvgE9hOePTRwzQ0PmguhEdIZ?= =?us-ascii?Q?H7I3lwgdS9CHdwDXnHzQo/83doL5ZulzR678D/IL0SFCz5PsnHOOjKMiJHZ6?= =?us-ascii?Q?Z5Uud18AMjbLkTTF3uvIKXzGK+u9vOKTC9lUJbqb6O7t3ONFTqDv6z0Bmk4j?= =?us-ascii?Q?VVg/4IY4GlL/aa7yii0dtvnVTs1BUhm9bWHKQzET4F/vVU/EXSOaS9MNockj?= =?us-ascii?Q?F5a7VmD3MZ9CzIYoZsqA2Aw49HiwlyFuUhccjk2+Z1D8jNvGfpHaX7B8TIit?= =?us-ascii?Q?j+9YWMnkxjlLq76kjY2mU50OklxgojTT+GNRkdpiSbpzGLr4N1N1hEY6rIVp?= =?us-ascii?Q?ygHYBHC5p4W1kGP+PTiUg3Br/Dz1sSXTs/mZ+V2YaFIEq8Bpho7oyfH9Eg/C?= =?us-ascii?Q?wJbd4m04FlLoksJO/Dt67QBj4yNymqKkUMeZ+dkcek+GpGVrTk06xvaWLZCG?= =?us-ascii?Q?mUOazPoTgPhB+xuJ/YE6MWQf9pd+mua0W3OHorTmnlqyIyIiBd5vB83Ncp22?= =?us-ascii?Q?xVIORaHueYPuxQIHoalqqwxFm5qcP1KAeu5tcPpYxXS1w1yDuLUunZTIxtBQ?= =?us-ascii?Q?5W+HTp1VEzwpjmlo+3+LbPfAq5Yg+8jG8cTgV3BLc0y74NJajjFZeS5xAsQ2?= =?us-ascii?Q?lokB6O16xJ5qpGBsmdJlqoM84Z6rNoQHArTVgKnuMBogDh2Ltn1bPsvlm6h+?= =?us-ascii?Q?GlNVULcHBeecxp6fp0diU2oyUXD/95HuslMOo+Yzdr9SbAt/4OizKe+pRAn/?= =?us-ascii?Q?BaShAkMHOZqLdLY37FsLIlkQfFk2LC644hIfje8OBHerLV5Sz/DYUUBZGAVt?= =?us-ascii?Q?sN0Hga/8X468feON+z22gTa4J936y4AXYxGYmS+qg+P4q1jhxMDj1j71Yx/q?= =?us-ascii?Q?2Tg8+t1VfDPyLFsVjXz1YlzXarKfRdqkwfSXEeIdtGh/m/o9F2dZEoG0zOyQ?= =?us-ascii?Q?WHxXGpQ5j2Mb+rFyNrEe0JamJo+8mwQmnEJt9uu1jcwoKysYIOlhDuNqje1s?= =?us-ascii?Q?D1V+Xt/yT4pyEU6Fl6Ei68ZxiG8T4Oi35nGPHfwWGw9/EA+NvU7ApRZU0CjE?= =?us-ascii?Q?OO1MFCUy07e82CwBIvAZPXwYCKo6cPAboHFL2um6JUXwUx36JPbcDLuCpPwg?= =?us-ascii?Q?1d1x0g0wIRx9sbztrRn6LrmgWAXp2xr9VT85DqA9RvWGv62FeB6NOBXts3jI?= =?us-ascii?Q?T9x1r5DF9L5fBhreLo666buPm2Hntsyg1bTJO0bFLm6aUMUClSecvjN8E2SB?= =?us-ascii?Q?Av9+0y0S791zg+c6+SdvcpQCLJ/Higvfv4AN2vVM9o5U8wKwIU4eoqg4GgrF?= =?us-ascii?Q?rIkYnG419fy3hqeHDQi5JbQ2f/yZeinDLh0/a25RaxAocm8UgvPPv5bfqsM3?= =?us-ascii?Q?lfefswcW5A4+ddG5KF3p+TMEz9lECeyQ8sgCufeyS86FFYk+qebbstRscDeh?= =?us-ascii?Q?G14cbmyCgTpAcGm/SnpOdJqMUf3NoAS50N/0ivYdVFgl?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9fde428-9397-430f-9475-08dc27abb031 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6332.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 07:09:13.0763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lQ4s6U9Xa3zJVA7aRA2nnjdIqXHP7Jdv9X71kJBPKXomWKhyghOcK3/b50WNsDMMXUFjwsIkk4Pvv1X7kYbTqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4449 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Thomas, >> --- a/lib/ethdev/rte_flow.h >> +++ b/lib/ethdev/rte_flow.h >> #define RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_VPORT_ORIG RTE_BIT32(1) >> +/** >> + * Specialize table for resize. >> + */ >> +#define RTE_FLOW_TABLE_SPECIALIZE_RESIZABLE_TABLE RTE_BIT32(2) > > I'm not sure about the repeating "TABLE" at the end of this flag name. > > [...] >> +/** >> + * @warning >> + * @b EXPERIMENTAL: this API may change without prior notice. >> + * >> + * Query if a table can be resized > > s/if/whether/ > A dot is missing. > >> + * >> + * @param port_id >> + * Port identifier of Ethernet device. >> + * @param tbl_attr >> + * Template table > > Every lines should end with a dot in Doxygen for consistency. > >> + * >> + * @return >> + * True if the table can be resized. >> + */ >> +static __rte_always_inline bool > > Why is it inline? > In general we avoid inline except for few performance sensitive ones. > >> +rte_flow_table_resizable(__rte_unused uint16_t port_id, >> + const struct rte_flow_template_table_attr *tbl_attr) >> +{ >> + return (tbl_attr->specialize & >> + RTE_FLOW_TABLE_SPECIALIZE_RESIZABLE_TABLE) != 0; >> +} > > [...] >> + # added in 24.03 >> + rte_flow_template_table_resize; >> + rte_flow_async_update_resized; >> + rte_flow_template_table_resize_complete; > > I like the idea of these 3 new functions. > The scenario should be described in doc/guides/prog_guide/rte_flow.rst > > > I'll post an update.