From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 573134342E; Fri, 15 Mar 2024 09:34:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B766742DCA; Fri, 15 Mar 2024 09:34:04 +0100 (CET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2083.outbound.protection.outlook.com [40.107.105.83]) by mails.dpdk.org (Postfix) with ESMTP id EB2B64027B for ; Fri, 15 Mar 2024 09:34:03 +0100 (CET) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AiQEco5FQ9CALGLSqK5Jf8p28gF+TTOtiA2XhV1Maffl9/lHDAhzkM5nQ4BU0lmQv3NMKCa52LSKccFLLQZu4HWpFP6eX8ojQ0qIAbddf4bw4c2j7WjPEhQox0FZNR8ATjfUgWV+uolEoWhEdKDCj67w3CPUjzbbo6qG+/D/8yZ6Hcjn5pcWxahKhuKAkLEOrYO5Wmxs4OjICrMWOo69fnOPs8kgVoekEAsLVJgutV0VhmswIwKilUMANjscYSv7KkQGWbMMLGY/9ktgW0/JgBlJ1sZVpHJx7w+/lrF/l/MISSgi3M0DRXTKNHPPHrQp34ZUX/j1f+cyMQGWjxWYHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZTShgmFjpoy+94tBQBBHQkju0+anOrFR2XtFfYfGGUw=; b=EFVXheiuVktMDv7A0pmEQKIUfOFAigbmAMOOCNllm2QxIUhNDe4Nu2uBt2qqpT+Gup/JKzarNCO62UWWTB51z520EOB5C5mPETDwBiBaGC0nYwEZ6YrqAgS3CIqbdsGw+TazaKLYC9wejc/9PPdVfj9pYG+Mj0gJVRrOQsOnKR6IZipVJGH3HMrXbxPDwnHESN9tza1T6cWg649/YCbPfVkt/2FC2/NP52Q1W1MtYezG3oESdNEq2lJUaYUq69RbnnGuLr5mVpj/h39LkAtgWoIMgAvaESOBTXube8UWS2bvlFq3buYQ1LmbTW/DdcBNsxCbddaxtmnqfccpQGAIpw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZTShgmFjpoy+94tBQBBHQkju0+anOrFR2XtFfYfGGUw=; b=m0ssfjIzYTPOfCxKxVqYZgZEwLG1pvgu5fVrc4vcab4peK/rfc/y+Nvg5hyISITkcNl/OCWln3BgebAt6kogNDmoqXbU47Ex8J2ArZ/k0U7xSU+UbTF9JnnnXvVBkdlQ7LnOuPX+LIiLt3/ux40rkAQ7yASVa3PpBA9fx1A/DGQ= Received: from DB8P191CA0008.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::18) by GV1PR08MB8260.eurprd08.prod.outlook.com (2603:10a6:150:a1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Fri, 15 Mar 2024 08:34:01 +0000 Received: from DU6PEPF0000B620.eurprd02.prod.outlook.com (2603:10a6:10:130:cafe::ec) by DB8P191CA0008.outlook.office365.com (2603:10a6:10:130::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.22 via Frontend Transport; Fri, 15 Mar 2024 08:34:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF0000B620.mail.protection.outlook.com (10.167.8.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Fri, 15 Mar 2024 08:34:01 +0000 Received: ("Tessian outbound 5180408f3322:v276"); Fri, 15 Mar 2024 08:34:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 026fb751e5e5c8ff X-CR-MTA-TID: 64aa7808 Received: from e9624ef441fe.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 45C3EA28-403F-4EED-9B0E-779DB7CD3323.1; Fri, 15 Mar 2024 08:33:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9624ef441fe.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Mar 2024 08:33:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NFNLNPrtZLHBc1PiyvGTuSRyXWldUL6t6F8Y2e6pWfCQ8T7j3tvQp6y34/CL08AhM6ZtVyd4KNdbgSLuPetEZMxrJHvZLIC9iAGUCLliMXn+LDRLHsIxKubOmsSU4YCtCEYMkPGQE+JQIPrcntxYjLwezfiH3k4Zr4zTZBJC6dEX5G5PQ/iWdQuV85Go6Pams8/7tXA1jEG+1tH5BslIW3ADr69wlbKM9lvVjPRgrHLVNDuXCl2wIU3xXUkyR5t85Ywc0l48u5gmLeEWZQj1n8LxQOTk9CATe5s6/Es4unN4zQj5mbv4DneO9Pzyynl1qs7CsoskzXhP/9//4e1VTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZTShgmFjpoy+94tBQBBHQkju0+anOrFR2XtFfYfGGUw=; b=bGuF/3T9AnLfnhhzpEUj0cFR4TaHwKNbc0RHv+EJjKIKjy89YPkOjBD4Tc+IhE4ZM1Q66Gv/IMrC+DuIlZtUYmvJ5OZv1uO2WvMjGswZeFTLP4xi54rlWT8zjkmR+76TUeU2+yvH5pOP3hIoqRBQZTw4F+9JqC51Bvm1xStrDKY2ytqZUXuorwTvb74CEF0N4aPxTPmiycJ/DgVNF+6yTJ2yyyDK2/XXAZgC3pHn19Vjsg3d9FLOqU6dcnNOtfFHMsrjLV0z7/u+TWfCTLZxpAugVY/6vO0B8kTmNPgM3tt9naliNhgG4RoGJg+ULt0K0PCBZ+4+E+YwJGzem6g+Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZTShgmFjpoy+94tBQBBHQkju0+anOrFR2XtFfYfGGUw=; b=m0ssfjIzYTPOfCxKxVqYZgZEwLG1pvgu5fVrc4vcab4peK/rfc/y+Nvg5hyISITkcNl/OCWln3BgebAt6kogNDmoqXbU47Ex8J2ArZ/k0U7xSU+UbTF9JnnnXvVBkdlQ7LnOuPX+LIiLt3/ux40rkAQ7yASVa3PpBA9fx1A/DGQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB4PR08MB8151.eurprd08.prod.outlook.com (2603:10a6:10:381::16) by AM8PR08MB6564.eurprd08.prod.outlook.com (2603:10a6:20b:314::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.21; Fri, 15 Mar 2024 08:33:53 +0000 Received: from DB4PR08MB8151.eurprd08.prod.outlook.com ([fe80::a021:80c7:5fca:634]) by DB4PR08MB8151.eurprd08.prod.outlook.com ([fe80::a021:80c7:5fca:634%6]) with mapi id 15.20.7386.020; Fri, 15 Mar 2024 08:33:53 +0000 Message-ID: Date: Fri, 15 Mar 2024 08:33:50 +0000 User-Agent: Mozilla Thunderbird Cc: nd@arm.com, dev@dpdk.org Subject: Re: [PATCH v9 1/5] lib: allow libraries with no sources To: Bruce Richardson References: <20230927150854.3670391-2-paul.szczepanek@arm.com> <20240311144706.204831-1-paul.szczepanek@arm.com> <20240311144706.204831-2-paul.szczepanek@arm.com> Content-Language: en-US From: Paul Szczepanek In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0323.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::23) To DB4PR08MB8151.eurprd08.prod.outlook.com (2603:10a6:10:381::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB4PR08MB8151:EE_|AM8PR08MB6564:EE_|DU6PEPF0000B620:EE_|GV1PR08MB8260:EE_ X-MS-Office365-Filtering-Correlation-Id: ddd9ffe9-58d0-45e5-166a-08dc44caaa90 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qLo4jzDLx7SBKdzg+teQXCcrlrJh9syzUVrL38tZPH8pAtRxplylHV5b8DPf8UKGerg0Octj2/dTO6XotURgrJulpf1rkfI3HVOZR6jnzXwor3MkLwrorZRnDP/zeLTiXT22yrmYm99sNHvCAP1kPBQEtsKwlvgubaFh7kupunnYlnn1POQNNM3IyuFy4m+qz1lHoQFrlzTrNOBnq0lNcupq0ROqNXu5Fsrk4hf6DPAnnqPSDfrNhMRD2fV1IzMjrUYlbbFIFCALsxiwLw09tGNuXxpJB6/JschjjxVvOQxB4rXXBqs6pC316KthxE24YtPrWRurouSbGvfPYq5X25CY/yDqO/2E4sqdT/aEFTmUJX6IMDOR4RKG9DAXxdUIFmRmQfwrax6E7izbP88N8ybXjYa6LMwnqU1w5kjvSSvCGjeh7lDvpnt3Tbzwt9tq4hETbqlZaE522Yhemge30uotCV5+TvyxYivg2etFSu0aBvTcebgkuZp95SosXPl474MwbD3XcklALGNAj9nQvdlW9oLzYeIOCuK8SC1lN06iLlTw8jE1AfVQ1UAHaq2GAsL6hvp95NQ4L7s5nwx3I3+wT9PysJTLrw3uM6/PJjrQepRCs8dcA+sU5Ym2tomOr1N1uadb3mn3AtDgjuJ6lsjLlB1iunKJjs3sLP+3aFw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR08MB8151.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6564 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF0000B620.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c239d38a-fad3-4ca9-daa0-08dc44caa569 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k3BC7gqCPre0PvV6846Jzk95csCUZvoQuw1JysIf/wpJS5lfgakhpOli9hz6n1MmN7jQbPNBixKlHLchy3eBsVValInzDp3A/hyPddiDoqrN2l+20Imt5IvBwB/6zmo8LXGqdFJ22+cdsLeO4PcHDcnzITnkMiRvVyQx1oQKPCc8lSk3b4ZTp5iRA0Eka3s19pN00lZleUpx99W/DYbAh67AHWTMI8MNuiwkwfVncJs/Me1uRM0hWR5w//4DdUQHG4weoMa2g+h/CCNNdbp8sj7AiQ8XRmGnkUGtUKMk4a+sq5CXCntYEVHi2Xyp3k0En+xSM8wEZOTQKO8IBbh+N8+F4hmUznqIIRTfW1Kbsb/EQ6oPegdcotiKf49OV6dr7rFZpJ8NE6kMKgNRCYKEEXXDI031CQWADhD+4GwhHzUPMQtXIswEGihjiVHrOVFD6tD5ZDW3t7TTm7sZzgWoVtwaY37Jv8tMLefZV+RW1OQRR8yJW88WZAeFQmR+awVKX8zGKT69CQ8moIsUYUffOQVY8eFbq17asgCucfB1TKJyiptTsP3sjeb/hobNpJnusiP6H/s526O6HiKH2gP75QW67T1azRkSzu1mMrW1s718030gTdfc/H2k1OLR+w2AYD1F3au/DjBWL1PNnG1cPpjiZUd5SOiZY7F2iJpnbUU36zFSQ+0M5CkvUCukDeVGAnQ6s0cZhng61+Qr7FygTnct9pKMU3QYD5XKtvb11c5g4fL3pXuyRRieUGDVO27r X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2024 08:34:01.5420 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ddd9ffe9-58d0-45e5-166a-08dc44caaa90 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000B620.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8260 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/03/2024 15:23, Bruce Richardson wrote: > On Mon, Mar 11, 2024 at 02:47:02PM +0000, Paul Szczepanek wrote: >> Allow header only libraries. >> >> Signed-off-by: Paul Szczepanek >> Reviewed-by: Honnappa Nagarahalli >> --- >> lib/meson.build | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/lib/meson.build b/lib/meson.build >> index 179a272932..e4e31f7ecf 100644 >> --- a/lib/meson.build >> +++ b/lib/meson.build >> @@ -222,6 +222,20 @@ foreach l:libraries >> includes += include_directories(l) >> dpdk_includes += include_directories(l) >> >> + # special case for header only libraries >> + if sources.length() == 0 >> + header_lib_dep = declare_dependency(include_directories: includes, >> + dependencies: shared_deps) >> + set_variable('shared_rte_' + name, header_lib_dep) >> + set_variable('static_rte_' + name, header_lib_dep) >> + dpdk_shared_lib_deps += header_lib_dep >> + dpdk_static_lib_deps += header_lib_dep >> + if developer_mode >> + message('lib/@0@: Defining dependency "@1@"'.format(l, name)) >> + endif >> + continue >> + endif >> + >> if developer_mode and is_windows and use_function_versioning >> message('@0@: Function versioning is not supported by Windows.'.format(name)) >> endif > > Diff is much clearer this way, thank > > Acked-by: Bruce Richardson I had to fix a problem with the addition of `dependencies: shared_deps` requiring a separate header_lib_dep for static deps - which required a V10. Can I please get an Ack for the V10?