* [PATCH] net/nfp: fix offload drop flow rule failed
@ 2024-07-08 5:37 Chaoyong He
2024-07-08 15:58 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Chaoyong He @ 2024-07-08 5:37 UTC (permalink / raw)
To: dev; +Cc: oss-drivers, Long Wu, chaoyong.he, stable, Peng Zhang
From: Long Wu <long.wu@corigine.com>
The issue is caused by an invalid exit logic in flow compile function.
Fixes: 4839d4b4e180 ("net/nfp: forbid offload flow rules with empty action list")
Cc: chaoyong.he@corigine.com
Cc: stable@dpdk.org
Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/flower/nfp_flower_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c
index 24e7047407..df84eedae4 100644
--- a/drivers/net/nfp/flower/nfp_flower_flow.c
+++ b/drivers/net/nfp/flower/nfp_flower_flow.c
@@ -4757,7 +4757,7 @@ nfp_flow_compile_action(struct nfp_flower_representor *representor,
total_actions++;
}
- if (total_actions == 0 || param.position == param.action_data) {
+ if (nfp_flow->install_flag && total_actions == 0) {
PMD_DRV_LOG(ERR, "The action list is empty");
return -ENOTSUP;
}
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net/nfp: fix offload drop flow rule failed
2024-07-08 5:37 [PATCH] net/nfp: fix offload drop flow rule failed Chaoyong He
@ 2024-07-08 15:58 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2024-07-08 15:58 UTC (permalink / raw)
To: Chaoyong He, dev; +Cc: oss-drivers, Long Wu, stable, Peng Zhang
On 7/8/2024 6:37 AM, Chaoyong He wrote:
> From: Long Wu <long.wu@corigine.com>
>
> The issue is caused by an invalid exit logic in flow compile function.
>
> Fixes: 4839d4b4e180 ("net/nfp: forbid offload flow rules with empty action list")
> Cc: chaoyong.he@corigine.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-08 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-08 5:37 [PATCH] net/nfp: fix offload drop flow rule failed Chaoyong He
2024-07-08 15:58 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).