From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 449BEA0C4B; Thu, 21 Oct 2021 14:32:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1835441205; Thu, 21 Oct 2021 14:32:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 807FC41202 for ; Thu, 21 Oct 2021 14:32:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634819561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zdbcj1AtQWndluo1FVnXfbQ8sWdsZIyAGaYEmA7JK44=; b=cX0NlwTj36vx9chdrrQ2qkNsAcY6JvGNXqgaGizk0cgPzjnBRIqPhjUyp5osgRyywYzBMT 97NSSdDE1Vf37po1iSipUW9nQL1AmvInfgHoH78Zw6/VWOqf73kMCpHfqtnaVPyNJFuNjN qOi0UFE5e/K+3h3is2fFitCyIVgsn8U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-547-hmKkkgRQPYSJ1pqHyJbb7A-1; Thu, 21 Oct 2021 08:32:35 -0400 X-MC-Unique: hmKkkgRQPYSJ1pqHyJbb7A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 214C11F75B; Thu, 21 Oct 2021 12:32:34 +0000 (UTC) Received: from [10.39.208.27] (unknown [10.39.208.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 619E760D30; Thu, 21 Oct 2021 12:32:30 +0000 (UTC) Message-ID: Date: Thu, 21 Oct 2021 14:32:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Li Feng Cc: Chenbo Xia , Lin Li , Jin Yu , Yu Zhang , Xun Ni , dev@dpdk.org, stable@dpdk.org References: <20210827051241.2448098-1-fengli@smartx.com> <20211014124008.3570044-1-fengli@smartx.com> <93f2ee9b-d207-c6ce-d79f-55306fd8b8f4@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] vhost: add sanity check when operating the split ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/21 11:25, Li Feng wrote: > On Fri, Oct 15, 2021 at 4:52 PM Maxime Coquelin > wrote: >> >> The title is too vague, I would put something like: >> >> vhost: add sanity check on inflight last index >> >> On 10/14/21 14:40, Li Feng wrote: >>> The idx in rte_vhost_set_last_inflight_io_split is from the frontend >> >> s/idx/index/ >> >>> driver, check if it's in the virtqueue range. >>> >>> Fixes: bb0c2de9602b ("vhost: add APIs to operate inflight ring") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Li Feng >>> --- >>> lib/vhost/vhost.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c >>> index 9540522dac..3b674ac320 100644 >>> --- a/lib/vhost/vhost.c >>> +++ b/lib/vhost/vhost.c >>> @@ -1226,6 +1226,9 @@ rte_vhost_set_last_inflight_io_split(int vid, uint16_t vring_idx, >>> if (unlikely(!vq->inflight_split)) >>> return -1; >>> >>> + if (unlikely(idx >= vq->size)) >>> + return -1; >>> + >>> vq->inflight_split->last_inflight_io = idx; >>> return 0; >>> } >>> >> >> Other than that, this is fine to me: >> >> Reviewed-by: Maxime Coquelin >> >> If my suggestions are fine for you, I can fix while applying. >> > It's fine. > >> Thanks, >> Maxime >> > Applied to dpdk-next-virtio/main. Thanks, Maxime