From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FA41A0535; Wed, 12 Feb 2020 19:25:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD7941BF9F; Wed, 12 Feb 2020 19:25:42 +0100 (CET) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 656861BF7A for ; Wed, 12 Feb 2020 19:25:41 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200212182540euoutp01ee25273bb5bea02d96b47e31b3146bc5~yuuuZN62A1492714927euoutp01d for ; Wed, 12 Feb 2020 18:25:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200212182540euoutp01ee25273bb5bea02d96b47e31b3146bc5~yuuuZN62A1492714927euoutp01d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1581531940; bh=phPrMGAiNd3M5J/Iv9/A3seZUPgPQM22gCDn8uwkf1Y=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=rB1/0vOiM8oG4+zC6ppfZJlj6f+PShCe5e5M9U0dKGEayVPsGhoUL7KyBWrg0pwWp CeMxkzYxoRzwySmIVU1hbAVyDbiTAvz6pWVL9ZnaRyMvLFFDAVQHtjPwe1pepLNngk lBXoxD6Wjd/hZ3mG/u23iKs/v3pUKgwE65/2rMz0= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200212182539eucas1p14776cdf19238580a77b9d3fafded49b0~yuut0RgzH1242312423eucas1p1D; Wed, 12 Feb 2020 18:25:39 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 44.9F.60698.323444E5; Wed, 12 Feb 2020 18:25:39 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200212182539eucas1p1c4283ace4ec24341594ea59195d283e3~yuutjPrTE1242312423eucas1p1C; Wed, 12 Feb 2020 18:25:39 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200212182539eusmtrp21d79c9ae41774b8698a6e94b9007d989~yuutiq5d42938229382eusmtrp2i; Wed, 12 Feb 2020 18:25:39 +0000 (GMT) X-AuditID: cbfec7f5-a29ff7000001ed1a-80-5e4443235282 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id DD.7B.08375.323444E5; Wed, 12 Feb 2020 18:25:39 +0000 (GMT) Received: from [106.109.129.29] (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200212182538eusmtip164f2a3e02705075c356cb7f34c9f6972~yuutOF1FG2335723357eusmtip1V; Wed, 12 Feb 2020 18:25:38 +0000 (GMT) To: Tiwei Bie Cc: dev@dpdk.org, maxime.coquelin@redhat.com, amorenoz@redhat.com From: Ivan Dyukov Message-ID: Date: Wed, 12 Feb 2020 21:25:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200212103528.GA786542@___> Content-Language: ru-RU X-Brightmail-Tracker: H4sIAAAAAAAAA1WSa0iTURjHO3vfba/LyetU9mCaOalMyAsW7EOaoh9WkBWEROBl6ouXnI5N TQ1CzdlcBFIxnU2zaRh9yLzObKgtVMxIupgVaVYSXnLeNctLbmeBffud3/k/z+EPhyIE42x3 KjUji1FkSNNFHB7Z1rs2eNgnIjI2cNXiLVa1j5Fiy4KRJe4tNZHi1oItVhgp+V1zny2pNU2y JLOdQ5wzxAXesSQmPTWHUQSExvNS5udWSPn7RpTbqB3gFKBf9UiDHCigj8BUxxJHg3iUgH6A YKZik40PSwiGv/ezrCkBvYjgU49cgyjbhPFxINb1CHR6Ic7PIqg2TLOtFy50CHRrR2yzrrQP rLzU2TxBh0P55iphZQ7tCwPqaluGT4eCduinjUl6P5jG9KSV3ejzoDVuIpxxhn7duM070H5g WSyx74yGR5+LEGYhzBmfcXAzAxdGNbmYI0GlLSMxu8BUXwsXswdsPbnLwnwZVpuGudYyQKsR jBpU9tBxaJl+xcXlw8Fcm4LRCT7MOONnneBmWzmBNR/UJQI8KILu/jd2DbDxxxFrCUzfMnDL kHfljl6VO7pU7uiC2Quutt4hKrc3EfQhaOgIwDoNdM1rBGZfUOmruP/H8ZqudyV29obb17/a MwfhhamOqEG7HyIhk62UJTPK4Azmkr9SKlNmZyT7J2bKmtD23xvY7FtuR53rCWZEU0jkyO+e iIgVsKU5yjyZGQFFiFz5wsJtxU+S5uUzisw4RXY6ozSjPRQpEvKDDZMxAjpZmsVcZBg5o/h3 y6Ic3AtQW4VwOe3sZNTGhKXwtNQjf35hl7boxlCiPjqt1CsyKu8e+/W+5z1q/clBeZg53tVj JvoUVfwlpGglISc3vrrFv1n/9kqdkBfE4nzsKp43eKr3yk1yxdMD3asNhN43z3v2W1wiy2fh qKqKcfux3ht+5oS+aZJzrmw8RjHS5am7JiKVKdIgP0KhlP4F3JxgGHcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsVy+t/xu7rKzi5xBn1L+S1adzxgsXj3aTuT xbHOPSwWWxv+MzmwePxasJTVY/Gel0we7/ddZQtgjtKzKcovLUlVyMgvLrFVija0MNIztLTQ MzKx1DM0No+1MjJV0rezSUnNySxLLdK3S9DLOH7vB3vBebmKXY80Gxh/SHQxcnBICJhIbN9g 0MXIxSEksJRR4k/TQ0aIuITE6yfMXYycQKawxJ9rXWwQNW8ZJfpavjGCJIQFbCUOTLvLBGKL CChLfDszkxXEZhZwlJj+7zszRMNtRonFy3+ANbAJaEic7pgH1sArYCcx7eobMJtFQFViz4M5 LCC2qECExOOJ7YwQNYISJ2c+AYtzCmhJvPvcBrUgTOJJ2xcWCFtc4sP2g2wTGAVnIWmZhaRs FpIyCNtMYt7mh8wQtrxE89bZQDYHkK0msaxVCVl4ASP7KkaR1NLi3PTcYkO94sTc4tK8dL3k /NxNjMB423bs5+YdjJc2Bh9iFOBgVOLhlXjtHCfEmlhWXJl7iFGCg1lJhFe8ESjEm5JYWZVa lB9fVJqTWnyI0RTo54nMUqLJ+cBUkFcSb2hqaG5haWhubG5sZqEkztshcDBGSCA9sSQ1OzW1 ILUIpo+Jg1OqgbE0IzhQ9M3j5kgHbuv9B5+pPLHXnxc1e162qfBpdi/WG3mfmdOjJVPWVPB+ Vv1yYP3ueXdKwwKfsxukrWZ89drxnShn8pVDJ3q2f373Uchnkfn57nszsxrst279dsY7QCaL YWJ3lPtj5cmnG69XhH89973Av3xr28xbszrCZcUWrDpavukxP4MSS3FGoqEWc1FxIgApEclA zQIAAA== X-CMS-MailID: 20200212182539eucas1p1c4283ace4ec24341594ea59195d283e3 X-Msg-Generator: CA X-RootMTR: 20200207112542eucas1p149c88c52b887aab888351eab73fe7639 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200207112542eucas1p149c88c52b887aab888351eab73fe7639 References: <20200207112526.11455-1-i.dyukov@samsung.com> <20200207112526.11455-2-i.dyukov@samsung.com> <20200212103528.GA786542@___> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tiwei, 12.02.2020 13:35, Tiwei Bie пишет: > On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: >> Some applications like pktgen use link_speed to calculate >> transmit rate. It limits outcome traffic to hardcoded 10G. >> >> This patch adds link_speed devarg which allows to configure >> link_speed of virtio device. >> >> Signed-off-by: Ivan Dyukov >> --- >> doc/guides/nics/virtio.rst | 7 ++ >> drivers/net/virtio/virtio_ethdev.c | 101 ++++++++++++++++++++++++----- >> drivers/net/virtio/virtio_pci.h | 1 + >> 3 files changed, 92 insertions(+), 17 deletions(-) > Maybe I missed something.. Why not enable the VIRTIO_NET_F_SPEED_DUPLEX > support directly? When that feature is supported and negotiated, > we will ignore this devarg? VIRTIO_NET_F_SPEED_DUPLEX keeps tunable values. In case of kernel driver, they could be changed with ethtool. If a device is mapped to poll mode driver, I think, we can tune it with dpdk devarg. If devarg is not specified then negotiate VIRTIO_NET_F_SPEED_DUPLEX. This is my current vision of the feature, but I have to investigate it. > If we want this devarg, it looks better to support it in virtio-user > as well (most code is shared between virtio-PMD and virtio-user). > Thanks! > Tiwei >