From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Heinrich Kuhn <heinrich.kuhn@netronome.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix nfp multiport syntax
Date: Fri, 23 Apr 2021 17:18:00 +0100 [thread overview]
Message-ID: <da3ccae4-6f86-daf9-2d0b-7f7e9d82c14d@intel.com> (raw)
In-Reply-To: <54de2177-d56c-2281-2e92-8603450a99c6@intel.com>
On 3/1/2021 1:45 PM, Ferruh Yigit wrote:
> On 2/25/2021 11:46 AM, Heinrich Kuhn wrote:
>> From: "Chaoyong.He" <chaoyong.he@corigine.com>
>>
>> 1. Fixup the suffix of the PCI ID to be consistent with the code.
>> 2. Add specification of using MAC address to identify port.
>>
>> Fixes: 979f2bae0 ("doc: improve multiport PF in nfp guide")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chaoyong.He <chaoyong.he@corigine.com>
>> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
>> ---
>> doc/guides/nics/nfp.rst | 14 +++++++++-----
>> 1 file changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/doc/guides/nics/nfp.rst b/doc/guides/nics/nfp.rst
>> index fef99973b..2b170539d 100644
>> --- a/doc/guides/nics/nfp.rst
>> +++ b/doc/guides/nics/nfp.rst
>> @@ -117,15 +117,19 @@ although once they are created, DPDK apps should be able
>> to use them as normal
>> PCI ports.
>> NFP ports belonging to same PF can be seen inside PMD initialization with a
>> -suffix added to the PCI ID: wwww:xx:yy.z_port_n. For example, a PF with PCI ID
>> +suffix added to the PCI ID: wwww:xx:yy.z_portn. For example, a PF with PCI ID
>> 0000:03:00.0 and four ports is seen by the PMD code as:
>> .. code-block:: console
>> - 0000:03:00.0_port_0
>> - 0000:03:00.0_port_1
>> - 0000:03:00.0_port_2
>> - 0000:03:00.0_port_3
>> + 0000:03:00.0_port0
>> + 0000:03:00.0_port1
>> + 0000:03:00.0_port2
>> + 0000:03:00.0_port3
>> +
>
> +1 to fix.
>
>> +Some dpdk applications can choose to use the MAC address to identify ports,
>> +OVS-DPDK is one such example, please refer to:
>> +https://docs.openvswitch.org/en/latest/howto/dpdk/
>
> This is not PMD specific information, not sure to have here,
> also not sure to have an external link here, basically for the maintenance
> concerns, should we document this usage withing DPDK in a wider than a PMD scope?
>
Ping.
Will there be a new version?
If not I can just get the fix part (s/port_n/portn).
next prev parent reply other threads:[~2021-04-23 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:46 [dpdk-dev] " Heinrich Kuhn
2021-03-01 13:45 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-23 16:18 ` Ferruh Yigit [this message]
2021-04-26 9:46 ` Ferruh Yigit
2021-04-26 9:48 ` Ferruh Yigit
2021-04-26 13:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da3ccae4-6f86-daf9-2d0b-7f7e9d82c14d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=heinrich.kuhn@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).