From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 7353D11C5
 for <dev@dpdk.org>; Thu, 23 Mar 2017 14:38:09 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 23 Mar 2017 06:38:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,210,1486454400"; d="scan'208";a="837778807"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
 ([10.237.220.122])
 by FMSMGA003.fm.intel.com with ESMTP; 23 Mar 2017 06:38:06 -0700
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>
References: <1487669225-30091-1-git-send-email-shijith.thotton@caviumnetworks.com>
 <1488454371-3342-1-git-send-email-shijith.thotton@caviumnetworks.com>
 <1488454371-3342-47-git-send-email-shijith.thotton@caviumnetworks.com>
 <9085133d-c06e-21f5-0b41-4a7d4281bb5e@intel.com> <20170323054442.GB2350@hone>
Cc: dev@dpdk.org, john.mcnamara@intel.com,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Derek Chickles <derek.chickles@caviumnetworks.com>,
 Venkat Koppula <venkat.koppula@caviumnetworks.com>,
 Srisivasubramanian S <ssrinivasan@caviumnetworks.com>,
 Mallesham Jatharakonda <mjatharakonda@oneconvergence.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <da573cd2-2944-faf4-863d-155e7d69cff0@intel.com>
Date: Thu, 23 Mar 2017 13:38:05 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170323054442.GB2350@hone>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 46/46] doc: add doc for liquidio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Mar 2017 13:38:09 -0000

On 3/23/2017 5:44 AM, Shijith Thotton wrote:
> On Tue, Mar 21, 2017 at 12:33:30PM +0000, Ferruh Yigit wrote:
>> On 3/2/2017 11:32 AM, Shijith Thotton wrote:
>>> Added doc/guides/nics/liquidio.rst and
>>> doc/guides/nics/features/liquidio.ini. Updated release notes.
>>>
>>> Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
>>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>>> Signed-off-by: Derek Chickles <derek.chickles@caviumnetworks.com>
>>> Signed-off-by: Venkat Koppula <venkat.koppula@caviumnetworks.com>
>>> Signed-off-by: Srisivasubramanian S <ssrinivasan@caviumnetworks.com>
>>> Signed-off-by: Mallesham Jatharakonda <mjatharakonda@oneconvergence.com>
>>

<...>

> 
>>> +VLAN filter          = Y
>>> +CRC offload          = Y
>>> +VLAN offload         = P
>>> +L3 checksum offload  = Y
>>> +L4 checksum offload  = Y
>>> +Inner L3 checksum    = Y
>>> +Inner L4 checksum    = Y
>>> +Basic stats          = Y
>>> +Extended stats       = Y
>>> +Linux UIO            = Y
>>> +Linux VFIO           = Y
>>> +x86-64               = Y
>>
>> Is other platforms not supported?
>> If that is the case, PMD should not be enabled by default.
>>
> 
> Verified build on x86-32, x86-64, ARM and for BSD targets. Hope that
> qualifies to be enabled by default.

That should be OK, thanks.

<...>

>>> +.. _lio_driver-compilation:
>>
>> Thank you for the documentation but below part seems generic to all
>> PMDs, and already documented in other PMDs.
>> I am not sure about this part, what do you think only keeping LiquidIO
>> related part? And perhaps we can prepare a common document that you can
>> reference here.
>>
> 
> I can submit a patchset aimed at this later, as this need to touch
> documentation of all PMDs with common part.

OK, thanks.
Please leave this part in patch as it is as this needs to be resolves in
a higher level.