From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81E07A0032; Thu, 14 Jul 2022 16:50:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F56B42B7E; Thu, 14 Jul 2022 16:50:57 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2079.outbound.protection.outlook.com [40.107.96.79]) by mails.dpdk.org (Postfix) with ESMTP id 593E442B74 for ; Thu, 14 Jul 2022 16:50:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GW5FP8kTS4BgHczKiqjpIeA9WMExq+zV/W1UaC/gdPNzM3rEE+YO0yFpTVF1u5DRjBT8PiJCnxlJ7Di6UfChel5O3K7LJzCYWHYeU6l4XDFRoCLViQH8HHDGiPotMHEFZod/JS9ZrCJvIAAaXYmgQmL3YYphmsL1+Sw7djOJ/wMmGcVRO3s5Eloz/KuYCXz6o/peVqXFUwwh3R2gYOBdjkrSaxhh/qba6NCFTM1KZOTMsMJA5waS3sODxQPpLho3falI4nW1US89hQVciFTHKBUyU0uwcP3sz84rn2nwQVgoUO98YrmuDsnzFpKLH1SLkAvoLzsCqkMJV7DgETK7YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bmRwd9U5IuYxVMel9OTUNUTs1hDFRUp6sawOduPSLYk=; b=NqVBZxPwlcUMQkT/pA82sYxJ74O6SLukMunYV0SPiKMEGXZJ6RwsfTrz1PveBvKPf0KHOr0vpi8yqAmYXni3EJK1J6NJY8y9kz9d2kTtBQJQWPZ17BGgvg6ngAUboW7NlB/qP7YGB3lscGfXK5H9Hw6p99A9rYtzd66gSeLtJSzPOPwPilKqUOuUBhbXQDEWemUIoGWQadcNJnQaC3e+izOeP23viMrqLX0fPElHeCUff9vUCIPyObuw7yjhVuJgD5MiIuhzc6y0bwGWRfqh6cXfno1XKtY1YdRJeQGoJwhUCqN+ujQOk2e7Hov3T1k0FOBSFTFquxvN1BPJdncsAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bmRwd9U5IuYxVMel9OTUNUTs1hDFRUp6sawOduPSLYk=; b=WkzDzpoRRZ9N78ASR9AVw1F6YnJrqJX63hmM7T0jdVFV7KpoYiJ9YTFVpc66QX3TAC7K4Xbheb1DMoibI6shlNDP34xz27EBNaaHMntvZfwRj/FoA4wYrD1vb0Fc9APjR0mk7eDKApSdHdl33KWzL8yrDnd6XhY+TEfagn3f8fs= Received: from BN9P223CA0013.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::18) by SN6PR02MB4800.namprd02.prod.outlook.com (2603:10b6:805:92::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.13; Thu, 14 Jul 2022 14:50:52 +0000 Received: from BN1NAM02FT051.eop-nam02.prod.protection.outlook.com (2603:10b6:408:10b:cafe::24) by BN9P223CA0013.outlook.office365.com (2603:10b6:408:10b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Thu, 14 Jul 2022 14:50:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT051.mail.protection.outlook.com (10.13.2.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5438.12 via Frontend Transport; Thu, 14 Jul 2022 14:50:51 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 14 Jul 2022 15:50:50 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 14 Jul 2022 15:50:50 +0100 Envelope-to: bruce.richardson@intel.com, thomas@monjalon.net, john.mcnamara@intel.com, dev@dpdk.org, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, maxime.coquelin@redhat.com, chenbo.xia@intel.com, mdr@ashroe.eu, olivier.matz@6wind.com, jerinj@marvell.com Received: from [172.21.36.148] (port=23835) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oC0B0-0003KU-Bk; Thu, 14 Jul 2022 15:50:50 +0100 Message-ID: Date: Thu, 14 Jul 2022 15:50:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v4] doc: announce KNI deprecation Content-Language: en-US To: Bruce Richardson , Thomas Monjalon , "Mcnamara, John" CC: , , , , , , , References: <20211124171609.3101896-2-ferruh.yigit@intel.com> <20220713161047.121805-1-thomas@monjalon.net> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4dd48fc9-661d-4eae-7da6-08da65a83f70 X-MS-TrafficTypeDiagnostic: SN6PR02MB4800:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PW5l1UDc+lOQUudEdUy63iglAtcRU+obkh3JKJ7N2fm39rlcarAAcj2aoJYWrAdPhMZ8kbBpjCMfhyu0PtuuM4wQKzMgY5H46fq1VdivCRA0TiV/OUuX5FjJU19SJVZ+CesG61mt1E+AJ1bZvMSEkU7tjQ4//CEvdwFKTdov0sXogNaigWiKXZ/oZLi4/e14v4W69rJeH7KMwlUB32mM2zw4Sk02pRqxY+bJgDbNwUbNo8YfrUbVa89qR+mkSS3vP3x8wwA/Ug/St65BYKBRGvlwBrkUN0GraMAxrROdjbMapJV8f5W90XKmv8uWnp6AOdeZmqgoeIWNDJm0I5eMbVufmt2wWYcfTG3Mo7yKtPG1Jv2hxqfhE/hX2sUdJj/zEGrX5w9pjTLvv8G1sACpuw+6wQHWWlsZcp4ZEuXdB98AWh9B20LKCHh0UoXEULY++QB3yUhPudaodTlG4KV17217DeKWIa1tcXnmsH2NT03v4nnB2uAWSvWmqqWZXE6sPUEoL3ROZEW2NZXocRMJKLlxknilqAEUDut9WUo2iHBx6Y7zm2Pl0cXIh6166r/kd4wZFz7P7pq3kSkcl5lYigSi0qVawVkpFg+FGOq9uOErR1Bm8e2DZXXiVshDzBCevh09DiHRKXhMfBwUyOczfAIyokTD0dsbwy0SOQy4FRgyT3hy2bJXFIHIePionZhRNWUfyLfC95jc9tzwM0j0GXNYQVh4WHsTQzM8zK88XLUuwI7yP111ex+ukpq8Ov22v+xB5t4vaL/FeNqGghSFbxccI5Prv/pNERKZIORRG8mFfxGvrrlwfTqxYmb+g42c9ixMNQDTi/mDgnUwyyZ/W/XQNJ84vk16ynoQTXoh1AnZAik8awmAB76Snua5YJJIohwgQ5sS5hNFV0EEUvpkR6BXkucwgpRbYK6M99blCIeraOQErWa6epj6v6jC9nQg X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(39860400002)(136003)(346002)(376002)(46966006)(36840700001)(40470700004)(110136005)(82740400003)(478600001)(41300700001)(54906003)(36756003)(7636003)(966005)(31696002)(316002)(426003)(70586007)(186003)(47076005)(336012)(31686004)(70206006)(2616005)(82310400005)(53546011)(2906002)(7416002)(26005)(40460700003)(8936002)(40480700001)(5660300002)(44832011)(9786002)(356005)(36860700001)(4326008)(8676002)(83380400001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 14:50:51.8032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd48fc9-661d-4eae-7da6-08da65a83f70 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT051.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4800 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/14/2022 10:20 AM, Bruce Richardson wrote: > On Wed, Jul 13, 2022 at 06:10:47PM +0200, Thomas Monjalon wrote: >> From: Ferruh Yigit >> >> Announce the deprecation plan for KNI kernel module, library and example. >> >> Signed-off-by: Ferruh Yigit >> Signed-off-by: Thomas Monjalon >> --- >> Squashed and updated 2 deprecations: >> https://patches.dpdk.org/project/dpdk/patch/20211124171609.3101896-2-ferruh.yigit@intel.com/ >> https://patches.dpdk.org/project/dpdk/patch/20211124171609.3101896-2-ferruh.yigit@intel.com/ >> --- > > One suggestion below. > With corrected link and with/without suggested change: > > Acked-by: Bruce Richardson > >> doc/guides/prog_guide/kernel_nic_interface.rst | 3 +++ >> doc/guides/rel_notes/deprecation.rst | 9 +++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst b/doc/guides/prog_guide/kernel_nic_interface.rst >> index e021cc69b6..03b5bca958 100644 >> --- a/doc/guides/prog_guide/kernel_nic_interface.rst >> +++ b/doc/guides/prog_guide/kernel_nic_interface.rst >> @@ -8,6 +8,9 @@ Kernel NIC Interface >> >> .. note:: >> >> + KNI is deprecated and will be removed in future. >> + See :doc:`../rel_notes/deprecation`. >> + >> For an alternative to KNI, that does not require any out-of-tree Linux kernel modules, >> or a custom library, see :ref:`virtio_user_as_exception_path`. >> >> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >> index 4e5b23c53d..e54597c591 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -48,6 +48,15 @@ Deprecation Notices >> in the header will not be considered as ABI anymore. This change is inspired >> by the RFC https://patchwork.dpdk.org/project/dpdk/list/?series=17176. >> >> +* kni: The KNI kernel module and library are not recommended for use by new >> + applications - other technologies such as virtio-user are recommended instead. >> + The KNI kernel module and library will be removed from DPDK 23.11, >> + following the DPDK technical board >> + `decision `_ >> + and `refinement `_. >> + The first steps are to add deprecation warnings >> + and to remove the example application from 22.11. >> + > > I wonder whether having this done as bullet points in chronological order > might be clearer. Something like: > > * kni: The KNI kernel module and library are not recommended for use by new > applications - other technologies such as virtio-user are recommended instead. > Following the DPDK technical board > `decision `_ > and `refinement `_: > * The KNI example application will be removed from DPDK 22.11 release > * The KNI kernel module and library will be removed from the DPDK 23.11 > release +1 to list actions in chronological order I have a concern with removing sample application without replacing one with alternate methods: virtio-user and tun/tap. It is easy to create a virtio-user PMD by testpmd or any sample application, and as far as I understand Bruce already documented this. But for many KNI users they are not using KNI PMD, so replacing KNI with this new method may require some hand holding. One option can be hotplug the virtio-user PMD and use the port_id for packet forwarding, and I don't know if the PMD has APIs that applications can use directly, as done in KNI, @Maxime & @Chenbo can answer this better. It can be good to have a sample application for above before deprecating the KNI sample application. And same sample can use tun/tap PMD with a runtime parameter, to show how other example can be used, again tap can be used as tap PMD or Linux tun/tap APIs. Question is who can work on such a sample, but if we can find some resource I am for having a replacement exception path sample app before deprecating KNI. Thanks, ferruh