From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] kni: reduce interface name size
Date: Tue, 19 Nov 2019 12:13:48 +0000 [thread overview]
Message-ID: <da7ad52c-c537-760f-034c-f0e2209eef0f@intel.com> (raw)
In-Reply-To: <20191115082328.71782fa3@hermes.lan>
On 11/15/2019 4:23 PM, Stephen Hemminger wrote:
> On Fri, 15 Nov 2019 12:41:07 +0100
> Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de> wrote:
>
>> The name in rte_kni_device_info is passed to the kernel, which allows
>> interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a
>> longer name currently trigger a kernel BUG in alloc_netdev_mqs in
>> net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation.
>>
>> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>
> Why not kill the NAMESIZE define in KNI and use the kernel one.
>
As mentioned in the thread, userspace doesn't know NAMESIZE, only kernel module
does, because "linux/if.h" is only included by kernel module.
I don't know if will there be any side affect of including relevant header and
creating this dependency to the userspace, but I am not for taking that chance
for this benefit, the comment already clarifies the value and it is not
something that will change.
next prev parent reply other threads:[~2019-11-19 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 11:41 Michael Pfeiffer
2019-11-15 12:30 ` Igor Ryzhov
2019-11-15 12:43 ` Ferruh Yigit
2019-11-15 12:43 ` Michael Pfeiffer
2019-11-15 12:49 ` Ferruh Yigit
2019-11-15 12:52 ` Michael Pfeiffer
2019-11-15 13:03 ` [dpdk-dev] [PATCH v2] " Michael Pfeiffer
2019-11-15 13:30 ` Ferruh Yigit
2019-11-19 21:02 ` David Marchand
2019-11-15 16:23 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2019-11-19 12:13 ` Ferruh Yigit [this message]
2019-11-19 20:58 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da7ad52c-c537-760f-034c-f0e2209eef0f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=michael.pfeiffer@tu-ilmenau.de \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).