DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Joshua Washington <joshwash@google.com>
Cc: Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>,
	dev@dpdk.org, Rushil Gupta <rushilg@google.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v5] app/testpmd: txonly multiflow port change support
Date: Wed, 17 May 2023 11:10:19 +0100	[thread overview]
Message-ID: <da83c7b9-31bd-9327-ab17-d3ac63bc4487@amd.com> (raw)
In-Reply-To: <CALuQH+WhnwRD7SQ0ngi4zXpLLh_d_s+YMPG9tO6t-9=f3j_aPA@mail.gmail.com>

On 5/16/2023 6:32 PM, Joshua Washington wrote:
> Hello,
> 
> I believe my original solution was something closer to what you are
> suggesting for backward compatibility. I originally had a flag that
> enabled changing source port instead of source IP addresses, but I
> received feedback that adding an extra flag was complicating things too
> much from Stephen.
> 
> On a VM, the purpose of using multi-flow is similar to that of bare
> metal: to test RSS in the RX side. However, generating traffic by
> changing source IP address can cause inconsistencies in performance due
> to protections in cloud infrastructure from sending packets from a
> different source IP address than is provisioned for the VM. Changing
> source UDP port to test RSS should be functionally equivalent while
> allowing VMs to send traffic from a single source IP address.
> 
> If everyone agrees that adding --txonly-multi-flow as an option as well
> as keeping the flag is an acceptable way of moving forward, I can do that.
> 

Hi Joshua,

I missed the first version of the patch and the comment, thinking twice
comment has a point, I was thinking some users doing RSS based on IP but
probably all supports RSS based on UDP too. Better to keep simple.

Lets proceed with latest version, I will put some comments on it.

Thanks,
Ferruh


  reply	other threads:[~2023-05-17 10:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 20:17 [PATCH v2] " Joshua Washington
2023-04-11 20:24 ` [PATCH v3] " Joshua Washington
2023-04-12 18:16   ` [PATCH v4] " Joshua Washington
2023-04-19 12:21     ` Singh, Aman Deep
2023-04-19 14:38       ` Stephen Hemminger
2023-04-21 23:20     ` [PATCH v5] " Joshua Washington
2023-04-24 17:55       ` Joshua Washington
2023-04-25  6:56         ` David Marchand
2023-04-26  7:24       ` Singh, Aman Deep
2023-05-15 18:11         ` Joshua Washington
2023-05-15 22:26       ` Ferruh Yigit
2023-05-16 17:32         ` Joshua Washington
2023-05-17 10:10           ` Ferruh Yigit [this message]
2023-05-17 10:34       ` Ferruh Yigit
2023-05-19  0:22       ` [PATCH v6] " Joshua Washington
2023-05-19 11:23         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da83c7b9-31bd-9327-ab17-d3ac63bc4487@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=joshwash@google.com \
    --cc=rushilg@google.com \
    --cc=stephen@networkplumber.org \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).