Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/3/2018 2:17 PM, Wiles, Keith wrote:
> 
> 
>> On Apr 3, 2018, at 4:28 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> Library folder name and output library name are same except a few flaws
>> including librte_ether.
>>
>> This library is network device abstraction layer, the name "ethdev" fits
>> better than "ether", and library & header files already named as ethdev.
>>
>> Also there is a rte_ether.h in the net library which can cause confusion.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Not sure if the we are ready for this change J
>>
>> This is one the issues that the hassle of the change doesn't worth the
>> benefit and you may prefer to live with the flaw.
>>
>> Also a concern is this breaks the git history.
> 
> I believe as long as you used ‘git mv’ the git history should not be broken, correct?

I think this will help in some conflict resolving or git blame, but if you check
the history directly with path, it won't show the past:

"git log --oneline lib/librte_ethdev/": Will start from this commit