From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DA99A317C for ; Thu, 17 Oct 2019 17:45:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C5F51E9BA; Thu, 17 Oct 2019 17:45:05 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DF5211E916 for ; Thu, 17 Oct 2019 17:45:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2019 08:45:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,308,1566889200"; d="scan'208";a="186524662" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.104]) ([10.237.220.104]) by orsmga007.jf.intel.com with ESMTP; 17 Oct 2019 08:45:01 -0700 To: Ajit Khaparde , dev@dpdk.org Cc: Rajesh Ravi , Jonathan Richardson , Scott Branden , Vikram Mysore Prakash References: <20191015053047.52260-1-ajit.khaparde@broadcom.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 17 Oct 2019 16:45:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191015053047.52260-1-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15-Oct-19 6:30 AM, Ajit Khaparde wrote: > From: Rajesh Ravi > > Support external custom memory added to heap to be used with vfio with > --iso-cmem option.Type1 memory mapping was by passed for external memory. > But an exception is added to allow external custom memory to be used with > vfio. > > Signed-off-by: Rajesh Ravi > Reviewed-by: Jonathan Richardson > Reviewed-by: Scott Branden > Reviewed-by: Vikram Mysore Prakash > Reviewed-by: Ajit Khaparde > --- Hi, First of all, what is "iso-cmem"? It doesn't seem to have any defined meaning nor any relation to any existing functionality, and it's not explained anywhere what is "isolated cmem". More importantly, why is this necessary? Type1 map only bypasses external segments when adding memory at startup - it doesn't stop you from calling rte_vfio_dma_map() to map the memory with VFIO when you create the segment. -- Thanks, Anatoly