From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CC8D68E7E for ; Tue, 17 Apr 2018 10:54:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 01:54:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="47555270" Received: from awalabdu-mobl.ger.corp.intel.com (HELO [163.33.228.229]) ([163.33.228.229]) by fmsmga001.fm.intel.com with ESMTP; 17 Apr 2018 01:54:52 -0700 To: Thomas Monjalon , Xueming Li Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Adrien Mazarguil , Nelio Laranjeiro , Shahaf Shuler , Olivier Matz References: <20180413110218.105894-1-xuemingl@mellanox.com> <20180413110218.105894-3-xuemingl@mellanox.com> <2345236.0ahlb2178t@xps> From: Mohammad Abdul Awal Message-ID: Date: Tue, 17 Apr 2018 09:54:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2345236.0ahlb2178t@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v4 2/5] ethdev: introduce new tunnel VXLAN-GPE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 08:54:55 -0000 On 16/04/2018 23:23, Thomas Monjalon wrote: > 13/04/2018 13:02, Xueming Li: >> +struct vxlan_gpe_hdr { >> + uint8_t vx_flags; /**< flag (8). */ >> + uint8_t reserved[2]; /**< Reserved (16). */ >> + uint8_t proto; /**< next-protocol (8). */ >> + uint32_t vx_vni; /**< VNI (24) + Reserved (8). */ >> +} __attribute__((__packed__)); > minor nit: the field comments could be aligned > Once addressed the above comment Acked-by: Mohammad Abdul Awal