From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6F7B437B0 for <dev@dpdk.org>; Thu, 19 Jan 2017 13:00:26 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 19 Jan 2017 04:00:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,253,1477983600"; d="scan'208";a="55787011" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga006.fm.intel.com with ESMTP; 19 Jan 2017 04:00:24 -0800 To: Yuanhan Liu <yuanhan.liu@linux.intel.com> References: <1484664872-26859-1-git-send-email-thomas.monjalon@6wind.com> <d046362e-d41d-fcab-ec9b-23d651b84ebc@intel.com> <1860075.ojoIIAvjcn@xps13> <20170118044150.GN10293@yliu-dev.sh.intel.com> <b94c6e0b-65e6-a438-0d1b-840ae529a11f@intel.com> <20170119080506.GT10293@yliu-dev.sh.intel.com> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org, pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <db014323-b58f-26f9-2c10-654129e9b94f@intel.com> Date: Thu, 19 Jan 2017 12:00:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170119080506.GT10293@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] devtools: check stable tag in fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 19 Jan 2017 12:00:26 -0000 On 1/19/2017 8:05 AM, Yuanhan Liu wrote: > On Wed, Jan 18, 2017 at 05:25:10PM +0000, Ferruh Yigit wrote: >> On 1/18/2017 4:41 AM, Yuanhan Liu wrote: >>> On Tue, Jan 17, 2017 at 07:42:33PM +0100, Thomas Monjalon wrote: >>>> 2017-01-17 18:15, Ferruh Yigit: >>>>> On 1/17/2017 2:54 PM, Thomas Monjalon wrote: >>>>>> The tag "Cc: stable@dpdk.org" must be set when the commit must be >>>>>> backported to a stable branch. >>>>>> >>>>>> It must be located just below the "Fixes:" tag (without blank line) >>>>>> and followed by a blank line, separated from SoB and review tags below. >>>>> >>>>> I am OK to keep it if it will help stable tree maintenance, but I still >>>>> not clear about why we need this. >>>>> >>>>> If a patch is a fix, it should already have "Fixes:" line, so this can >>>>> be used to parse git history. >>> >>> Same answer (as I have already replied to you in another email): not all fix >>> patches should be picked to stable branch. (I gave some examples below) >> >> I was thinking all fixes will have "Cc: stable" tag, to be sure all >> fixes sent to stable mail list, and you will be the picking for stable tree. >> >> Now you are suggesting some fixes may have "Fixes:" tag but not "Cc: >> stable" tag. >> >> So this means now author/maintainer/committer will be the picking >> patches for stable tree, and to show this decision, will add "Cc: >> stable" to the commit log. >> >> If author puts the "Cc: stable" tag, git send-email will ensure this >> patch will be sent to stable mail list too. >> But if author missed the "Cc: stable" tag, will it be enough for you if >> committer adds the tag into commit log? Or should patch sent to stable >> mail list too? > > Yes, that'd be enough. To highlight, and double check, the process will be updated as following: - Author may or may not have "CC: stable@dpdk.org" for fixes. - Maintainer/Committer may add "CC: stable@dpdk.org" tag to commit log, but won't send a mail to the stable mail list. - "CC: stable@dpdk.org" tags will remain in commit logs. > I will write a short script to monitor the > official DPDK git tree regularly (say weekly), to see whether there > are any new candidates (those with 'cc: stable' tag) for stable > releases or not. If so, I will pick them to stable. > >> >> What is the relation between "Cc: stable" tag been in commit log and >> patch been sent to stable mail list? > > Not too much. The stable mailing list provides a place for further > discussion on stable patches: > > - A notification will be sent to the stable mailing list when a patch > is chosen as a candidate for a stable release. People can shout out > if he thinks some patches should not have been picked for a stable > release. > > - people can also jump out to say, "hey, seems you forgot commit xxx, > which is a good have for stable release". > > --yliu >