From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 760EAA0613 for ; Tue, 24 Sep 2019 15:04:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0B2F2C19; Tue, 24 Sep 2019 15:04:30 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 468372C0C for ; Tue, 24 Sep 2019 15:04:29 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id E09A6B80084; Tue, 24 Sep 2019 13:04:18 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 24 Sep 2019 14:03:50 +0100 To: Ferruh Yigit , "John W. Linville" , Xiaolong Ye , Qi Zhang , Shepard Siegel , "Ed Czeck" , John Miller , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Gagandeep Singh , John Daley , "Hyong Youb Kim" , Gaetan Rivet , "Xiao Wang" , Ziyang Xuan , "Xiaoyun Wang" , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , "Zyta Szpak" , Liron Himi , Tomasz Duszynski , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Tetsuya Mukawa , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Rasesh Mody" , Shahed Shaikh , "Bruce Richardson" , Jan Remes , Rastislav Cernay , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Thomas Monjalon CC: , Igor Romanov References: <1567780495-14120-1-git-send-email-arybchenko@solarflare.com> <1567780495-14120-3-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: Date: Tue, 24 Sep 2019 16:03:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24930.003 X-TM-AS-Result: No-17.619200-8.000000-10 X-TMASE-MatchedRID: TmlY9+XBoTnA46G+uSzVzSLVdThWsHxY69aS+7/zbj+qvcIF1TcLYG8A yzAJO0+x8XVI39JCRnQ/+RTlAf4GnmufYHeLBgegMGAKZueP0mbkY2blxNFpR/Alhlr8vzcdhUf bNytzn7kzbYzjeuJDale5DbAgcRrEz4PoB/k4l5Msrsgn4MHj3lrdKD8oHqzd4Vo4xoaXBy8vr7 iJcUnmgTlmcXIYsBDAapGluBaTZnsIoZsIlwjKBv3HILfxLV/9QfblIp3oBdGU8ftiyKjZrUFZU hKPAgPiUwLe7DDVdoa3DVbxRAj7qz9nQ4Elgoe/lgE9m1ByUWdxWv4UB7dQNT5rmxYrg6WHLIHZ B0nMVDFH14dMZ2b25Wf1FLR58n9ZG+mWaWZtN+zBtFDYGmaWKjcy5Kr1d07TDC/Vm90If4UVcJR 4XudE5kXMeswpFkgKHcN4x+ltYL1zySdTkJm1SnEFgt4Wa1LtqmRbFDx9ddDZhqPLU/1bVdJRpJ 7c9LEB92grUwQgYZd5OPD8XJFfpE1+zyfzlN7ygxsfzkNRlfKx5amWK2anSLVV9mtf2bFYc1S0c SH9Bbcn5W11Ak914dIgzgCYPloCmFBfe2VPoKuQ5eu22pfDbAvDZjf7ASGXD+Qkqz0nhkYN0LHi +7tv+sRIoLdzyrHJ X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--17.619200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24930.003 X-MDID: 1569330267-7kWMbeAlRzH5 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: make stats and xstats reset callbacks return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/24/19 2:56 PM, Ferruh Yigit wrote: > On 9/6/2019 3:34 PM, Andrew Rybchenko wrote: >> From: Igor Romanov >> >> Change return value of the callbacks from void to int. Make >> implementations across all drivers return negative errno >> values in case of error conditions. >> >> Both callbacks are updated together because a large number of >> drivers assign the same function to both callbacks. >> >> Signed-off-by: Igor Romanov >> Signed-off-by: Andrew Rybchenko >> --- >> app/test/virtual_pmd.c | 4 ++- >> drivers/net/af_packet/rte_eth_af_packet.c | 4 ++- >> drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++- >> drivers/net/ark/ark_ethdev.c | 6 ++-- >> drivers/net/atlantic/atl_ethdev.c | 6 ++-- >> drivers/net/avp/avp_ethdev.c | 6 ++-- >> drivers/net/axgbe/axgbe_ethdev.c | 6 ++-- >> drivers/net/bnxt/bnxt_stats.c | 38 +++++++++++++++++------ >> drivers/net/bnxt/bnxt_stats.h | 4 +-- >> drivers/net/bonding/rte_eth_bond_pmd.c | 13 ++++++-- >> drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++- >> drivers/net/dpaa/dpaa_ethdev.c | 4 ++- >> drivers/net/dpaa2/dpaa2_ethdev.c | 10 +++--- >> drivers/net/e1000/em_ethdev.c | 6 ++-- >> drivers/net/e1000/igb_ethdev.c | 18 +++++++---- >> drivers/net/enetc/enetc_ethdev.c | 4 ++- >> drivers/net/enic/enic.h | 2 +- >> drivers/net/enic/enic_ethdev.c | 4 +-- >> drivers/net/enic/enic_main.c | 11 +++++-- >> drivers/net/failsafe/failsafe_ops.c | 16 ++++++++-- >> drivers/net/fm10k/fm10k_ethdev.c | 10 ++++-- >> drivers/net/hinic/base/hinic_pmd_niccfg.c | 14 ++++++--- >> drivers/net/hinic/base/hinic_pmd_niccfg.h | 4 +-- >> drivers/net/hinic/hinic_pmd_ethdev.c | 25 +++++++++++---- >> drivers/net/i40e/i40e_ethdev.c | 6 ++-- >> drivers/net/i40e/i40e_ethdev_vf.c | 6 ++-- >> drivers/net/i40e/i40e_vf_representor.c | 4 +-- >> drivers/net/iavf/iavf_ethdev.c | 11 ++++--- >> drivers/net/ice/ice_ethdev.c | 6 ++-- >> drivers/net/ipn3ke/ipn3ke_representor.c | 14 +++++---- >> drivers/net/ixgbe/ixgbe_ethdev.c | 18 +++++++---- >> drivers/net/kni/rte_eth_kni.c | 4 ++- >> drivers/net/liquidio/lio_ethdev.c | 23 ++++++++------ >> drivers/net/memif/rte_eth_memif.c | 4 ++- >> drivers/net/mlx4/mlx4.h | 2 +- >> drivers/net/mlx4/mlx4_ethdev.c | 7 ++++- >> drivers/net/mlx5/mlx5.h | 4 +-- >> drivers/net/mlx5/mlx5_stats.c | 19 +++++++++--- >> drivers/net/mvneta/mvneta_ethdev.c | 11 +++++-- >> drivers/net/mvpp2/mrvl_ethdev.c | 16 +++++++--- >> drivers/net/netvsc/hn_ethdev.c | 15 ++++++--- >> drivers/net/netvsc/hn_var.h | 4 +-- >> drivers/net/netvsc/hn_vf.c | 13 +++++--- >> drivers/net/nfp/nfp_net.c | 6 ++-- >> drivers/net/null/rte_eth_null.c | 6 ++-- >> drivers/net/octeontx/octeontx_ethdev.c | 8 ++--- >> drivers/net/octeontx2/otx2_ethdev.h | 4 +-- >> drivers/net/octeontx2/otx2_stats.c | 33 +++++++++++++------- >> drivers/net/pcap/rte_eth_pcap.c | 4 ++- >> drivers/net/qede/qede_ethdev.c | 8 +++-- >> drivers/net/ring/rte_eth_ring.c | 4 ++- >> drivers/net/sfc/sfc_ethdev.c | 7 +++-- >> drivers/net/szedata2/rte_eth_szedata2.c | 4 ++- >> drivers/net/tap/rte_eth_tap.c | 4 ++- >> drivers/net/thunderx/nicvf_ethdev.c | 13 ++++++-- >> drivers/net/vhost/rte_eth_vhost.c | 8 +++-- >> drivers/net/virtio/virtio_ethdev.c | 6 ++-- >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++-- >> lib/librte_ethdev/rte_ethdev.c | 12 ++++--- >> lib/librte_ethdev/rte_ethdev.h | 2 ++ >> lib/librte_ethdev/rte_ethdev_core.h | 4 +-- >> 61 files changed, 380 insertions(+), 169 deletions(-) > 'nfb' driver was missing, updating it while merging. Ops, thanks. > <...> > >> @@ -72,7 +72,7 @@ typedef int (*eth_stats_get_t)(struct rte_eth_dev *dev, >> struct rte_eth_stats *igb_stats); >> /**< @internal Get global I/O statistics of an Ethernet device. */ >> >> -typedef void (*eth_stats_reset_t)(struct rte_eth_dev *dev); >> +typedef int (*eth_stats_reset_t)(struct rte_eth_dev *dev); >> /**< @internal Reset global I/O statistics of an Ethernet device to 0. */ >> >> typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev, >> @@ -85,7 +85,7 @@ typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev, >> unsigned int n); >> /**< @internal Get extended stats of an Ethernet device. */ >> >> -typedef void (*eth_xstats_reset_t)(struct rte_eth_dev *dev); >> +typedef int (*eth_xstats_reset_t)(struct rte_eth_dev *dev); >> /**< @internal Reset extended stats of an Ethernet device. */ >> >> typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev, >> > Adding following comments to the dev_ops while merging, please shout if needs > update: > > -typedef void (*eth_stats_reset_t)(struct rte_eth_dev *dev); > -/**< @internal Reset global I/O statistics of an Ethernet device to 0. */ > +/** > + * @internal > + * Reset global I/O statistics of an Ethernet device to 0. > + * > + * @param dev > + * ethdev handle of port. > + * > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success, statistics has been reset. > + * @retval -ENOTSUP > + * Resetting statistics is not supported. > + * @retval -EINVAL > + * Resetting statistics is not valid. > + * @retval -ENOMEM > + * Not enough memory to get the stats. > + */ > +typedef int (*eth_stats_reset_t)(struct rte_eth_dev *dev); > > typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev, > struct rte_eth_xstat *stats, unsigned n); > @@ -129,8 +147,26 @@ typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev, > unsigned int n); > /**< @internal Get extended stats of an Ethernet device. */ > > -typedef void (*eth_xstats_reset_t)(struct rte_eth_dev *dev); > -/**< @internal Reset extended stats of an Ethernet device. */ > +/** > + * @internal > + * Reset extended stats of an Ethernet device. > + * > + * @param dev > + * ethdev handle of port. > + * > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success, statistics has been reset. > + * @retval -ENOTSUP > + * Resetting statistics is not supported. > + * @retval -EINVAL > + * Resetting statistics is not valid. > + * @retval -ENOMEM > + * Not enough memory to get the stats. > + */ > +typedef int (*eth_xstats_reset_t)(struct rte_eth_dev *dev); Thanks, LGTM