From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0498A00C5; Thu, 30 Apr 2020 12:02:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5855D1DB08; Thu, 30 Apr 2020 12:02:44 +0200 (CEST) Received: from relay0138.mxlogin.com (relay0138.mxlogin.com [199.181.239.138]) by dpdk.org (Postfix) with ESMTP id 9D36C1DB06 for ; Thu, 30 Apr 2020 12:02:42 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by relay0138.mxlogin.com (ZoneMTA) with ESMTPSA id 171ca89cabb000167e.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 30 Apr 2020 10:02:40 +0000 X-Zone-Loop: af134c44588eb4c2056e52d138d31055309d631f58b2 X-Originating-IP: [168.235.111.26] Received: from galaxy.mxroute.com (unknown [23.92.70.113]) by filter003.mxroute.com (Postfix) with ESMTPS id 6E8B460037; Thu, 30 Apr 2020 10:02:34 +0000 (UTC) Received: from [192.198.151.43] by galaxy.mxroute.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1jU5bJ-0001WK-AN; Thu, 30 Apr 2020 05:35:25 -0400 To: David Marchand Cc: Kevin Laatz , dev , Bruce Richardson , Van Haaren Harry , Thomas Monjalon , "Kinsella, Ray" , Neil Horman References: <20200416110040.42819-1-kevin.laatz@intel.com> <20200428124026.43783-1-kevin.laatz@intel.com> <0c78eb80-8a82-9892-b388-e72f9afe7cb6@ashroe.eu> From: Ray Kinsella Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: Date: Thu, 30 Apr 2020 11:02:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" So that isn't the issue either. $ grep RTE_CPUFLAG_NUMFLAGS build-gcc-shared/install/dump/librte_eal.dump 4646: $ grep RTE_CPUFLAG_NUMFLAGS /build/dpdk/reference/v20.02/build-gcc-shared/dump/librte_eal.dump 3296: 1.7-1.fc31 @updates I finally got libabigail complaining about rte_cpu_flag_t, after doing a complete clear down. So the suppression _is_ required. I then spent the following hour trying to identify the gremlin in the system with no luck. In anycase, added my ack below. On 29/04/2020 12:39, David Marchand wrote: > On Tue, Apr 28, 2020 at 6:39 PM Ray Kinsella wrote: >>> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore >>> index a59df8f13..045f436fb 100644 >>> --- a/devtools/libabigail.abignore >>> +++ b/devtools/libabigail.abignore >> >> Kevin - you still have the surpession. >> I am testing locally with 1.7.1, and it doesn't complain when I disable the supression. >> Are you seeing something different? > > Using current master libabigail, without the rule Kevin included, I > get the warning: > > 1 function with some indirect sub-type change: > > [C] 'function int rte_cpu_get_flag_enabled(rte_cpu_flag_t)' at > rte_cpuflags.c:144:1 has some indirect sub-type changes: > parameter 1 of type 'enum rte_cpu_flag_t' has sub-type changes: > type size hasn't changed > 17 enumerator insertions: > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512DQ' value '87' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512IFMA' value '88' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512CD' value '89' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512BW' value '90' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VL' value '91' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VBMI' value '92' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VBMI2' value '93' > 'rte_cpu_flag_t::RTE_CPUFLAG_GFNI' value '94' > 'rte_cpu_flag_t::RTE_CPUFLAG_VAES' value '95' > 'rte_cpu_flag_t::RTE_CPUFLAG_VPCLMULQDQ' value '96' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VNNI' value '97' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512BITALG' value '98' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VPOPCNTDQ' value '99' > 'rte_cpu_flag_t::RTE_CPUFLAG_CLDEMOTE' value '100' > 'rte_cpu_flag_t::RTE_CPUFLAG_MOVDIRI' value '101' > 'rte_cpu_flag_t::RTE_CPUFLAG_MOVDIR64B' value '102' > 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VP2INTERSECT' value '103' > 1 enumerator change: > 'rte_cpu_flag_t::RTE_CPUFLAG_NUMFLAGS' from value '87' to > '104' at rte_cpuflags.h:12:1 > > > Ray, could you check that the reference and new dumps in your env > contain this enum? > > $ grep RTE_CPUFLAG_NUMFLAGS > $HOME/abi/v20.02/x86_64-native-linux-gcc+shared+debug+ASSERT+RTE_IBVERBS_LINK_DLOPEN/dump/librte_eal.dump > > $ grep RTE_CPUFLAG_NUMFLAGS > $HOME/builds/x86_64-native-linux-gcc+shared+debug+ASSERT+RTE_IBVERBS_LINK_DLOPEN/install/dump/librte_eal.dump > > > If you are missing those, you might have built dpdk without debuginfo. > Acked-By: Ray Kinsella