From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id D4CB61B628 for ; Tue, 3 Apr 2018 10:02:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62270722E8; Tue, 3 Apr 2018 08:02:43 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF7B311422D9; Tue, 3 Apr 2018 08:02:41 +0000 (UTC) To: Zhihong Wang , dev@dpdk.org Cc: jianfeng.tan@intel.com, tiwei.bie@intel.com, yliu@fridaylinux.org, cunming.liang@intel.com, xiao.w.wang@intel.com, dan.daly@intel.com References: <1517614137-62926-1-git-send-email-zhihong.wang@intel.com> <20180402114656.17090-1-zhihong.wang@intel.com> <20180402114656.17090-3-zhihong.wang@intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 3 Apr 2018 10:02:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180402114656.17090-3-zhihong.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 03 Apr 2018 08:02:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 03 Apr 2018 08:02:43 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v5 2/5] vhost: support selective datapath X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 08:02:44 -0000 On 04/02/2018 01:46 PM, Zhihong Wang wrote: > This patch set introduces support for selective datapath in DPDK vhost-user > lib. vDPA stands for vhost Data Path Acceleration. The idea is to support > virtio ring compatible devices to serve virtio driver directly to enable > datapath acceleration. > > A set of device ops is defined for device specific operations: > > a. get_queue_num: Called to get supported queue number of the device. > > b. get_features: Called to get supported features of the device. > > c. get_protocol_features: Called to get supported protocol features of > the device. > > d. dev_conf: Called to configure the actual device when the virtio > device becomes ready. > > e. dev_close: Called to close the actual device when the virtio device > is stopped. > > f. set_vring_state: Called to change the state of the vring in the > actual device when vring state changes. > > g. set_features: Called to set the negotiated features to device. > > h. migration_done: Called to allow the device to response to RARP > sending. > > i. get_vfio_group_fd: Called to get the VFIO group fd of the device. > > j. get_vfio_device_fd: Called to get the VFIO device fd of the device. > > k. get_notify_area: Called to get the notify area info of the queue. > > Signed-off-by: Zhihong Wang > --- > Changes in v5: > > 1. Rename the vDPA device ops to follow convention. > > 2. Improve sanity check. > > --- > Changes in v4: > > 1. Remove the "engine" concept in the lib. > > --- > Changes in v2: > > 1. Add VFIO related vDPA device ops. > > lib/librte_vhost/Makefile | 4 +- > lib/librte_vhost/rte_vdpa.h | 87 +++++++++++++++++++++++++ > lib/librte_vhost/rte_vhost_version.map | 7 ++ > lib/librte_vhost/vdpa.c | 115 +++++++++++++++++++++++++++++++++ > 4 files changed, 211 insertions(+), 2 deletions(-) > create mode 100644 lib/librte_vhost/rte_vdpa.h > create mode 100644 lib/librte_vhost/vdpa.c > With the fix you suggested: Reviewed-by: Maxime Coquelin Thanks! Maxime