From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0537D41E2E; Fri, 10 Mar 2023 20:37:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBADF4113D; Fri, 10 Mar 2023 20:37:03 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 7AFF040DD8; Fri, 10 Mar 2023 20:37:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JT9nhZuHJ7SI6rbUG2RJBAR1RrUDqd8yFkdIWmLhyg5jmGE4dYJ5W3wM3lrSYFUIAIyIt+G/N/CRdvDDZGGGng8Ium58B2EHb9ofYEMk4yuKXGrozzFBZUVuZ+eLBWv739vwtWqz61Wd+e/gi1pNmIlWNBcxNKH6/PcGLvaCrmx8BsGdigc8Yyxb//SuAthf2xQ0Gnqfd+Nij5FjxcBgOE3oxbQucrQ93eFPYixPd2YH7s4qhFdFfFWb0SbjhjgoTahws5Pk8k018onQrM0we9i/QoCv+q1ctNCTxhbbLWkmyUSEu6XD+FZSlOceg55nDzuHxP1xE04rH7ViprWTww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GORdPIXZ19LS7AyTf/0jzmHPUzAys6mTQs/Bc0oyStA=; b=UCoZBhqZnoq5R+rE33jsHW7OLfSw4LRMC7uw4bEugk7Q72tJanuWTgTDtMxlILQHzEJzi8YBP2cnnDZMSkFF4adC6DGppGaIXFAhZMzZBNn+/LQ2XifqtmOAuVu3oUhvdPndyJR/9rhUcDQyDPhNQW2yuzmGJYYxudXAQAyv6PJ5JcNk+LQ2wAXyCYfbS12mYpX2nxTi+UlQXqjmCTc+3yVObrmZ1K3XIkH0ngQg7RkJ8bE8Cco0fVcaX03E9t8mdsyecuFl3EeZ5uQ5kOxyM2X6TmCHqS5uGBqr8JvIe1JL/B90XR3okUQVwZu3C7fSlOxD+Zkqq1ZqPh6P2uN/qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GORdPIXZ19LS7AyTf/0jzmHPUzAys6mTQs/Bc0oyStA=; b=u4qJVTQnLFSOeEqQqigDGIzhH8XGhaeahRbgsztx4R3SD+iM48wMNlJGHYDH1EeFo3c/aR+5g2lgLOA0REGR1nL/Me14K3ir2kSzOEtBWpzGM8MnC4RHRoQ97gTkLAD021Qi26b/+32CQ1gOk/q0OV0DRzzRLmUt9M63JPnDFaU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL3PR12MB6379.namprd12.prod.outlook.com (2603:10b6:208:3b2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 19:36:59 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 19:36:59 +0000 Message-ID: Date: Fri, 10 Mar 2023 19:36:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Dongdong Liu , dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru Cc: stable@dpdk.org, yisen.zhuang@huawei.com, lihuisong@huawei.com, Ori Kam References: <20230310093518.5198-1-liudongdong3@huawei.com> <20230310093518.5198-7-liudongdong3@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH 06/16] net/hns3: separate the setting of hash algorithm In-Reply-To: <20230310093518.5198-7-liudongdong3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0314.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL3PR12MB6379:EE_ X-MS-Office365-Filtering-Correlation-Id: c5c30076-fd8f-480b-9863-08db219ed09d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w6li081QvI4NlJC343s7OoM1yx3ljTD3K75K3k/+aqdx5opUEHSACYAU7qZ0b/MgmvvffNLydwkbYCEZJ8+BYssdRX/IvX0+Ok+RxPE1umaz+NCjdowJ9iE8HJzsCEoQnoSbNhxUGu4JfhUyonUzWmLLvop9X9jzw5MQXwAKlySV/zSWwaQdiVHLr5Qy2MlOpTYbuZAkestJn2sv5Jn4SfjW/Bc9MKbvw1z3lNu9aXxf9GK0DKg/Vp7JmtsFK5jm2Y3PNim5LUuReKg41Twm+t7KkeO+QlwcijWmkot2rCAKyMIj9gQl1qLvZeIUbLvDwBp+zTn8vswEmY3fGbNIJKCJdpbh2/S5dTpirtUVqHggHkwl7TRRNOGRGT3tQ2H+Px0+OSTFOGg34Px6uOFjCRGT1EegjdnJRZQWYAH/PkJBNvLwYrDJrnFEzrDO7tT4V9sygGo4FbGUIGUMYwnsLXRSQ8yB0Sr1DjrF7RXC0T4N0/PH2rTv37mEYZwhx5M5ydOc12L0jrT/Gromb5vT1mCPhpe3R6mbz8MWgEN1WDDMiMCmchywsniw4ookF5bKTjL9wSKejb29112/SiMhp7Ec2+p/pnNy85N3CmiLTBBSjcw28uyb6JiUDhVus3KlSNVickh2VuLJ/aguEBNSKhyVZyckrtnrmc2JrZlzHjIjIfrXh7ZtWN0GaWv+Sm0ab5RCIh4qgp4cOnlWHJEKQMGFndlz4B/AcuH3Gh+LDtU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(366004)(39860400002)(136003)(396003)(376002)(451199018)(66899018)(31686004)(2906002)(44832011)(5660300002)(6506007)(26005)(8936002)(36756003)(66946007)(31696002)(41300700001)(4326008)(66476007)(316002)(8676002)(66556008)(86362001)(478600001)(53546011)(6486002)(38100700002)(6666004)(6512007)(186003)(2616005)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWtCLzkxOXJqZkFMTjVKVnZ1T0tXOFpMODNOQVZZb1B6OGlzREtHUHZGbFNO?= =?utf-8?B?Y29OdGVDUUFUSmd1TnZaWG5RNXZGSitpc1hxOC8xTStRNXAybzJIL2NKLzJa?= =?utf-8?B?cnN3cUtXVGU2c2x6eHRnTlVkRnBPZlJQNUFQUkw1RG5vTXBONDdBbGxvT0p3?= =?utf-8?B?NTlSVmRpYkV0WXFpdEZLYnQybWc4YVRHeDltUFAwMmFMb0JzcjB2bG11Tmhr?= =?utf-8?B?L1ZsMi9DQ2U3Z01LRjl4ZWZKQjk4aCtGYlEzZ1d6ODc0WVNMNENhbEJURFcr?= =?utf-8?B?anFHK1RobFZmUUFoL1JWNzJvYlIrdk9WZmpJVW9WdU9xOTl6UitQTjNQaC9M?= =?utf-8?B?MEE2aHlIZU1VQmd6MGlKdjZhVmRZTUhkcitPeDhmUjZ2d3V5dkVsMkc5SSt1?= =?utf-8?B?bENCR3dtTGpSWnM2b3FhYWxxMnNWWitjRWUxbzNmNFpzMExGZHdRYzA3N1BH?= =?utf-8?B?OUFDbk1GOWVmalN1eWJnZTdsbGRhVmRaOU5OQzk5c3IvQm12TWZHVWVYWll3?= =?utf-8?B?YWExMFcyUW5qTSs5bXU1TmFQWUQ3YzYrZ0dMUXJDd1NkVTJBZlN3V2E1WlZo?= =?utf-8?B?L2UwcGZUaXJHeVAvamZJSUY2WWdZQThjWlFZaFJydXo0ZWhIQVRPdlYvT2d0?= =?utf-8?B?cEtPZGtQN2Y0cFRFL3ZxNEQ5YUx0MzRHbUhZSGcyR29DanFlcFNrSFdnVnRD?= =?utf-8?B?K2VmMGN6QXhiOXJwZ1RONUg0dlNMVHRIeTJacDNRUUpiMTYwVDI5T0tRa001?= =?utf-8?B?Zm1xNzR5QzlLdUpVRlVzUXB5bUR1OVpkUHVBdHdWcy9vSE5INGJwKzJWMWFh?= =?utf-8?B?M2FKYTc0YXVsVFo2cXB1OXdCN2RCOEpNYnRtU1ViU0tNcnY0UDFmUVpmY0Jm?= =?utf-8?B?aXNEQnJLbnZXSkZUek5HcjVaR05YM0FpRGRRNGg0QkZMUXdTWVE3Nk1qTloy?= =?utf-8?B?NWFTSDF2YjVPSlNHNXQ5NFVndWhFK0F1aXArWHRlMmtEY1lnd0VIbTFiRzJa?= =?utf-8?B?Q1g4dHdzNHpJVGdObzNDdEppYXRrR3llTW9mRXdWckdUSXdocDNsMXVmUWl4?= =?utf-8?B?dy9UMkxmY0lYM25NKzRTcGZWTFFrUXZuSGhnQyt4RVpHVUpRREYyV2txR0JK?= =?utf-8?B?VkRSVDRoM292bU44eERDQ2txWHRPU2ZiU0ZZU1gxdGIxSlU5R3ZjUE84N3Ft?= =?utf-8?B?NXNObE1BVUhzODdKRmNiUlZoZ2JJT2xFUE1OS1djMkExeHpuZ3c5L3lESmpS?= =?utf-8?B?c3IxZjVRNUhNRFFzYi9Ra1pleHowc2pNUVh2RFZwTTZlbzZrS2tUbnFrTTRp?= =?utf-8?B?bTEwZTVJRHhkd08rWXpYbnpEWHI2S09MSDZjQnAwQWQxZDY1Y3AxRUltSGJq?= =?utf-8?B?L3A4Zjc5d1BxNWxyaWtJNEgrdi9nbEloczY5UHBGa3FqemIrbkVoNlhuQTI5?= =?utf-8?B?YXNNY3pjYVI1ZVpZcm1SZUc2MXVOSmNFZW4zbnpPWCtMWmZpWDJOd0NGOHhB?= =?utf-8?B?UEp2dnB5OVhySytxZkxGbHNMT1FCWTNnczJCZThzMm9FVXFoZlJ2dVROYmVM?= =?utf-8?B?TStZY0Zvc3FGdVR2MXNQYThuZmdUcVBkVnM5ZWtaWFhPb2pBSFR6WHNvbHVE?= =?utf-8?B?NEhyY2QvYnlURzM0S0Jnb3dtU05RM0tlcVd1N3ZwMGJ4YXd5MGhtcENxUnIy?= =?utf-8?B?eTd2RHFVSWNHME9pMDl6S2VyMVNaNmEvSnZua0tuNy9lYTBEOThDNHQ2K1d1?= =?utf-8?B?cXQrazhoeFRrRDgwazdhbUcyQUt3eUNaYmJkN09peXBFL2FKREhxLzI0QXJz?= =?utf-8?B?T1RoYTBibGJWWmZpUTdteHM5NFkvY0RlbDE1NnVyZ2tYT2dvcEZmaXVyN2Fm?= =?utf-8?B?cWo4M0RQQkRUNlZIQndzeWNTTlhOekZkYjBFZXQrUlpTZG5IeWZxR05WTGpT?= =?utf-8?B?M3lJVm91MzJ5N3hxRzd4dWVWMjQzQWg3M09VWGRTSVV1T0JnUk9mMTVxL0M3?= =?utf-8?B?T256a2NRRjB5bE10bTZ2QlFFN3BwSmFqOFd1cEFyU2pXZ3NMMm91NENzRlJF?= =?utf-8?B?VE0vWHFXYStXNWE1azc5amNONCtlbVh3dGI4Z2FwMEdZYlhyMWdxRjlXMEph?= =?utf-8?Q?zfPWCYsgc7HxuBd0KRQmGaddg?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5c30076-fd8f-480b-9863-08db219ed09d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 19:36:59.3626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n3s8nj2M794whqak7yDFqtKJUSUl8GAlGcwTAyoPgGX/hz7yEWqMnwavPyRHjtNj X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6379 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2023 9:35 AM, Dongdong Liu wrote: > From: Huisong Li > > Currently, the setting of hash algorithm comes from the > default configuration in driver and the rte_flow interface. > The hash algorithm that is set to hardware in both ways is > saved in hw->rss_info.conf.func. > > But the 'func' in struct rte_flow_action_rss is usually used > in rte flow interface. And the ethdev ops interface may also > set hash algorithm in the future. It is not appropriate and > is a little messy for ethdev ops interface and driver default > configuration to use struct rte_flow_action_rss. So we have > to separate the RSS configuration from ethdev ops and rte > flow interface to make codes more easier to maintain. > Agree that it is not ideal to have two different ways for same/similar control path functionality in ethdev. +Ori to discuss if this is a common problem and can be resolved in ethdev layer. I can see some of remaining patches are related to this ethdev / flow API RSS separation. I will continue with this set, but I believe it is better if this issue addressed in higher level. > This patch separates hash algorithm by following ways: > 1) 'hash_algo' in struct hns3_rss_conf is used for ethdev ops > interface or default configuration in driver. > 2) Add a 'rte_flow_hash_algo' field in struct hns3_rss_conf > to save algorithm from rte flow interface. The main reasons > are as follows: > Currently, only the last rule is used to restore the rte > flow rule. If 'func' in RSS action is 'DEFAULT', it means > that this rule doesn't modify algorithm and driver need to > save current algorithm for restoring algorithm during reset > phase. > > Fixes: c37ca66f2b27 ("net/hns3: support RSS") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Dongdong Liu <...>