From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check
Date: Fri, 14 Apr 2017 10:04:10 +0100 [thread overview]
Message-ID: <db69ca85-04ff-326b-3730-2ad16f0bc95f@intel.com> (raw)
In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA0207EB95@PGSMSX103.gar.corp.intel.com>
On 4/14/2017 4:52 AM, Zhao1, Wei wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Tuesday, April 11, 2017 11:21 PM
>> To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [PATCH] net/ixgbe: fix duplicated check
>>
>> Same check duplicated, updated check according what commend states.
>>
>> Coverity issue: 1407507
>> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>> index e2ba9c2..803d6f8 100644
>> --- a/drivers/net/ixgbe/ixgbe_flow.c
>> +++ b/drivers/net/ixgbe/ixgbe_flow.c
>> @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct
>> rte_flow_attr *attr,
>> index++;
>> NEXT_ITEM_OF_PATTERN(item, pattern, index);
>> if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) &&
>> - (item->type != RTE_FLOW_ITEM_TYPE_VLAN)) {
>> + (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) {
>> memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
>> rte_flow_error_set(error, EINVAL,
>> RTE_FLOW_ERROR_TYPE_ITEM,
>> --
>> 2.9.3
>
> Acked-by Wei Zhao<wei.zhao1 @intel.com>
OK.
So, will continue with this patch, your version [1] marked as rejected.
[1]
http://dpdk.org/dev/patchwork/patch/23606/
next prev parent reply other threads:[~2017-04-14 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 15:20 Ferruh Yigit
2017-04-13 9:48 ` Ferruh Yigit
2017-04-14 3:52 ` Zhao1, Wei
2017-04-14 9:04 ` Ferruh Yigit [this message]
2017-04-14 9:06 ` Zhao1, Wei
2017-04-14 9:08 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db69ca85-04ff-326b-3730-2ad16f0bc95f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).