From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 3D717282 for ; Fri, 14 Apr 2017 11:04:13 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 14 Apr 2017 02:04:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,197,1488873600"; d="scan'208";a="1155849581" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga002.fm.intel.com with ESMTP; 14 Apr 2017 02:04:11 -0700 To: "Zhao1, Wei" , "Zhang, Helin" , "Ananyev, Konstantin" Cc: "dev@dpdk.org" , "Lu, Wenzhuo" References: <20170411152034.23784-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: Date: Fri, 14 Apr 2017 10:04:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 09:04:13 -0000 On 4/14/2017 4:52 AM, Zhao1, Wei wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Tuesday, April 11, 2017 11:21 PM >> To: Zhang, Helin ; Ananyev, Konstantin >> >> Cc: dev@dpdk.org; Yigit, Ferruh ; Lu, Wenzhuo >> ; Zhao1, Wei >> Subject: [PATCH] net/ixgbe: fix duplicated check >> >> Same check duplicated, updated check according what commend states. >> >> Coverity issue: 1407507 >> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") >> >> Signed-off-by: Ferruh Yigit >> --- >> drivers/net/ixgbe/ixgbe_flow.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c >> index e2ba9c2..803d6f8 100644 >> --- a/drivers/net/ixgbe/ixgbe_flow.c >> +++ b/drivers/net/ixgbe/ixgbe_flow.c >> @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct >> rte_flow_attr *attr, >> index++; >> NEXT_ITEM_OF_PATTERN(item, pattern, index); >> if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) && >> - (item->type != RTE_FLOW_ITEM_TYPE_VLAN)) { >> + (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) { >> memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); >> rte_flow_error_set(error, EINVAL, >> RTE_FLOW_ERROR_TYPE_ITEM, >> -- >> 2.9.3 > > Acked-by Wei Zhao OK. So, will continue with this patch, your version [1] marked as rejected. [1] http://dpdk.org/dev/patchwork/patch/23606/