From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D7B085424 for ; Fri, 2 Nov 2018 15:48:55 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB34B1F8EE; Fri, 2 Nov 2018 14:48:54 +0000 (UTC) Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52FDD106A7B6; Fri, 2 Nov 2018 14:48:15 +0000 (UTC) To: Tiwei Bie Cc: dev@dpdk.org, jfreimann@redhat.com, zhihong.wang@intel.com, jasowang@redhat.com, mst@redhat.com, wexu@redhat.com References: <20181031102640.15377-1-maxime.coquelin@redhat.com> <20181102134159.GA17867@debian> From: Maxime Coquelin Message-ID: Date: Fri, 2 Nov 2018 15:48:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181102134159.GA17867@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 02 Nov 2018 14:48:54 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 0/2] vhost: packed ring support completion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 14:48:56 -0000 On 11/2/18 2:42 PM, Tiwei Bie wrote: > On Wed, Oct 31, 2018 at 11:26:38AM +0100, Maxime Coquelin wrote: >> In this v4, it restores back to only save last avail index and >> its wrap counter value at get time, and restore both used >> and avail indexes to avail values at set time. >> The change compared to v1 is that wrap counter value is >> saved into bit 15, so that it is consistent with the event >> suppression structure format. >> >> Initial series ading packed ring layout support to the >> vhost library was missing the save and restore of the >> wrap counters and indexs on vring base requests used for >> migration. >> >> First patch saves/restores the used and avail indexes and their >> wrap counters values into/from the vring state num field. >> >> Maxime Coquelin (2): >> vhost: add packed ring support to vring base requests >> vhost: advertize packed ring layout support >> >> lib/librte_vhost/vhost.h | 3 ++- >> lib/librte_vhost/vhost_user.c | 40 +++++++++++++++++++++++++++++------ >> 2 files changed, 36 insertions(+), 7 deletions(-) >> >> -- >> 2.17.2 >> > > Reviewed-by: Tiwei Bie > > Thanks! > Applied to dpdk-next-virtio/master Maxime