From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 495E24591F; Fri, 6 Sep 2024 17:18:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7638342F4D; Fri, 6 Sep 2024 17:18:27 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id CC1FB4028F; Fri, 6 Sep 2024 17:18:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725635905; x=1757171905; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Fd5vwQElqfp9mkwAtoBxsH6m3yv4Q9xq+3Ba4HGNCMc=; b=cf5F1+bmDIoouk6ghXHRG8qlP+QbuU4o2Rc346+smJiBY8pOZ5irS9Jn hqRJj/0namy7cDo+IzmbVBmw1BFnQJNTGiV5Cfouy0OvBHcYj/GuXmDJQ QVBsAMPzT3AMkmA7dtOjaN98kyfNLJGlKVWLv97gN8OvGeKfgHLzP+Aif LPJN94ruiMgNLBNDo5hWYanOvDhtKLoXbNy+VIIrVOSh8kSqhXI6ENHsw o/DE13PbtFTu+GnIz4vjK2d6snK/6otsh0yTK3zyHq3IuVvgiboAsuwCW rx2gOH8XP0An2RmuTviAgnWAVawIR3xVodX7KghsPvo3kRigUBzyRf3Mo g==; X-CSE-ConnectionGUID: tij3gPpkQhC6VqZY0I6lYw== X-CSE-MsgGUID: LfC8GskwTSq/YHF7WEWBqA== X-IronPort-AV: E=McAfee;i="6700,10204,11187"; a="35783476" X-IronPort-AV: E=Sophos;i="6.10,208,1719903600"; d="scan'208";a="35783476" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 08:18:24 -0700 X-CSE-ConnectionGUID: 93/ZyRWURuSz+orwXoyYVg== X-CSE-MsgGUID: by7fwxTfRb61HvnWKw0GYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,208,1719903600"; d="scan'208";a="70389145" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Sep 2024 08:18:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 6 Sep 2024 08:18:23 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 6 Sep 2024 08:18:23 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 6 Sep 2024 08:18:23 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 6 Sep 2024 08:18:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r49/U2u/HRt8LMW1+aQcFR0v58FTVj4/fguvFCcAEnhoAmCWNJ8o97ASonmgJBqd058UyQVaJlfmTk5SO8t4XvkzR/WNsxrV10CdXoEYwicwrETQG5GuNmSz8AEjOrVv5uJn76rla31q71jhEXOKNtrjedStlyU1YqF0f0b95rNBSFwZqNTeMDliRvBtderubI5ZicOyc9+v4RUnoBjcY+ffcUMIm592V6/w2kaFmhiwN9m9GQjoIyRA+nXkbXimmvO3T7VzenXBC/PlUEeHS3pipu99VZaTfllZAJCz9NQwhNecANuhchIKRg8boY9/iIEOhUPyjBvlLftG0rS/ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fd5vwQElqfp9mkwAtoBxsH6m3yv4Q9xq+3Ba4HGNCMc=; b=MXReOnRfA5t4GHb4mySRJ9z4jrX/igVo7eNFQbXrzxPsvCi40r4jg3fI25ChmcG+FAO49v6IjJAxXrthNYgTVjKuXbiVJYMqOSoF2qFYyE+VND6pyk5xIQskbmkPR9F48w6XHHaQpcbUq2NOx5EkIJ3LpO5A0oGtC4H7LSPvgPfd5eMVB6ZtTv0EMnMQzJqWIQx3zhvRxaTbbAEKtb0Z3NLVjqI5F94RgNzoVNWebDb1zDt43G+eXKXwE5ycTEp12qefyf/6w8wrAfgBpcqMqcMgvCoVttc8LlOxI99a/6GfA6Q7uiJryFjzUjCfJSljab1Fi7rDIY6tJZivbHACdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by PH0PR11MB5077.namprd11.prod.outlook.com (2603:10b6:510:3b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.28; Fri, 6 Sep 2024 15:18:19 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::2962:1efd:f912:a5a3]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::2962:1efd:f912:a5a3%7]) with mapi id 15.20.7939.017; Fri, 6 Sep 2024 15:18:17 +0000 Message-ID: Date: Fri, 6 Sep 2024 16:18:13 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] eal/x86: fix 32-bit write-combined stores To: Bruce Richardson , CC: References: <20240906132757.457921-1-bruce.richardson@intel.com> Content-Language: en-US From: Radu Nicolau In-Reply-To: <20240906132757.457921-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR05CA0001.eurprd05.prod.outlook.com (2603:10a6:10:36::14) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|PH0PR11MB5077:EE_ X-MS-Office365-Filtering-Correlation-Id: b3e55b66-bcdc-4460-1e98-08dcce872277 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?djU1aWNGRnl1ZGNIVUpvSGd5ZlJXSHNBZDB3RThBeWh6Zlc2aWVjWXF2aUxK?= =?utf-8?B?eUxuUFhOZHF5MGJWVDZKNEc5WmRHYy96ZGhwNE5YRUozbVFKZW1zT1dOUTNY?= =?utf-8?B?VnM4Myt4ZjdaMGd0dCtvSWtNZjhPYUhVcFVFWk9ycWhnVHB2NGpBdS9nMGtq?= =?utf-8?B?ZFBGZ3hzbmlwRXdZQy8rcTZhbG51dkRENEl4bm1ONmx5c24yZ3VVSmJIUzhx?= =?utf-8?B?cllCUGJlV1E2ZU96TG45SXg4RUJSRnhQZjhJVG05TGZoUDVVNkVsMG1Qb3FS?= =?utf-8?B?YkhRY2gzMHhrZFJCVWNWTVFkREZwckt4Y3Q5OG9scVlrUXBrdEhjeHJhSk5T?= =?utf-8?B?YU9kdVRFVVVtU0RhVUIyUkZFdmRVTlVDTUUwR1NFM05Od2RQTUtWMUtBLzRy?= =?utf-8?B?RktyVDdnQjJtWVFpMEIyVTJBTHJCY3VhRU5lZzJpK0JORzVLWDRneVo0SlB2?= =?utf-8?B?RDlnSnNTdTFjV3RZY2JBQWYrcjRQZEJHSGpmYjJuSHA3cUtIaG83RHk3YXh1?= =?utf-8?B?d3ZscDM0NjdHcUdKbEtkcVpCWmdlWHNnaldWUUNJS0NrNVZ3QnZuOWFsc3Aw?= =?utf-8?B?OTZxaXRJSUtuUmVMenVlSFhXMWlWaEpXa3BvUjVWMEQzeW1QYTM0MUFSQWZv?= =?utf-8?B?a0IveXJIcDZabUcrdDFOdGltVk1jTExSMzlkcXViZlVRNTNuUnRiZ3pFdnlV?= =?utf-8?B?VGNUK2ZLaUhnRlFCSjZVcDJWTVRyUVdOT2UzTDByUUp3UFUyZlZ2RERNemZY?= =?utf-8?B?MkJ6VHlNT0VWZS9Qc3V5YnUvZmZXSDVnY2I4S3ZGQ2lKZkgyZld6RHltTW1i?= =?utf-8?B?WW9hM2FEMjFOVk92bms3YjZHcjlVMGRPZTN4RXZqc3FveXB4cmZTV3F4VDNt?= =?utf-8?B?QkluTEwrOW15WElLM0NJTkVFblNYRWRUSnFPOU1nSkJxb3o5L3pxZlRNYWxj?= =?utf-8?B?elAzL2pzT3lOa1BwMExqcUtuWVpVd0svS3V1bDdlVnBvTWk3M2dYKzRBY2Q1?= =?utf-8?B?MkFFSnpSRy9NNWhpclZ2QVhvdWhlbkRwSnZ3TmxBZ1JZbFF1YlhvRjd3UWFS?= =?utf-8?B?WnlqaDJYM2JtOElEYm9BYkM5VTduM3RaekwrWVU1SHRSM0JUbEROQnNVWXZB?= =?utf-8?B?cmJZWjFLNXZZb3ZvTGdDeC9uZEtvU1UzSG1KVit6SEZxUW13ZDEwWWwyd2hG?= =?utf-8?B?cnNQNWtzOFJwbUVZajNuZWRRZ2R5SVRCVjJ5MlUrMnZIdERqbVUzVlRWeU1k?= =?utf-8?B?OVVEd3NONmE4SlZqbTYzRXRsM0swNmZHNjh1TU80ZjRGNHVBc1NSd1g4eTMx?= =?utf-8?B?SXo0U1d1YldMTmp6UndCRkNyTnNIOEpBTWphcXpraG54dWdQVExkZ3JKUnFl?= =?utf-8?B?NzlUamtpb0Fvc3IvUlRzdTQrb2NkamhpTXNPTnl3cTI2ZTNpWGNpNkZyV1hJ?= =?utf-8?B?YWRjcmtiOEk5dnBsU2Q1VHBOQlkwSXhTR3BzbFo0UmVXTmsvM0tjcytlczht?= =?utf-8?B?WWFCelRTVVJ5TURzU0ZpcU9XZ0Zvd2pMbnU4T09EenV6WngyMEJ0TkZJSnAr?= =?utf-8?B?S3I4cWZaZ2grU3FaSFJTTDZ3VmlOM0tBWU9TT2FyVGZUWWorTVVmNkNLSHRl?= =?utf-8?B?dE0wRG1Qak1Uc2NCZ0lYRndsSDFsNktISlpDdVJJeHpuSDY0Z3BYZmlNUVZl?= =?utf-8?B?WENVYVIrN1ZKMldDL2Z1UlFIMVJ4MjM3Z3BJRGxJcE8ycHo3QlVzelZqZmFZ?= =?utf-8?B?ZnFIN0xQVTRDUkkzWnBlRkNqcllNTTMvSEczZ2dSZFpZbVdWalJsVFhQZ3Rs?= =?utf-8?B?NEcwZHJXa24wTmxTTFZHUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2F1a1g1cmpBMENMU2tIRGQzemlYT3hYTWhMUkxVVmxjRmRRVXF0d05XS3RD?= =?utf-8?B?dHZUNk8vRnFtMFk4Z3dGTmptOXRCUkhQd0RXb0QrSDRkNFhxcnRFNlpPRytj?= =?utf-8?B?T1lhUmJjR0UwdWVlcXVOdW1FVm93SUR1NVBEMEtvZGkvWnFMSFZMQ0dUK0JO?= =?utf-8?B?RzlicVlNSDZ4L2pVbXF2YzVCYTA3djV1c3lONjF3aVlwV3VWWDVwbGhjMmNW?= =?utf-8?B?d21vWU1vWENadXRqWEw1ejJWVGFHSWhiSnRacXZlZXhWNUtscEwxcEloeGd0?= =?utf-8?B?Tnh3RFYySWYwOHNabUE0dGh3Z1BpOW9XdHYwWU9OQTFQQzBwRTYvOVRIemtu?= =?utf-8?B?ZVJLVURQU1FuYUN6WlJQN1F2QWFkNXRiMzMrM1ByZENBdDNCMkdlK2ZoaXk3?= =?utf-8?B?a3d4L0RUQk1Ub1ZiU3Z6NXJpa0NFTE5oN3VhZkk5aUhYSFB3OFVSZDlDNGZU?= =?utf-8?B?eVgvZmxpcXhNMHUwK1BQTUhaSFpGZitkcGU3RGJ3NDUzVWtTWkZzZlkvbFJq?= =?utf-8?B?M0srbXNpQ0ZORkxCUkhVQU1uQ0N2MjBnbUl4SGNQQWlkSXZGYWpMNHdNdlRM?= =?utf-8?B?QWRvMjhlM213Rm5xRktnNUxwdmZVQzhzQVY3T2J6eWVRQWJNOUJxNDZ5RElS?= =?utf-8?B?c3BpMHNJLzJaeXBZaGlmay9jN2JZRTE5c1c0VkZKcTNsS1ZsYVh0TTNZWGow?= =?utf-8?B?T3M1bURVczkra3VZOGk4L1d6TFRZUyttODJ0QVY5VU1RbWg0ZkpRakNVR1Fu?= =?utf-8?B?emtaaTVsMFlqaFNkY2UyNEJKSU9UZzZ0REpabU5uNnp4ZkN4S0EvTkdZdy9v?= =?utf-8?B?bnBsRDN5eFlTVVlvV0ZVVHh5S25xbWtJbUVPWndQcU90ai9nM201QzBZNWRp?= =?utf-8?B?b0VlalFlakJBS2MrT1FYMUlvbjdSOUtoZ0ZlaFZsUXpoYVd1cHRJdnlJZ2ZL?= =?utf-8?B?dEQvd0FNbWhmbHpaVktvS3plczdibnNNSFpKSEVZQW1ua1NlNy9iaWFWMUhO?= =?utf-8?B?aGtSVXhma1YyOFBMQTBySWVsWTVIT2RucXZIMVVPcTViV0prQlhIVE9GSCt2?= =?utf-8?B?M2ZycDUyeEN5Znl5emtYLzdNZVdaVTFXSTRqRllyemJTRllIOFg2clFFUWVX?= =?utf-8?B?NkcwdmVubmhiUGRPMzhqVjcyai8weWtURUZobTlaQjR2elF4dStEWnJmWXpB?= =?utf-8?B?bVF4M2pDb01jeHRiNlZ0RTVwQjBPMTlqdmY5WXRjTjhpVUdLUzl6NmlaQ2Vn?= =?utf-8?B?RFVXM0dyQTZacHpQYXhJYlZ4Ymh0ZEp0OUFNdnh3NzVRNFM5OVJrMURaaXor?= =?utf-8?B?eTRsNXE5cGwvNGNuQ2M1bVNvQU85K1l0b2RpQW43YnAwbTNzSEZNSmVxTnRR?= =?utf-8?B?OG5ubW5hS1VneXN2M0g3NkI2aTZuTVdCaWJXT2dtMlRNRDY4bHI1aTZSTmc4?= =?utf-8?B?dmhUdmhRSVNFSXZVME9QRHo4Sm9WZnZGNG9KYU85TTFNVHZRaWhxWUV6cVlD?= =?utf-8?B?aDF4eURsRHhPc0x3YmJ0MmxiOTZRT1NucnJYZHhvL2FsbWJTSEJqNFlBd3ZN?= =?utf-8?B?cTlUUVdScTJRMzQ1aE04VWxjMkdaVXFyNFJidjFPWkNOU21ZdnVrK2JZU043?= =?utf-8?B?ckMzaXhJRWN6T3RLN2VTNjk1WStGeXVDNVJhL1RndTc0cTJqbGNpdjhENTli?= =?utf-8?B?VjVvYnRCNUdXWHV1c1p5QUZQQlNUNEpzSUZYYlBoa0RtVHQ0dmorYmNpZHlN?= =?utf-8?B?c1FDc2tyK1ViR2RXMEVvbVlObCt4SER6VkJ2UkVuaEZYZDN5TVZCVXJFaDdw?= =?utf-8?B?Z2JZSllsaEJTcFFGQlJNcUhOUEcvSnV4NzVhMGRMZ3NNU0dvWGZHQlBGSEhR?= =?utf-8?B?QjZxSzYvTXpjM2lWOWhsNFpsYnUvM3dDOWFzWC9OL296OTNBM2hEREsrMFZZ?= =?utf-8?B?ZWROUVprWDB2VUIzWksyWXNJdnVjRjkxWFl6WUR4VGNxdXZQY3lOcnRjSVBu?= =?utf-8?B?K1A0MXIzTnZmV1NUZ1ZGcUFZeFZCclk3RGRjSGZKYWNVdDRTR0Z0MUU1ZHR3?= =?utf-8?B?QW15Ni9Hd08wVmxJYmhJSzNOUHJ1azloRHEra2N6ditrZFg1Zi96UTdGWlc1?= =?utf-8?B?dmkycUZmdjBVWDlFWHBkbTVmaFl0OUxtWUtNWm5NWlVPMm4wdFRyb0tPbm9F?= =?utf-8?B?RWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b3e55b66-bcdc-4460-1e98-08dcce872277 X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2024 15:18:17.7438 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E8FtfFZod7c5wCg4eVcRsG7ugsrBSoFcHVOahOu2XBGbASUf2BJEQQ+6IlmrMKk2q9CMLgusqV4NuFNotlZERg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5077 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 06-Sep-24 2:27 PM, Bruce Richardson wrote: > The "movdiri" instruction is given as a series of bytes in rte_io.h so > that it works on compilers/assemblers which are unaware of the > instruction. The REX prefix (0x40) on this instruction is invalid for > 32-bit code, causing issues. Thankfully, the prefix is unnecessary in > 64-bit code, since the data size used is 32-bits. > > Fixes: 8a00dfc738fe ("eal: add write combining store") > Cc: radu.nicolau@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- Acked-by: Radu Nicolau