From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF55DA2EEB for ; Wed, 11 Sep 2019 01:01:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32F621EB6F; Wed, 11 Sep 2019 01:01:49 +0200 (CEST) Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by dpdk.org (Postfix) with ESMTP id 0EF4B1EB68; Wed, 11 Sep 2019 01:01:47 +0200 (CEST) Received: by mail-qt1-f193.google.com with SMTP id n7so22903347qtb.6; Tue, 10 Sep 2019 16:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5nsd43QNrmr+3LkW0KmwxNFsj9r522J57BOCpHnevK4=; b=TflIAsS+2qhGHuxjpbKg8/cYaohwARcTsomsCuB4HWdpE24Pxs+977EM2jLUpjCbXh UM5Hxe19Z7Bh+WwMc5N9rth191cjrPBibbJ0PjHtMJ6JTO6gf2AxxFI/LNsgvxNZnuoo YXY2EjCrtpPDJyEfCfsvNXFwk3XU/1IuNGGsxwFHwB7OoUt51cUI1F+2FFl6cntaRx4P il5bmZs6rC/AkVLppFC0f3LFlex1TT6olyeB+tnbaM5LrLV+1ZE/JhJpqr1Pmg3dQmF/ OewYiml5qNEBbwxO9I2SvP2wvNEdXgdT6fiOr9JDxJSTp82R4uX3QhLeV2I/FSMY7US/ o2NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5nsd43QNrmr+3LkW0KmwxNFsj9r522J57BOCpHnevK4=; b=Bs8MmyA/XuOdxC74NfW7ZfZfCDxhCiPhMPpOsrN8PwTj8iAro0th2/mL15b+5xSSLt HmiZRPIMPWDboqoEReN7jwF8MWQl38FugNNJTpS9bB14V7ou5CSkuPvY0Wib7iKP3RET SSqoqBMSQnrxNurb3t+Xeu+pJf8Nec1waWycdloYep2vXQRDoNfTML0B+jLYmfjW3bu2 eC7t4IPm9vF7m8dO52N29sz4j7czof0OCQV0u8V+9kinvLoBap9M3L1RYFraG/8IZf7W 8czk+rF5RG1ylga4si/ttw7wpM9SkES83/6R0nRl9qf6IKn+isfwlwdfImHO37LPoram l+qg== X-Gm-Message-State: APjAAAXRseI/Srx+mZYBc11woleLoLmE4rp5I+dqF+QfUVFlxRPX20x8 MpnN421VAvF8DUQuXHMsM9JnpxuTrqI= X-Google-Smtp-Source: APXvYqzl350GREqjey0WGBecY5OOXexV8utndtnhsm0qQxYn4wOr2CF4vWRl0EFfTZ3UoO3gRsjgEg== X-Received: by 2002:ac8:6a03:: with SMTP id t3mr30957510qtr.27.1568156506236; Tue, 10 Sep 2019 16:01:46 -0700 (PDT) Received: from [192.168.1.10] (pool-96-255-60-31.washdc.fios.verizon.net. [96.255.60.31]) by smtp.gmail.com with ESMTPSA id t26sm8836781qkt.10.2019.09.10.16.01.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2019 16:01:45 -0700 (PDT) To: Andrew Rybchenko , Chas Williams Cc: dev@dpdk.org, Igor Romanov , stable@dpdk.org References: <1568103959-25572-1-git-send-email-arybchenko@solarflare.com> <1568103959-25572-2-git-send-email-arybchenko@solarflare.com> From: Chas Williams <3chas3@gmail.com> Message-ID: Date: Tue, 10 Sep 2019 19:01:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1568103959-25572-2-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 01/18] net/bonding: fix link speed update in broadcast mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Chas Williams On 9/10/19 4:25 AM, Andrew Rybchenko wrote: > From: Igor Romanov > > Fix the issue that the link speed of the bond device was set to the > link speed of the first active slave in broadcast mode. > > Set the link speed of the bond device to the minimum value across > all of the slaves in that case. > > Fixes: deba8a2f8b0b ("net/bonding: fix link properties management") > Cc: stable@dpdk.org > > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index f774e5677..fed71bd95 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -2395,8 +2395,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete) > * packet loss will occur on this slave if transmission at rates > * greater than this are attempted > */ > - for (idx = 1; idx < bond_ctx->active_slave_count; idx++) { > - link_update(bond_ctx->active_slaves[0], &slave_link); > + for (idx = 0; idx < bond_ctx->active_slave_count; idx++) { > + link_update(bond_ctx->active_slaves[idx], &slave_link); > > if (slave_link.link_speed < > ethdev->data->dev_link.link_speed) >