From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA3CB42946; Sat, 15 Apr 2023 02:47:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77BF640A8A; Sat, 15 Apr 2023 02:47:48 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 3B46C40697 for ; Sat, 15 Apr 2023 02:47:47 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Pyvlk1BX9zJrMK; Sat, 15 Apr 2023 08:46:58 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 15 Apr 2023 08:47:44 +0800 Subject: Re: [PATCH v2] dmadev: add tracepoints To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , , Kevin Laatz , Bruce Richardson CC: References: <20230414090901.32164-1-fengchengwen@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35D8787A@smartserver.smartshare.dk> From: fengchengwen Message-ID: Date: Sat, 15 Apr 2023 08:47:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8787A@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Morten, Both fix in v3, thanks. On 2023/4/14 20:46, Morten Brørup wrote: >> From: Chengwen Feng [mailto:fengchengwen@huawei.com] >> Sent: Friday, 14 April 2023 11.09 >> >> Add tracepoints at important APIs for tracing support. >> >> Signed-off-by: Chengwen Feng >> >> --- >> v2: Address Morten's comment: >> Make stats_get as fast-path trace-points. >> Place fast-path trace-point functions behind in version.map. > > ... > >> +RTE_TRACE_POINT( >> + rte_dma_trace_vchan_status, > > rte_dma_trace_vchan_status should also be a FP trace point. > >> + RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan, >> + enum rte_dma_vchan_status *status, int ret), >> + int vchan_status = *status; >> + rte_trace_point_emit_i16(dev_id); >> + rte_trace_point_emit_u16(vchan); >> + rte_trace_point_emit_int(vchan_status); >> + rte_trace_point_emit_int(ret); >> +) >> + >> +RTE_TRACE_POINT( >> + rte_dma_trace_dump, >> + RTE_TRACE_POINT_ARGS(int16_t dev_id, FILE *f, int ret), >> + rte_trace_point_emit_i16(dev_id); >> + rte_trace_point_emit_ptr(f); >> + rte_trace_point_emit_int(ret); >> +) >> + >> +/* Fast path trace points */ > > Don't add the fast path trace points here. Add them to the rte_dmadev_trace_fp.h file. > >> + >> +/* Called in loop in examples/dma */ >> +RTE_TRACE_POINT_FP( >> + rte_dma_trace_stats_get, >> + RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan, >> + struct rte_dma_stats *stats, int ret), >> + rte_trace_point_emit_i16(dev_id); >> + rte_trace_point_emit_u16(vchan); >> + rte_trace_point_emit_u64(stats->submitted); >> + rte_trace_point_emit_u64(stats->completed); >> + rte_trace_point_emit_u64(stats->errors); >> + rte_trace_point_emit_int(ret); >> +) > > With those two fixes, you may add: > > Acked-by: Morten Brørup > > > . >