From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E88AA09F0; Thu, 17 Dec 2020 11:06:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10C62C9B2; Thu, 17 Dec 2020 11:06:37 +0100 (CET) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by dpdk.org (Postfix) with ESMTP id 18FA3C9AE for ; Thu, 17 Dec 2020 11:06:35 +0100 (CET) Received: by mail-wm1-f54.google.com with SMTP id r4so1270138wmh.5 for ; Thu, 17 Dec 2020 02:06:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Lik4ZAD3yYR47NzxKfK9+lxE6QUZn1o0Q3AVvEVYG3E=; b=RSt4qXReBMfD6yNSAx1ZrSWbsV3dhBQew5YoMEJB89D7Y3sC+k8kbVaJToYhroHUdm RTelPRvp5sbGNHrT0dn+VWZTwe+Xc3VFOiZvAXnte5mFXn67iJA5C56RgjdB+kI7iR3I 38YTY3rvMGrivRkWV/HQtQcY6u2WLud+sCqnkMiXDIC/+7yPSlLiMEpozdXgyoWNEo/J zlAIyWCZigewCP/75tlKPW9YU7nyLELkz5LQBoLK60XBYI9tTSctwt50DLuEKUWEQKI8 MnVv2b/A27foNb3VpXodzocB9UEXNKVMkYgoZQeX98O6ty/96Yx8ZsBngCyTGt9FmhLW Z4LA== X-Gm-Message-State: AOAM531I7N/kMrwIskm0ShGDFTJ/30ecaF7/M1SxfYlDxZb7X2GMaVqQ gvAGws1Cev47uFNegettNmk= X-Google-Smtp-Source: ABdhPJxKD2MlFZLEepO76Jn6b3H4KM7Y14ef54wGj0r2OWwYa/X01dyYUw7XyoncoSmFvHRfCiQ4wQ== X-Received: by 2002:a1c:bc57:: with SMTP id m84mr7679995wmf.163.1608199593849; Thu, 17 Dec 2020 02:06:33 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id s63sm8002446wms.18.2020.12.17.02.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Dec 2020 02:06:33 -0800 (PST) Message-ID: From: Luca Boccassi To: Ferruh Yigit , Liron Himi Cc: "dev@dpdk.org" , Kevin Traynor , Akhil Goyal Date: Thu, 17 Dec 2020 10:06:32 +0000 In-Reply-To: <57e2bee8-d74a-6c88-f535-24bc1d18b25e@intel.com> References: <20201202130529.7332-2-lironh@marvell.com> <20201215222319.13816-1-lironh@marvell.com> <57e2bee8-d74a-6c88-f535-24bc1d18b25e@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] meson: update meson build for armada drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-12-16 at 13:52 +0000, Ferruh Yigit wrote: > On 12/16/2020 1:41 PM, Liron Himi wrote: > > -----Original Message----- > > From: Ferruh Yigit > > Sent: Wednesday, 16 December 2020 15:37 > > To: Liron Himi > > Cc: dev@dpdk.org; Luca Boccassi ; Kevin Traynor ; Akhil Goyal > > Subject: [EXT] Re: [PATCH v2] meson: update meson build for armada driv= ers > >=20 > > External Email > >=20 > > ---------------------------------------------------------------------- > > On 12/15/2020 10:23 PM, lironh@marvell.com wrote: > > > From: Liron Himi > > >=20 > > > With pkg-config support available within musdk library (from > > > musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' > > > can be removed. > > > PKG_CONFIG_PATH environment variable should be set appropriately to > > > use the musdk library. > >=20 > > Hi Liron, > >=20 > > It is good change to get rid of an custom meson option, can we or shoul= d we backport this to the v20.11? > > [L.H.] yes, it can be backported. > >=20 >=20 > Kevin, Luca, >=20 > What do you think about backporting this patch to 19.11 & 20.11, it remov= es=20 > 'lib_musdk_dir' custom meson config option and uses pkg-config to find th= e musdk=20 > libraries. >=20 > It looks good change but not sure if it is a regression to remove a build= option. >=20 > Thanks, > ferruh I don't know how used it is, but removing a meson_option is no good for LTS. If there is no functionality/build breakage and it's 100% compatible, it could be made a no-op - that would be acceptable for me. --=20 Kind regards, Luca Boccassi