From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20084.outbound.protection.outlook.com [40.107.2.84]) by dpdk.org (Postfix) with ESMTP id 0B7B4DE3 for ; Mon, 8 Oct 2018 11:43:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BUiXF+id3io8M9fK7oYKpC6d/P04/wq89pAvSXih6ZQ=; b=s43grmMUCgeT2vLoNove5j5PAfGsj3FoC5+a/kzaCLvsnTUmsTN4Zi0rohgNUuDKp/yhr8F0UaU7+urEiL+Kk594MnkIXx6SHlhpEt4Knk/BruqRZc8LcEuGgoL9T1ErI5d1KhPY8IcmNtHmamQjHbuDBbF1pnnZ4rU9RQgX9Os= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by AM0PR04MB4675.eurprd04.prod.outlook.com (2603:10a6:208:75::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.28; Mon, 8 Oct 2018 09:43:49 +0000 To: Ferruh Yigit Cc: Reshma Pattan , Hemant Agrawal , Ashish Gupta , Fiona Trahe , Pablo de Lara , Akhil Goyal , Declan Doherty , Fan Zhang , Rahul Lakkireddy , Gaetan Rivet , Qi Zhang , Xiao Wang , Beilei Xing , Wenzhuo Lu , Konstantin Ananyev , Rasesh Mody , Harish Patil , Shahed Shaikh , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Nipun Gupta , Anatoly Burakov , Thomas Monjalon , Jerin Jacob , Olivier Matz , dev@dpdk.org References: <20181004034047.26824-1-ferruh.yigit@intel.com> <20181005162612.31906-1-ferruh.yigit@intel.com> From: Shreyansh Jain Message-ID: Date: Mon, 8 Oct 2018 15:13:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181005162612.31906-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR01CA0115.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::31) To AM0PR04MB4675.eurprd04.prod.outlook.com (2603:10a6:208:75::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45d63d82-cb0b-4c9b-ad8b-08d62d028fbd X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB4675; X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4675; 3:BgqA4bzle67t+irG3t6wtngKAywXKeu76uiG51Vnkv251Ry+kwhdPyakMKhXvOcOdL61ii2H3RtoWxBJkeLkdu2u7C7Le+vqrXEQ/0opBG6EwscwicMFgAQCejaREH26Ini1fYAnCBLxSy8bKQ+cbpdMe0hrvQqia9rXmHJXDas0/x0DVbr/eFeZ6gHzmvVjNLk6bX/kNSHltmCttssaB8wcj3zcyomO2oLxVMniYKwOiBD61T3RIQyAfsNVakUb; 25:N5ElTxWFQ3P8LXaTwyXd0GYcfdKjcZwRYHHlKLqRXBh+DHZr4JQiWiU5iPN5qGW7N/yhr75/5CW8hDWQl+1mzRpOjroMdLHHaBFeLfz3mKzgY5PkVGRHqQmrR9gI5+ZKan2u8mhbZqTdcQmkEUtj6ashKMX4GAeLXQYx/zO7WrJvICztN/TKZi/MSv62gE67gWiGyGnguCTtIGz0teKC71VSjZbXld24qOKuHo227U9Q7u7QKfHzyGD62rmVwFoJzSsAJvv68+qNuRIoNSJWXF0DCUqQ0lL3K2p72cigTelxQnmZBPKDKAip286L4q5SXQ297MiPZY9hT9A1d9sC5Q==; 31:U8SdrkCafjRnmhDNqENYIlJWkRWkdiVQ//CkmFwlg4f4kCNVJecdS9MqSgc3RiS8sMn67NyY6lNz6pPrQ7vf4NHoE0JI4FusO42ACOZ+99gYYlRMJ5L18L9cBzy9FT1Xh6nKjZKB+5ncd5ndpTwBnsdhRYvsoot103YAAHVVHLenWNcMy7z38ZwAGoHr/AdtTBHfL5aUb9isY7RnW7FRECs8iXtU4UNg0vFHx0Klxvw= X-MS-TrafficTypeDiagnostic: AM0PR04MB4675: X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4675; 20:i+uINmLHjISz9EQqOSJ6nKMtTSrVYGeCJiWgkrm32VL+IyesFuxn5ZMKuc1MOgrnuhAmCQZMRHE23ae5Q0ivRtnsOffDXaNp7erup1vu61PcZ7h6qYeWTvtUN7Dc9MTYkSC5h4FwQJso9+dR0Q25paqdgO2+euvZ8pq46GlXrZsq3bQEk9098uIjnbI1rPcoMCgoj/rHcP71H40P+fSrd+Xh8aUPF1ccTC0RVOBmEGjYsChibK+gJ3nZpLN1IKR0XkinuYvWpKkXQlWgjyVLnODL7CACysW3ado1BoVxPLO6BK7M0CvW/5kzisVUwKyFUYJR/JWa0JxdMBGn8czVmwuAJKybyDxb10KKixO2DbTsNmAg6fpLn7dsdoCBCP3O+6JxamQr7zX1R2fhbyQZsa9LeAHscvRTtN176XhqZYBbAlRNK8aKTNOswWFnGXLDCmOGizl3ge+mTJLUZVD/FraSPI4oInHlVSC0A7S8Rhjm/qkHqmJAhWLsYEu7PT2d; 4:TWZvqfy/O+r587wXzuIbzNO8XTHfVaw56ir7+dv7JXxYwdFz6xBq4Gj8wDSDTlz9abI8XR4Mp1NU+d8tO0LfGklCILehh1n+D+91sf3hvBVMr++d8HnEjFkrOWpn2LMzpJLzA1c5UhMEebjfmQRXKS9oTCEmitcuWAQdfQjnc04nWqOJnsfAQjyEgZUmwT64fDXKb48yn6MORPKSLweiKc6ryIBKOD7pCO+7IRjJwhGZq4qzi9ga05AUikapKSCoBQDLmB+TecotawWTEBYhgzwDyXGr1tLfsec3eqTQtrlvhzVoUPkPIYbSNXhl25GovecHmqXre48lRVUJwqV/22OLFlxPXfDXR9m8ZCpsyNI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201708071742011)(7699051); SRVR:AM0PR04MB4675; BCL:0; PCL:0; RULEID:; SRVR:AM0PR04MB4675; X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(136003)(396003)(39860400002)(376002)(346002)(199004)(189003)(486006)(55236004)(31686004)(76176011)(58126008)(386003)(23676004)(2486003)(52146003)(186003)(44832011)(16526019)(26005)(77096007)(53936002)(105586002)(106356001)(50466002)(6486002)(52116002)(36756003)(16576012)(66066001)(305945005)(2616005)(476003)(64126003)(11346002)(316002)(446003)(229853002)(956004)(2906002)(47776003)(8676002)(7736002)(5009440100003)(65826007)(8936002)(7416002)(3846002)(6116002)(6916009)(65806001)(65956001)(81156014)(81166006)(25786009)(5660300001)(97736004)(86362001)(4326008)(68736007)(6666003)(230700001)(31696002)(54906003)(67846002)(6246003)(478600001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB4675; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTBQUjA0TUI0Njc1OzIzOkZnS3Azc1dmc3FTRnhEVVJNbzZiV3I3MVh0?= =?utf-8?B?Sm5kVHhtdmxpRk5Nd05qYkQra003QTBjcUtZS0xBTGVzOHJJSFFzRkRjZnM5?= =?utf-8?B?NUpuOG1tSzdRelRkQVI5R0xKcDg3K05TRHFBWTNzSkRpeUtQeWpVaXRxeXhI?= =?utf-8?B?czNJNWIvMUgwMVBzNnNnRFVpMTg0aGVFOHh0YktZRThEZitBQ1RCTG0yanRo?= =?utf-8?B?blpTYWxNbUM0eDNicUMyZ2QwcW4ySjVxckozVUpIaE5CVStuandtSXVoOGFu?= =?utf-8?B?ek1SbE1ubWs3Nm1qRzM2aHdkbzFUL0haMHJLNXIxNFozSTA0U1Y0RFZmOU9w?= =?utf-8?B?NkhRRGlCNlpXYUhhQm5DUWpMMWJoQlNha2I1MU40S2ZnN3dDSU1YQm85cVA2?= =?utf-8?B?VmY0TU9BQmpMWU55b2FiTjBOdFB6NWZ0VlI3MVpxZWFJOFFLd2YzZTlGV1lx?= =?utf-8?B?Qm9CREVmY1VVcFR3YjlQR1FvYWN0UHNueUp3SGFkYlJ2UlI5RkNPK1FhTXUw?= =?utf-8?B?aytZZkNuN2tzdHVZOFdxMXE3ejk2dFVGKzFkNk44VHZ5VHlaQmpYSDFIT1pZ?= =?utf-8?B?Y3ZjZ0h4eWwvZTlyQ05xazN1azI0eXZRSytTeGZxdmlVL1lYUEJaVDBoTXJ5?= =?utf-8?B?V3FaejdTWHRKaHNLTXp2a2FlcnhOc1BSelI3NDlOU09YYmFaTEdiZGZWZlll?= =?utf-8?B?b3dWa3NlSWovbUwyRWJVbkt3a1FURlRFYXo4dlorQjdvb29LdCtrcHhZclVX?= =?utf-8?B?Njk5Y055Z043dVNKWnRwaDE3YXJRWWl3cWZKQSsybDlzV0o3RXZmVkhNVXRV?= =?utf-8?B?MTZwdmZDazZYRXVSY2pRVmNBY0d2SFNuWmxqOVB5dmovUU9SRGpRS0pXZUdY?= =?utf-8?B?TGpoV2dqLzJCSzZMWFlYb1daeW1LbFVHbXFjVVJ0eE1COU4xUXQycFFzNmh3?= =?utf-8?B?aG5EU0RvWUxhV2xheWdVdGx4UTFoMEpXWFN3TDlMLzhrblBMbytBT251eDNl?= =?utf-8?B?UVoraERnSTltTzF4MGtGdXBvSXN6VFFJeWlQQUNuOENMMDFWcklRR1UyTnFa?= =?utf-8?B?K2RETmgxSEM3bkZxdzQrNkh5UXBzdURMQU9EWHRQRkxVTVluRUpSakdEWWps?= =?utf-8?B?cjZnaWxIV1k4WjdPRlZFVW9NcVQ1Zk1QYUJPeTYyd2JvY2tIY1U5ekZZOVlX?= =?utf-8?B?dkNBaXpUVjc3OEZiMlh4d0orS3QrelRoTTd4Z2tVcHhPRXRJTFMzYThHUVd0?= =?utf-8?B?UDhhNE9ReFFoUlpDUWpCTnViY1ltaC83R1lwby9tSW5mb3drYithTU5Yazk5?= =?utf-8?B?SDFnWkVUZHcvU0dYdDdOTzlwelZDUGdTYW9JaE15UmxqVTRzbkFRNElMKzcy?= =?utf-8?B?WFFaSXFBOUs0ZStrTlBkckNXNWNjc21TQ3hEOE12b1hONXcvTG9OMm9EeWU3?= =?utf-8?B?L2JyOS9BYU9SWFplYWROZ0hXeXFMb05SN2xSQWUxUVhVQzZ3WHZ6Tlk3SWw4?= =?utf-8?B?bllPOWZFM0hXSHJqNWJGckhObUk5amlEUjNPNXg4WlpOVXFFMUlMTWNEdFdk?= =?utf-8?B?d1Jaa2I2V0FKd0RUYXFac0VLTlNqNnVCMnlQZ0hQS0lEU21XbnRIdlVjcWVy?= =?utf-8?B?SEk4UXdmTTFzalhqTldyUU9MVGVqeFhucU5lUFJoRFQ5NkFpbGxwS0JGY2w2?= =?utf-8?B?YjRYWW1jVHBSazZoaGpPdHVENHBFS0N2WE14T2VRaTFNbWJ6UG1ERGt0RXdG?= =?utf-8?B?WTZFdmc4QzRJMDVPTjJGcGhCY09nU1Q1SmFJVU1jM1NVd2owNTkwa2tsTWxt?= =?utf-8?B?WU9CQ1RVYmNBZFBBQ1VCVE1WY0Y5VFZOODZUWTV2ZStVNTgxK09rU21nYVlp?= =?utf-8?B?TllWQU1wQzJNaXNua1RiOC9Zb0VtVEVCMkZKOGhUSUphMW1EVnFPVnIzSHQ1?= =?utf-8?B?SUZmTUpjMzZFQUw3bWt0aXBOTTNqWlcxNG9mM2t2ZUt2cmIvYU53UW44TmFO?= =?utf-8?B?SVVPL2xhUkNFK0NSSGxZMUxucmQrRmJBMGphZS9UZzVqVzA1TUdLb3NWdUNZ?= =?utf-8?B?Q0c3dU50emFLTjN0RTFORWVyNERGdFRQWDhSUzlKaUNRcVZxcmszdGpTVU9s?= =?utf-8?B?SGc9PQ==?= X-Microsoft-Antispam-Message-Info: 73sYsvolbpO8S5vkHRXK65sawl3K1cPIhPBQEVjlRK6euSwLwEilHm1Imj6f27hzuRGY7XB4fECcQ6Y/xvDryfYOR43VNwr5yeATcvGPaDj4qC5FRYxoxbhe9ffkrFb5T63CKab6o5io+E1EVtxOETmnTI5EkwWEgBfG8aJLIJiK3Hzxp3Y4p7ZyQueFn3DZ7u7VqiNJ/528+5AKHfe14QaUAmL/6vTtnNSYYYLHdAj/bOxyR5Db7WF8Kj6xbBcmTHJMAVIik7BIiCLpPHpHGnOrZq/HrU0boorr0P96E3RLJb90Ci/QVHIWDDMn0sf38vIzWQUYHiYzwRREl/aQziZ7EXJKsPMV82oyOzMisjk= X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4675; 6:3oFMDt2fPqm4ukzbNYv3iSdu5255HF69ICNn9EGeZRWDi8o2JPit02Jp+p/TqVLj1d/4t6uunlpxSWM3qYZwzPXduvDQdNa7SE3jLGek1t+mmwQHpAM5fT0IROfyiKaHzeiZoRoKqxEmqJwQcBNVcZPQqxJGgAz5YWA5lw136YNMP4p51iFQjwNFqMXpXAQNj//KVVrKCIb3+ux56AG0615f1T8UjHWeXSTwCk72ZnQF9u6vYqHguLKC33LfClSfXYnq4CZpmqJy+7bPfWZ+dJUWazPoaKwzdxkd/9cDZpWKcIyy+spRlYb7ExVZOZgpc9ZNWv1H900yaK4yeoRsGHB6Lky3+dT2i0yzHRlacJ1yqy5MsiypX3qZbjaHGkvVOBv5WTcOxnDdJskHGSm9xBAVm7o7F797I3xjL8RUJl6KXjfBAScA+G1HTQe35uMcPpxX19fHBumvaeF7lEYZbw==; 5:7w4OXDhd8ha/8hJXAWlpClV3uaAqicJ2N9gvNkSELrdwP4FszVvBqunyH6Y4gKvcucuIf9FR8CB3LUptLmlnVhaHbSNH1b70evyptx21uaiC/3GW9PXobh0HDn96xsy4HLnGQuouX02mRWYna4uPLb7SUPIP6y93AXIfNMihoZ0=; 7:ewOIIWtfJeFDIn0yZ7DmojABkZ4UkQyS4/TcGM+fH72laODiYjF/BSLYe0JrbibgLk+Aq2s1OzDt57zgBXTJ4zKcwJoIaxSRp8+ayQTmt7QIjgzyMtHxgWksgHbOUqbf7ooCYQMzVVlSjB7D9QQcyjRjahvEcKLM93r8XO/8HvSMcUm+8EGA6EMHmVG+Q0+GxbMkS1WIcbH6N9amGWBle5O10Fm5TNBbi9tLIfawtVTRC85Vd1/jHp9AL60al/Dd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2018 09:43:49.3778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45d63d82-cb0b-4c9b-ad8b-08d62d028fbd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4675 Subject: Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 09:43:57 -0000 On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: > Some global variables can indeed be static, add static keyword to them. > > Signed-off-by: Ferruh Yigit > --- > Series is based on next-net tree > --- [...] > drivers/bus/dpaa/base/fman/netcfg_layer.c | 2 +- > drivers/bus/dpaa/dpaa_bus.c | 4 ++-- [...] > drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 4 ++-- > drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 2 +- [...] > 42 files changed, 54 insertions(+), 56 deletions(-) > [...] With respect to changes in above files (and for aim of the patch series): Acked-by: Shreyansh Jain