From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 25678376C
 for <dev@dpdk.org>; Tue, 19 Jul 2016 17:27:02 +0200 (CEST)
Received: from alille-653-1-293-182.w90-1.abo.wanadoo.fr ([90.1.53.182]
 helo=[192.168.1.13])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1bPWxk-0004td-7x; Tue, 19 Jul 2016 17:29:37 +0200
To: Zoltan Kiss <zoltan.kiss@schaman.hu>, dev@dpdk.org
References: <1468939061-19734-1-git-send-email-zoltan.kiss@schaman.hu>
Cc: David Hunt <david.hunt@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <dc3659b1-2c41-9824-71df-5b856e653f14@6wind.com>
Date: Tue, 19 Jul 2016 17:26:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.1.0
MIME-Version: 1.0
In-Reply-To: <1468939061-19734-1-git-send-email-zoltan.kiss@schaman.hu>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mempool: fix lack of free() registration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jul 2016 15:27:02 -0000

Hi Zoltan,

I ran ./scripts/check-git-log.sh on your patch, showing some minor
styling issues:

On 07/19/2016 04:37 PM, Zoltan Kiss wrote:
> [PATCH] mempool: fix lack of free() registration

"()" should be removed

> The new mempool handler interface forgets to register the free() function
> of the ops. Introduced in this patch:
> 
> 449c49b9 mempool: support handler operations

The format should be:
Fixes: 449c49b93a6b ("mempool: support handler operations")


> 
> Signed-off-by: Zoltan Kiss <zoltan.kiss@schaman.hu>
> ---
>  lib/librte_mempool/rte_mempool_ops.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c
> index fd0b64c..5f24de2 100644
> --- a/lib/librte_mempool/rte_mempool_ops.c
> +++ b/lib/librte_mempool/rte_mempool_ops.c
> @@ -81,6 +81,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h)
>  	ops = &rte_mempool_ops_table.ops[ops_index];
>  	snprintf(ops->name, sizeof(ops->name), "%s", h->name);
>  	ops->alloc = h->alloc;
> +	ops->free = h->free;
>  	ops->enqueue = h->enqueue;
>  	ops->dequeue = h->dequeue;
>  	ops->get_count = h->get_count;
> 

Apart from that:
Acked-by: Olivier Matz <olivier.matz@6wind.com>

+CC Thomas, I think it should be included in 16.07.

Thanks!