From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0821DA046B for ; Mon, 22 Jul 2019 19:16:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 580C21BF37; Mon, 22 Jul 2019 19:16:22 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 104BD1BF35 for ; Mon, 22 Jul 2019 19:16:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 10:16:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,295,1559545200"; d="scan'208";a="192790237" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga004.fm.intel.com with ESMTP; 22 Jul 2019 10:16:17 -0700 To: "Iremonger, Bernard" , "viveksharma@marvell.com" , "dev@dpdk.org" Cc: "intoviveksharma@gmail.com" References: <1563349511-27968-1-git-send-email-viveksharma@marvell.com> <0a9838fc-e6f0-f96c-6a5e-b447c032a4b7@intel.com> <8CEF83825BEC744B83065625E567D7C260DD2C48@IRSMSX108.ger.corp.intel.com> <092c4b9c-a04a-3a3a-a677-049058251296@intel.com> <8CEF83825BEC744B83065625E567D7C260DD2DE4@IRSMSX108.ger.corp.intel.com> <42a80f4a-6993-f544-4b54-ea1b24d0c511@intel.com> <8CEF83825BEC744B83065625E567D7C260DD2F75@IRSMSX108.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE 0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T YR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q CgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M 1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I z+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr GE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte HQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG gMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7 X07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K /s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1 pBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q MJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp g0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8 YO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7 sgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY xWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84 Qz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa ARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a N3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv 0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv VQ== Message-ID: Date: Mon, 22 Jul 2019 18:16:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DD2F75@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/22/2019 6:03 PM, Iremonger, Bernard wrote: > Hi Ferruh, > > > >>>>>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip >>>>>> offload >>>>>> >>>>>> On 7/17/2019 8:45 AM, viveksharma@marvell.com wrote: >>>>>>> From: Vivek Sharma >>>>>>> >>>>>>> Support QinQ strip RX offload configuration through testpmd >>>>>>> command line and boot time arguments. >>>>>> >>>>>> For the testpmd command part, unfortunately there are two set of >>>>>> commands for same purpose, the new ones are (lets both port and >>>> queue >>>>>> level): >>>>>> "port config rx_offload ..." >>>>>> "port (port_id) rxq (queue_id) rx_offload ..." >>>>>> "port config (port_id) tx_offload ..." >>>>>> "port (port_id) txq (queue_id) tx_offload ..." >>>>>> >>>>>> These are better implementation comparing the old one: >>>>>> "port config all ..." >>>>>> >>>>>> Would you mind sending a patch to remove "port config all ..." >>>>>> variant of setting offloads? >>>>>> And you can make your changes to the new commands above. >>>>> >>>>> Is it ok to remove "port config all ..." commands as they may be in >>>>> use by >>>> the community? >>>> >>>> Since there is a command that replaces the removed functionality I >>>> think it is OK. >>>> >>>> Also I am not sure what level of backward compatibility we should >>>> provide for testpmd commands. >>> >>> It might be better to leave "port config all ..." commands as they are for >> now and provide a separate patchset for the new style port setting offloads >> commands. >>> >>> If they are to be removed there should at least be something to announce >> this in the release notes. There is a deprecation process which is used for the >> rest of the code, why not follow that process. >> >> Deprecation process is for ABI/API changes. >> >> I can see testpmd commands also a kind of user interface, but this is a test >> application at the end, deprecation process can be overkill here. >> Although +1 to be cautious on command consistency and keep some level of >> stability on them. > >>>>>> For the application argument, ``--enable-hw-vlan-extend``, instead >>>>>> of adding a parameter of each offload argument, (and event it is >>>>>> not clear if it is only for Rx or Tx), have a "--rx-offloads" >>>>>> argument and feed >>>> the list via this, like: >>>>>> "--rx-ofloads=disable-crc-strip,enable-rx-timestamp" >>>>>> >>>>>> >>>>>> >>>>>> And lastly for the "vlan set ..." update, I think "qinq" was >>>>>> already defined but it was calling 'vlan_extend_set()', now you are >>>>>> changing it and making it call 'rx_vlan_qinq_strip_set()', I think >>>>>> this is OK, but can you please update the 'cmd_help_long_parsed()' >> accordingly? >>>>> >>>>> 'vlan_extend_set()' and 'rx_vlan_qinq_strip_set()' are different >>>> commands. >>>>> vlan_extend_set() is for adding the second vlan and >>>> rx_vlan_qinq_strip_set() is for removing the second vlan. >>>> >>>> yes they are different, I think nobody said they are same. >>>> What is the concern here, can you please detail more? >>> >>> In the previous paragraph, you mentioned that "I think "qinq" was >>> already defined but it was calling 'vlan_extend_set()', now you are >>> changing it and making it call 'rx_vlan_qinq_strip_set()' " >>> >>> vlan_extend_set() is not being changed, rx_vlan_qinq_strip_set() is being >> added. >> >> Before this patch, >> "vlan set qinq" calls 'vlan_extend_set()' >> >> After patch, >> "vlan set qinq" calls 'rx_vlan_qinq_strip_set()' > >> And again after this patch, >> "vlan set extend" added and which calls 'vlan_extend_set()' >> >> so the patch looks like adding "vlan set extend" command, but practically it >> does fix "vlan set qinq", I said "I think this is OK" and asked for help string & >> documentation update accordingly. >> >> I hope it is clear now. > > Yes, I see what you mean now (well spotted). > Previously the "qinq" keyword mapped to extend now it maps to qinq_strip. It would be better to leave the function of the "qinq" keyword as it was add a "qinqstrip" keyword instead of adding the "extend" keyword. > >>>>>> And in original 'cmd_help_long_parsed()' for 'vlan set ...", it >>>>>> doesn't need to have separate lines for "strip, filter & qinq", can >>>>>> you please merge them, and later the 'extend' one? >>>>>> Than change needs to be documented on "testpmd_funcs.rst" >>>>>> >>>>>> >>>>>> And as a last thing, can you please send this as multiple patches: >>>>>> 1) Command line change for setting qinq offload >>>>>> 2) Application argument change >>>>>> 3) "vlan set " related changes >>>>>> >>>>>>> >>>>>>> Signed-off-by: Vivek Sharma >>>>>> >>>>> >>>>> Regards, >>>>> >>>>> Bernard >>>>> >>> In my opinion this patch was fine for the "port config all ..." style >> commands. >> >> Duplication is bad, it is bad to have two different ways to do same thing. >> I am not sure if Vivek is aware of duplicated functions but explicitly prefers to >> update old versions. >> I suggest lets stop improving these ones and get rid of them asap. > > Testpmd is widely used so removing commands without notice will probably not go down too well with the community. We can make sure release notes is updated for removed commands and what is replacing them, also can have same thing in the commit log, these can help user. But I am dubious to follow deprecation process for testpmd commands. > >> Also as you can see commit log doesn't mention from "vlan set ..." changes at >> all, that is why I asked for splitting this into 3 patches for 3 separate thing it >> does. > > Ok, it should describe the "vlan set ...." changes. > >>> A separate patch set should be submitted for the new style setting offloads >> commands. >>> >>> Regards, >>> >>> Bernard >>> > > Regards, > > Bernard >