From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Yuanhan Liu <yliu@fridaylinux.org>, Jiayu Hu <jiayu.hu@intel.com>
Cc: dev@dpdk.org, lei.a.yao@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt
Date: Wed, 19 Jul 2017 09:03:52 -0700 [thread overview]
Message-ID: <dc476440-1311-4007-a32e-0386b1b2ae9a@intel.com> (raw)
In-Reply-To: <20170719110845.GX11626@yliu-home>
On 7/19/2017 4:08 AM, Yuanhan Liu wrote:
> On Wed, Jul 19, 2017 at 11:18:23AM +0800, Jiayu Hu wrote:
>> When use rte_eth_dev_configure() to enable rx queue interrupt for virtio
>> devices, virtio_configure_intr() isn't called to set up the interrupt
>> environment, which causes rx queue interrupt setup failed. This patch is
>> to fix this issue.
> Hmm, how was this supposed to work in the begining when this feature
> was introduced? Jianfeng?
In the v17.05, virtio_configure_intr() will be called by
virtio_dev_configure() if the request feature is changed. That's not
correct.
>
> --yliu
>
>
>> Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>> ---
>> drivers/net/virtio/virtio_ethdev.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
>> index 00a3122..66656ed 100644
>> --- a/drivers/net/virtio/virtio_ethdev.c
>> +++ b/drivers/net/virtio/virtio_ethdev.c
>> @@ -1688,6 +1688,13 @@ virtio_dev_configure(struct rte_eth_dev *dev)
>> return -ENOTSUP;
>> }
>>
>> + if (dev->data->dev_conf.intr_conf.rxq) {
>> + if (virtio_configure_intr(dev) < 0) {
>> + PMD_DRV_LOG(ERR, "failed to configure interrupt");
>> + return -ENOTSUP;
>> + }
>> + }
>> +
Hi Jiayu,
I would expect this will not work for virtio pci devices (QEMU might
crash). Could you double check that?
Thanks,
Jianfeng
>> if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
>> /* Enable vector (0) for Link State Intrerrupt */
>> if (VTPCI_OPS(hw)->set_config_irq(hw, 0) ==
>> --
>> 2.7.4
next prev parent reply other threads:[~2017-07-19 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 3:18 Jiayu Hu
2017-07-19 3:23 ` Yang, Zhiyong
2017-07-19 11:08 ` Yuanhan Liu
2017-07-19 16:03 ` Tan, Jianfeng [this message]
2017-07-31 2:30 ` Yuanhan Liu
[not found] ` <ED946F0BEFE0A141B63BABBD629A2A9B38787115@shsmsx102.ccr.corp.intel.com>
2017-07-31 3:47 ` Yuanhan Liu
2017-07-31 7:28 ` Hu, Jiayu
2017-07-31 7:56 ` [dpdk-dev] [PATCH v2] " Jiayu Hu
2017-07-31 17:01 ` Maxime Coquelin
2017-07-31 17:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc476440-1311-4007-a32e-0386b1b2ae9a@intel.com \
--to=jianfeng.tan@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=lei.a.yao@intel.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).