* [PATCH] net/hns3: fix user priority 4-7 didn't enable PFC
@ 2024-03-06 9:20 Jie Hai
2024-03-08 20:31 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Jie Hai @ 2024-03-06 9:20 UTC (permalink / raw)
To: dev, Yisen Zhuang, Wei Hu (Xavier),
Hao Chen, Ferruh Yigit, Chunsong Feng, Min Hu (Connor)
Cc: lihuisong, fengchengwen, liudongdong3, haijie1
Currently, hns3 driver only enable user priority 0-3 when the
user set TC number to 4 and enable PFC and ETS by dev_configure.
In this moment, the packet with user priority 4-7 cannot trigger
PFC frame. By the way, the nb_tcs from user can never be 0 because
of the ahead check in driver. So remove this redundant code.
Fixes: 62e3ccc2b94c ("net/hns3: support flow control")
Cc: stable@dpdk.org
Signed-off-by: Jie Hai <haijie1@huawei.com>
---
drivers/net/hns3/hns3_dcb.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3/hns3_dcb.c
index 2831d3dc6205..915e4eb76817 100644
--- a/drivers/net/hns3/hns3_dcb.c
+++ b/drivers/net/hns3/hns3_dcb.c
@@ -1499,7 +1499,6 @@ hns3_dcb_info_update(struct hns3_adapter *hns, uint8_t num_tc)
static int
hns3_dcb_hw_configure(struct hns3_adapter *hns)
{
- struct rte_eth_dcb_rx_conf *dcb_rx_conf;
struct hns3_pf *pf = &hns->pf;
struct hns3_hw *hw = &hns->hw;
enum hns3_fc_status fc_status = hw->current_fc_status;
@@ -1519,12 +1518,8 @@ hns3_dcb_hw_configure(struct hns3_adapter *hns)
}
if (hw->data->dev_conf.dcb_capability_en & RTE_ETH_DCB_PFC_SUPPORT) {
- dcb_rx_conf = &hw->data->dev_conf.rx_adv_conf.dcb_rx_conf;
- if (dcb_rx_conf->nb_tcs == 0)
- hw->dcb_info.pfc_en = 1; /* tc0 only */
- else
- hw->dcb_info.pfc_en =
- RTE_LEN2MASK((uint8_t)dcb_rx_conf->nb_tcs, uint8_t);
+ hw->dcb_info.pfc_en =
+ RTE_LEN2MASK((uint8_t)HNS3_MAX_USER_PRIO, uint8_t);
hw->dcb_info.hw_pfc_map =
hns3_dcb_undrop_tc_map(hw, hw->dcb_info.pfc_en);
--
2.30.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/hns3: fix user priority 4-7 didn't enable PFC
2024-03-06 9:20 [PATCH] net/hns3: fix user priority 4-7 didn't enable PFC Jie Hai
@ 2024-03-08 20:31 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2024-03-08 20:31 UTC (permalink / raw)
To: Jie Hai, dev, Yisen Zhuang, Wei Hu (Xavier),
Hao Chen, Chunsong Feng, Min Hu (Connor)
Cc: lihuisong, fengchengwen, liudongdong3
On 3/6/2024 9:20 AM, Jie Hai wrote:
> Currently, hns3 driver only enable user priority 0-3 when the
> user set TC number to 4 and enable PFC and ETS by dev_configure.
> In this moment, the packet with user priority 4-7 cannot trigger
> PFC frame. By the way, the nb_tcs from user can never be 0 because
> of the ahead check in driver. So remove this redundant code.
>
> Fixes: 62e3ccc2b94c ("net/hns3: support flow control")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-08 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 9:20 [PATCH] net/hns3: fix user priority 4-7 didn't enable PFC Jie Hai
2024-03-08 20:31 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).