Re: [dpdk-dev] [PATCH v2] vhost: mark vDPA driver API as internal

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 11/1/21 07:50, Xia, Chenbo wrote:
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Thursday, October 28, 2021 10:16 PM
>> To: dev@dpdk.org; techboard@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
>> xuemingl@nvidia.com; Wang, Xiao W <xiao.w.wang@intel.com>;
>> david.marchand@redhat.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH v2] vhost: mark vDPA driver API as internal
>>
>> This patch marks the vDPA driver APIs as internal and
>> rename the corresponding header file to vdpa_driver.h.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>>
>> Hi Techboard,
>>
>> Please vote for an exception for this unannounced API
>> breakage.
> 
> More accurately, the four functions were announced :)

My bad, I forgot about it. Thanks for the reminder!

> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

Maxime

>>
>> Changes in v2:
>> ==============
>> - Alphabetical ordering in version.map (David)
>> - Rename header to vdpa_driver.h (David)
>> - Add Techboard in Cc to vote for API breakage exception
>>
>>   drivers/vdpa/ifc/ifcvf_vdpa.c               |  2 +-
>>   drivers/vdpa/mlx5/mlx5_vdpa.h               |  2 +-
>>   lib/vhost/meson.build                       |  4 +++-
>>   lib/vhost/vdpa.c                            |  2 +-
>>   lib/vhost/{rte_vdpa_dev.h => vdpa_driver.h} | 12 +++++++++---
>>   lib/vhost/version.map                       | 13 +++++++++----
>>   lib/vhost/vhost.h                           |  2 +-
>>   7 files changed, 25 insertions(+), 12 deletions(-)
>>   rename lib/vhost/{rte_vdpa_dev.h => vdpa_driver.h} (95%)
>