From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68A1BA0C4E; Tue, 2 Nov 2021 09:58:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50996410E5; Tue, 2 Nov 2021 09:58:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 343514069F for ; Tue, 2 Nov 2021 09:58:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635843479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GcIqdRQISAC3tK0jYfmSadThALCrJZKm+xJ371KgVlI=; b=Td/2fu0ykgiuOvyguzXkNuIo2HAOj5xeDTpZlF5Gg5I21IG+beuAHdCDEXYqumbtB7GPaW UH4wZv5eL2hqm9VZfvjxpMN2kKUWD3sEd00P2kg9yPB/+NFm20QN0SF7LW3Ki8ZVI6wfz+ ivQmQyLL5etA+aQnq+BhwSYfpEL0NTw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-kDRog6i_Nzatnx1-ZAxk-A-1; Tue, 02 Nov 2021 04:57:56 -0400 X-MC-Unique: kDRog6i_Nzatnx1-ZAxk-A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79793806695; Tue, 2 Nov 2021 08:57:55 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 238EA62A41; Tue, 2 Nov 2021 08:57:38 +0000 (UTC) Message-ID: Date: Tue, 2 Nov 2021 09:57:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: "Xia, Chenbo" , "dev@dpdk.org" , "techboard@dpdk.org" , "xuemingl@nvidia.com" , "Wang, Xiao W" , "david.marchand@redhat.com" References: <20211028141531.58861-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] vhost: mark vDPA driver API as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/1/21 07:50, Xia, Chenbo wrote: >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, October 28, 2021 10:16 PM >> To: dev@dpdk.org; techboard@dpdk.org; Xia, Chenbo ; >> xuemingl@nvidia.com; Wang, Xiao W ; >> david.marchand@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH v2] vhost: mark vDPA driver API as internal >> >> This patch marks the vDPA driver APIs as internal and >> rename the corresponding header file to vdpa_driver.h. >> >> Signed-off-by: Maxime Coquelin >> --- >> >> Hi Techboard, >> >> Please vote for an exception for this unannounced API >> breakage. > > More accurately, the four functions were announced :) My bad, I forgot about it. Thanks for the reminder! > Reviewed-by: Chenbo Xia Maxime >> >> Changes in v2: >> ============== >> - Alphabetical ordering in version.map (David) >> - Rename header to vdpa_driver.h (David) >> - Add Techboard in Cc to vote for API breakage exception >> >> drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- >> drivers/vdpa/mlx5/mlx5_vdpa.h | 2 +- >> lib/vhost/meson.build | 4 +++- >> lib/vhost/vdpa.c | 2 +- >> lib/vhost/{rte_vdpa_dev.h => vdpa_driver.h} | 12 +++++++++--- >> lib/vhost/version.map | 13 +++++++++---- >> lib/vhost/vhost.h | 2 +- >> 7 files changed, 25 insertions(+), 12 deletions(-) >> rename lib/vhost/{rte_vdpa_dev.h => vdpa_driver.h} (95%) >