From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BDA4A04B5; Mon, 11 Jan 2021 11:45:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CCC9140CB5; Mon, 11 Jan 2021 11:45:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 4D7A8140CAF for ; Mon, 11 Jan 2021 11:45:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610361951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S4KL11U1wKj/a625kTD7Z+RC8I3hEP4lAOvsC0OAWKo=; b=OwK0/cA3u4OLewDPy/ctFabhYncSB3hmMp762W+5BnMCPk4ynYSEDpyWUCbEhVLiGMfSOb OrTeRJWjiS3d0hIC+Kj2L3GS3RVnp0bhhLP4nhtOjriPqmKnBvWTUGVNosfsj3LE6WFYIk nfr2lh9SzwvMf4IrhJirXSl9HtFFy1g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-_hXCG5EYNzixra5joaAVCw-1; Mon, 11 Jan 2021 05:45:48 -0500 X-MC-Unique: _hXCG5EYNzixra5joaAVCw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D752E190B2A0; Mon, 11 Jan 2021 10:45:45 +0000 (UTC) Received: from [10.36.110.24] (unknown [10.36.110.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FBFF1899A; Mon, 11 Jan 2021 10:45:39 +0000 (UTC) To: Ferruh Yigit , Joyce Kong , chenbo.xia@intel.com, jerinj@marvell.com, ruifeng.wang@arm.com, honnappa.nagarahalli@arm.com Cc: dev@dpdk.org, nd@arm.com, David Marchand , Thomas Monjalon , dpdklab@iol.unh.edu, Aaron Conole , "Chen, Zhaoyan" References: <20200911120906.45995-1-joyce.kong@arm.com> <20201117100635.27690-1-joyce.kong@arm.com> <20201117100635.27690-3-joyce.kong@arm.com> From: Maxime Coquelin Message-ID: Date: Mon, 11 Jan 2021 11:45:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 2/4] net/virtio: add vectorized packed ring Rx NEON path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/8/21 6:02 PM, Ferruh Yigit wrote: > On 11/17/2020 10:06 AM, Joyce Kong wrote: >> +    /** >> +     *  Update data length and packet length for descriptor. >> +     *  structure of pkt_mb: >> +     *  >> -------------------------------------------------------------------- >> +     *  |32 bits pkt_type|32 bits pkt_len|16 bits data_len|16 bits >> vlan_tci| >> +     *  >> -------------------------------------------------------------------- >> +     */ >> +    pkt_mb[0] = vreinterpretq_u64_u8(vqtbl1q_u8( >> +            vreinterpretq_u8_u64(desc[0]), shuf_msk1)); >> +    pkt_mb[1] = vreinterpretq_u64_u8(vqtbl1q_u8( >> +            vreinterpretq_u8_u64(desc[0]), shuf_msk2)); >> +    pkt_mb[2] = vreinterpretq_u64_u8(vqtbl1q_u8( >> +            vreinterpretq_u8_u64(desc[1]), shuf_msk1))' > > s\'\; > > I will fix in next-net but my concern is why this has been not caught by > any of our automated builds? > > In patchwork only test report seems from the 'checkpatch': > https://patches.dpdk.org/patch/84260/ > Thanks Ferruh for spotting and fixing it. I think the CI was broken at the time it was submitted, it would be great to have a way to manually trigger the CI again! That plus me changing laptop recently and not having a full multi-arch build system up and running again made this build issue pass through... Regards, Maxime