DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Július Milan" <jmilan.dev@gmail.com>, dev@dpdk.org, jgrajcia@cisco.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net/memif: enable loopback
Date: Thu, 27 Feb 2020 16:59:28 +0000	[thread overview]
Message-ID: <dc6ae713-99ea-88bc-b4c7-e3e1308ccbae@intel.com> (raw)
In-Reply-To: <20200219081840.GA11729@vbox>

On 2/19/2020 8:18 AM, Július Milan wrote:
> With this patch it is possible to connect 2 DPDK memifs into loopback,
> i.e. when they have the same id and different roles, as for example:
>   "--vdev=net_memif0,role=master,id=0"
>   "--vdev=net_memif1,role=slave,id=0"
> 
> Signed-off-by: Július Milan <jmilan.dev@gmail.com>

<...>

> @@ -642,8 +645,12 @@ memif_msg_receive(struct memif_control_channel *cc)
>  
>  	size = recvmsg(cc->intr_handle.fd, &mh, 0);
>  	if (size != sizeof(memif_msg_t)) {
> -		MIF_LOG(DEBUG, "Invalid message size.");
> -		memif_msg_enq_disconnect(cc, "Invalid message size", 0);
> +		MIF_LOG(DEBUG, "Invalid message size = %ld", size);

'size' type is 'size_t', can you please use correct format specifier '%zu' for it?
This will fix the 32-bit build.

      parent reply	other threads:[~2020-02-27 16:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  8:18 Július Milan
2020-02-19 13:07 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2020-02-27 16:46 ` Ferruh Yigit
2020-03-09 12:09   ` Július Milan
2020-03-09 11:14     ` Ferruh Yigit
2020-02-27 16:59 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc6ae713-99ea-88bc-b4c7-e3e1308ccbae@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jgrajcia@cisco.com \
    --cc=jmilan.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).