From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B45F43BA4; Fri, 23 Feb 2024 20:19:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E49A84027C; Fri, 23 Feb 2024 20:19:30 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 9414B4027A for ; Fri, 23 Feb 2024 20:19:29 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D5439DA7; Fri, 23 Feb 2024 11:20:07 -0800 (PST) Received: from [192.168.50.86] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A1D603F73F; Fri, 23 Feb 2024 11:19:28 -0800 (PST) Message-ID: Date: Fri, 23 Feb 2024 19:19:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] dts: log stderr with failed remote commands Content-Language: en-GB To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: dev@dpdk.org, Paul Szczepanek References: <20240122182611.1904974-1-luca.vizzarro@arm.com> <20240122182611.1904974-5-luca.vizzarro@arm.com> From: Luca Vizzarro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 29/01/2024 13:10, Juraj Linkeš wrote: > Here's I'd add logged additionally as an error, as this sounds as if > we're changing debug to error That is also a way of doing this, but an error is an error. If we wanted to log the same thing in debug and error, then when we go read the debug we get duplicates... making it less readable. What do you say? > I'd change the order here (and all other places) so that stderr is > before the return code. Ack. > We should mention that the last string is the stderr output. Maybe we > just add 'Stderr:' before {self._command_stderr}. And maybe we should > put quotes around {self._command_stderr}. Since you mentioned "quotes", I'd think that it'd be even better to indent it as if it's a quote. With logs as busy as the ones DTS prints, adding some quotes may not change much as it's all already very crowded. Can prefix with 'Stderr: ' though.